Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star
maintenance/UpdateWeightedTags.php

Summary

Maintainability
D
1 day
Test Coverage

Function validateParams has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

    private function validateParams() {
        $pageOptionCount = (int)$this->hasOption( 'page' ) + (int)$this->hasOption( 'page-list' )
            + (int)$this->hasOption( 'pageid-list' );
        if ( $pageOptionCount !== 1 ) {
            $this->fatalError( "Exactly one of --page, --page-list and --pageid-list must be used" );
Severity: Minor
Found in maintenance/UpdateWeightedTags.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readLineBatch has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    private function readLineBatch( SplFileObject $file, bool $useIds ) {
        $titleParser = MediaWikiServices::getInstance()->getTitleParser();
        $pageStore = MediaWikiServices::getInstance()->getPageStore();
        $linkBatchFactory = MediaWikiServices::getInstance()->getLinkBatchFactory();
        $batchSize = $this->getBatchSize();
Severity: Minor
Found in maintenance/UpdateWeightedTags.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method readLineBatch has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function readLineBatch( SplFileObject $file, bool $useIds ) {
        $titleParser = MediaWikiServices::getInstance()->getTitleParser();
        $pageStore = MediaWikiServices::getInstance()->getPageStore();
        $linkBatchFactory = MediaWikiServices::getInstance()->getLinkBatchFactory();
        $batchSize = $this->getBatchSize();
Severity: Minor
Found in maintenance/UpdateWeightedTags.php - About 1 hr to fix

    Function getPageIdentities has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getPageIdentities() {
        if ( $this->hasOption( 'page' ) ) {
            $pageName = $this->getOption( 'page' );
            $title = Title::newFromText( $pageName );
            if ( !$title ) {
    Severity: Minor
    Found in maintenance/UpdateWeightedTags.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validateParams has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function validateParams() {
        $pageOptionCount = (int)$this->hasOption( 'page' ) + (int)$this->hasOption( 'page-list' )
            + (int)$this->hasOption( 'pageid-list' );
        if ( $pageOptionCount !== 1 ) {
            $this->fatalError( "Exactly one of --page, --page-list and --pageid-list must be used" );
    Severity: Minor
    Found in maintenance/UpdateWeightedTags.php - About 1 hr to fix

      Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function execute() {
        $this->validateParams();
        foreach ( $this->getPageIdentities() as $pageIdentity ) {
            $tagPrefix = $this->getOption( 'tagType' );
            $cirrusSearch = new CirrusSearch();
      Severity: Minor
      Found in maintenance/UpdateWeightedTags.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status