Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
amazon_gateway/amazon.adapter.php

Summary

Maintainability
B
5 hrs
Test Coverage

File amazon.adapter.php has 268 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

use PayWithAmazon\PaymentsClientInterface as PwaClientInterface;
use Psr\Log\LogLevel;
use SmashPig\Core\Context;
Severity: Minor
Found in amazon_gateway/amazon.adapter.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function confirmOrderReference() {
        $orderReferenceId = $this->getData_Staged( 'order_reference_id' );

        $this->setOrderReferenceDetailsIfUnset( $orderReferenceId );
    Severity: Major
    Found in amazon_gateway/amazon.adapter.php and 1 other location - About 1 hr to fix
    amazon_gateway/amazon.adapter.php on lines 323..340

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function confirmBillingAgreement() {
        $billingAgreementId = $this->getData_Staged( 'subscr_id' );
        $this->setBillingAgreementDetailsIfUnset( $billingAgreementId );

        $this->logger->info( "Confirming billing agreement $billingAgreementId" );
    Severity: Major
    Found in amazon_gateway/amazon.adapter.php and 1 other location - About 1 hr to fix
    amazon_gateway/amazon.adapter.php on lines 259..279

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status