Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star

Showing 302 of 302 total issues

Function setReferrer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function setReferrer() {
        if ( !$this->isSomething( 'referrer' ) ) {
            // Remove protocol and query strings to avoid tripping modsecurity
            // TODO it would be a lot more privacy respecting to omit path too.
            $referrer = '';
Severity: Minor
Found in gateway_common/DonationData.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function addData( $newdata, $source = 'internal' ) {
        if ( is_array( $newdata ) ) {
            foreach ( $newdata as $key => $val ) {
                if ( !is_array( $val ) ) {
                    $this->setVal( $key, $val );
Severity: Minor
Found in gateway_common/DonationData.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language