Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star

Showing 302 of 302 total issues

Function setAdapterAndValidate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function setAdapterAndValidate() {
        $this->ensureState();

        DonationInterface::setSmashPigProvider( $this->gateway );
Severity: Minor
Found in gateway_common/DonationApiBase.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                    return;
Severity: Major
Found in adyen_gateway/adyen_submit_payment.api.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return $this->captureOneTimePayment( $provider );
    Severity: Major
    Found in paypal_ec_gateway/paypal_express.adapter.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return;
      Severity: Major
      Found in adyen_gateway/adyen_submit_payment.api.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->createRecurringProfile( $provider );
        Severity: Major
        Found in paypal_ec_gateway/paypal_express.adapter.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in includes/RecurUpgrade/Validator.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return '';
            Severity: Major
            Found in adyen_gateway/adyen_submit_payment.api.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return PaymentResult::fromResults(
            new PaymentTransactionResponse(),
            $this->getFinalStatus()
        );
              Severity: Major
              Found in paypal_ec_gateway/paypal_express.adapter.php - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            TransactionType::AUTHORIZE => [
                'request' => [
                    'amount',
                    'city',
                    'country',
                Severity: Minor
                Found in braintree_gateway/braintree.adapter.php and 1 other location - About 30 mins to fix
                gravy_gateway/gravy.adapter.php on lines 275..302

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this method.
                Open

                            return false;
                Severity: Major
                Found in gateway_common/gateway.adapter.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return true;
                  Severity: Major
                  Found in gateway_common/DataValidator.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return null;
                    Severity: Major
                    Found in gateway_common/gateway.adapter.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return;
                      Severity: Major
                      Found in gateway_common/GatewayPage.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return !is_array( $value );
                        Severity: Major
                        Found in gateway_common/DataValidator.php - About 30 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      'authorize' => [
                'request' => [
                    'city',
                    'country',
                    'currency',
                          Severity: Minor
                          Found in gravy_gateway/gravy.adapter.php and 1 other location - About 30 mins to fix
                          braintree_gateway/braintree.adapter.php on lines 138..165

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 90.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Avoid too many return statements within this method.
                          Open

                                          return '';
                          Severity: Major
                          Found in gateway_common/gateway.adapter.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return $convertAmounts['USD'];
                            Severity: Major
                            Found in gateway_common/gateway.adapter.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      return (bool)$result;
                              Severity: Major
                              Found in gateway_common/DataValidator.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return false;
                                Severity: Major
                                Found in gateway_common/DataValidator.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                          return !$isRecurring && $isMonthlyConvert;
                                  Severity: Major
                                  Found in gateway_common/gateway.adapter.php - About 30 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language