Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star

Showing 183 of 183 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    watch( props = {} ) {
        props.additionalClassNames = props.additionalClassNames || '';
        props.additionalClassNames += ' watch-this-article';

        return new icons.IconButton( Object.assign( {
Severity: Major
Found in src/mobile.startup/icons.js and 1 other location - About 1 hr to fix
src/mobile.startup/icons.js on lines 133..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    watched( props = {} ) {
        props.additionalClassNames = props.additionalClassNames || '';
        props.additionalClassNames += ' watch-this-article watched';

        return new icons.IconButton( Object.assign( {
Severity: Major
Found in src/mobile.startup/icons.js and 1 other location - About 1 hr to fix
src/mobile.startup/icons.js on lines 117..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getPreview has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getPreview: function ( options ) {
        let
            sectionLine = '',
            sectionId = '';
Severity: Minor
Found in src/mobile.editor.overlay/EditorGateway.js - About 1 hr to fix

    Function defaults has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        get defaults() {
        return {
            createDetailsAnchorHref: function () {
                return function ( blockId, render ) {
                    return mw.util.getUrl( 'Special:BlockList', { wpTarget: '#' + render( blockId ) } );
    Severity: Minor
    Found in src/mobile.editor.overlay/BlockMessageDetails.js - About 1 hr to fix

      Method buildAMCToggle has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function buildAMCToggle() {
        $amcToggle = new OOUI\CheckboxInputWidget( [
            'name' => 'enableAMC',
            'infusable' => true,
            'selected' => $this->userMode->isEnabled(),
      Severity: Minor
      Found in includes/specials/SpecialMobileOptions.php - About 1 hr to fix

        Function getMobileMode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getMobileMode() {
        $enableBeta = $this->config->get( 'MFEnableBeta' );

        if ( !$enableBeta ) {
            return '';
        Severity: Minor
        Found in includes/MobileContext.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _enable has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        Toggler.prototype._enable = function () {
    const self = this;

    // FIXME This should use .find() instead of .children(), some extensions like Wikibase
    // want to toggle other headlines than direct descendants of $container. (T95889)
        Severity: Minor
        Found in src/mobile.startup/Toggler.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function doRewriteImagesForLazyLoading has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private function doRewriteImagesForLazyLoading( $el, ?DOMDocument $doc ) {
        if ( $doc === null ) {
            return;
        }
        $lazyLoadSkipSmallImages = $this->skipSmall;
        Severity: Minor
        Found in includes/Transforms/LazyImageTransform.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function loadVisualEditorMaybe has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function loadVisualEditorMaybe() {
            logInit( 'visualeditor' );
            // Inform other interested code that we're loading the editor
            /**
             * Internal for use in GrowthExperiments only.
        Severity: Minor
        Found in src/mobile.init/editor.js - About 1 hr to fix

          Function createPromoCampaign has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function createPromoCampaign(
    onShow,
    actions,
    campaignName,
    campaignActive,
          Severity: Minor
          Found in src/mobile.startup/promoCampaign/promoCampaign.js - About 1 hr to fix

            Function performSearch has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                performSearch( query ) {
        const
            self = this,
            api = this.api,
            delay = this.gateway.isCached( query ) ? 0 : SEARCH_DELAY;
            Severity: Minor
            Found in src/mobile.startup/search/SearchOverlay.js - About 1 hr to fix

              Function _matchRoute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  _matchRoute( path, entry ) {
        let
            didMatch,
            captures,
            match;
              Severity: Minor
              Found in src/mobile.startup/OverlayManager.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function onBeforeExit has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  onBeforeExit: function ( exit, cancel ) {
        const self = this;
        if ( this.hasChanged() && !this.switching ) {
            if ( !this.windowManager ) {
                this.windowManager = OO.ui.getWindowManager();
              Severity: Minor
              Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

                Function filterLanguages has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    filterLanguages: function ( searchQuery, searchOrigin ) {
        const filteredList = [];

        if ( searchQuery ) {
            this.options.languages.forEach( function ( language ) {
                Severity: Minor
                Found in src/mobile.languages.structured/LanguageSearcher.js - About 1 hr to fix

                  Function LanguageSearcher has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function LanguageSearcher( props ) {
    /**
     * @prop {StructuredLanguages} languages` JSDoc.
     */
    const languages = langUtil.getStructuredLanguages(
                  Severity: Minor
                  Found in src/mobile.languages.structured/LanguageSearcher.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    $window
    .on( 'resize', apply2(
        mw.util.debounce( function () {
            eventBus.emit( 'resize' );
        }, 100 ),
                    Severity: Major
                    Found in src/mobile.init/mobile.init.js and 1 other location - About 1 hr to fix
                    src/mobile.init/mobile.init.js on lines 60..76

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function save has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        save: function ( options ) {
        const self = this,
            result = util.Deferred();

        options = options || {};
                    Severity: Minor
                    Found in src/mobile.editor.overlay/EditorGateway.js - About 1 hr to fix

                      Function _matchRoute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          _matchRoute( path, entry ) {
        let
            didMatch,
            captures,
            match;
                      Severity: Minor
                      Found in src/mobile.startup/OverlayManager.js - About 1 hr to fix

                        Function toggle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        Toggler.prototype.toggle = function ( $heading, fromSaved ) {
    if ( !fromSaved && $heading.hasClass( 'collapsible-heading-disabled' ) ) {
        return false;
    }
                        Severity: Minor
                        Found in src/mobile.startup/Toggler.js - About 1 hr to fix

                          Function showEditNotices has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              showEditNotices: function () {
        const overlay = this;
        if ( mw.config.get( 'wgMFEditNoticesFeatureConflict' ) ) {
            return;
        }
                          Severity: Minor
                          Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language