wikimedia/mediawiki-extensions-Translate

View on GitHub

Showing 1,238 of 1,238 total issues

Method initMessages has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function initMessages(): void {
        if ( $this->messages !== null ) {
            return;
        }

Severity: Major
Found in src/MessageLoading/MessageCollection.php - About 2 hrs to fix

    Method run has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run(): bool {
            $mwInstance = MediaWikiServices::getInstance();
            $lb = $mwInstance->getDBLoadBalancerFactory();
            $jobQueue = $mwInstance->getJobQueueGroup();
            $logger = LoggerFactory::getInstance( 'Translate.MessageBundle' );
    Severity: Major
    Found in src/MessageBundleTranslation/UpdateMessageBundleJob.php - About 2 hrs to fix

      Method import has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function import( array $changeData, string $name, int $importStrategy ): array {
              $processed = [];
              $skipped = [];
              $jobs = [];
      
      
      Severity: Major
      Found in src/Synchronization/ExternalMessageSourceStateImporter.php - About 2 hrs to fix

        Method doExport has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function doExport(): Status {
                $out = $this->getOutput();
                $group = MessageGroups::getGroup( $this->groupId );
                $collection = $this->setupCollection( $group );
        
        
        Severity: Major
        Found in src/Synchronization/ExportTranslationsSpecialPage.php - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function rgbaString(rgba, alpha) {
             if (alpha === undefined) {
                alpha = (rgba[3] !== undefined ? rgba[3] : 1);
             }
             return "rgba(" + rgba[0] + ", " + rgba[1] + ", " + rgba[2]
          Severity: Major
          Found in resources/lib/Chart.js/Chart.js and 1 other location - About 2 hrs to fix
          resources/lib/Chart.js/Chart.js on lines 1581..1587

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function hslaString(hsla, alpha) {
             if (alpha === undefined) {
                alpha = (hsla[3] !== undefined ? hsla[3] : 1);
             }
             return "hsla(" + hsla[0] + ", " + hsla[1] + "%, " + hsla[2] + "%, "
          Severity: Major
          Found in resources/lib/Chart.js/Chart.js and 1 other location - About 2 hrs to fix
          resources/lib/Chart.js/Chart.js on lines 1548..1554

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function showConfirmation has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function showConfirmation( PageMoveCollection $pageCollection, TranslatableBundle $bundle ): void {
                  $out = $this->getOutput();
                  $out->addBacklinkSubtitle( $this->oldTitle );
                  $out->addWikiMsg(
                      'pt-movepage-intro',
          Severity: Minor
          Found in src/PageTranslation/MoveTranslatableBundleSpecialPage.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setup has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              private function setup( ?string $parameters ): void {
                  $request = $this->getRequest();
          
                  $defaults = [
                      'language' => $this->getLanguage()->getCode(),
          Severity: Minor
          Found in src/TranslatorInterface/TranslateSpecialPage.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleModificationsSubmit has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              private function handleModificationsSubmit(
                  MessageGroup $group,
                  MessageSourceChange $sourceChanges,
                  WebRequest $req,
                  string $language,
          Severity: Minor
          Found in src/Synchronization/ManageGroupsSpecialPage.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getWritable has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getWritable(): array {
                  $writableServers = $readOnlyServers = [];
                  $ttmServerIds = $this->getNames();
          
                  foreach ( $ttmServerIds as $serverId ) {
          Severity: Minor
          Found in src/TtmServer/TtmServerFactory.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File ui.position.js has 274 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /* eslint-disable */
          /*!
           * Positions elements relative to other elements.
           * Borrowed from jquery.ui.position and updated to remove unused code.
           * Does not pollute the global jQuery or jQuery.ui objects
          Severity: Minor
          Found in resources/src/ext.translate.groupselector/ui.position.js - About 2 hrs to fix

            Function getRgba has 64 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function getRgba(string) {
               if (!string) {
                  return;
               }
               var abbr =  /^#([a-fA-F0-9]{3,4})$/i,
            Severity: Major
            Found in resources/lib/Chart.js/Chart.js - About 2 hrs to fix

              Method onGetUserPermissionsErrorsExpensive has 64 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function onGetUserPermissionsErrorsExpensive(
                      Title $title,
                      User $user,
                      $action,
                      &$result
              Severity: Major
              Found in src/PageTranslation/Hooks.php - About 2 hrs to fix

                Method form has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function form( FormOptions $opts ): void {
                        $script = $this->getConfig()->get( 'Script' );
                
                        $this->setHeaders();
                        $out = $this->getOutput();
                Severity: Major
                Found in src/Statistics/TranslationStatsSpecialPage.php - About 2 hrs to fix

                  Method parseGettext has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function parseGettext( string $data ): array {
                          $mangler = $this->group->getMangler();
                          $useCtxtAsKey = $this->extra['CtxtAsKey'] ?? false;
                          $keyAlgorithm = 'simple';
                          if ( isset( $this->extra['keyAlgorithm'] ) ) {
                  Severity: Major
                  Found in src/FileFormatSupport/GettextFormat.php - About 2 hrs to fix

                    Function EntitySelectorWidget has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    var EntitySelectorWidget = function ( config ) {
                        // Parent constructor
                        OO.ui.TextInputWidget.call( this, {
                            classes: [ 'tes-entity-selector' ],
                            placeholder: mw.msg( 'translate-tes-type-to-search' ),
                    Severity: Major
                    Found in resources/src/ext.translate.entity.selector/index.js - About 2 hrs to fix

                      Method exportGroup has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function exportGroup( MessageGroup $group, array $servers ): void {
                              $times = [
                                  'total' => -microtime( true ),
                                  'stats' => 0,
                                  'init' => 0,
                      Severity: Major
                      Found in scripts/ttmserver-export.php - About 2 hrs to fix

                        Method execute has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function execute(): void {
                                $params = $this->extractRequestParams();
                                $filter = $params['filter'];
                        
                                $groups = [];
                        Severity: Major
                        Found in src/MessageGroupProcessing/QueryMessageGroupsActionApi.php - About 2 hrs to fix

                          Method execute has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function execute( $par ) {
                                  $this->target = $this->getLanguage()->getCode();
                                  $request = $this->getRequest();
                          
                                  $this->purge = $request->getVal( 'action' ) === 'purge';
                          Severity: Major
                          Found in src/Statistics/LanguageStatsSpecialPage.php - About 2 hrs to fix

                            File AggregateGroupsSpecialPage.php has 271 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            <?php
                            declare( strict_types = 1 );
                            
                            namespace MediaWiki\Extension\Translate\MessageGroupProcessing;
                            
                            
                            Severity: Minor
                            Found in src/MessageGroupProcessing/AggregateGroupsSpecialPage.php - About 2 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language