Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star

Showing 1,238 of 1,238 total issues

Function FormHandler has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var FormHandler = function () {
    var $form = $( '#translationStatsConfig' ),
        onFilter = null;

    function getHeight() {
Severity: Major
Found in resources/js/ext.translate.special.translationstats.js - About 2 hrs to fix

    Method run has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run(): bool {
        $this->logJobStart();
        $mwServices = MediaWikiServices::getInstance();
        // We may be doing double wait here if this job was spawned by TranslationUpdateJob
        $lb = $mwServices->getDBLoadBalancerFactory();
    Severity: Major
    Found in src/PageTranslation/RenderTranslationPageJob.php - About 2 hrs to fix

      Method addLanguageLinks has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function addLanguageLinks( Title $title, array &$languageLinks ) {
        global $wgPageTranslationLanguageList;

        if ( $wgPageTranslationLanguageList === 'tag-only' ) {
            return;
      Severity: Major
      Found in src/PageTranslation/Hooks.php - About 2 hrs to fix

        Method backport has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function backport(
        FileBasedMessageGroup $group,
        string $source,
        string $targetPath,
        array $keyCompatibilityMap,
        Severity: Major
        Found in src/Synchronization/BackportTranslationsMaintenanceScript.php - About 2 hrs to fix

          Method makeGroupRow has 61 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function makeGroupRow(
        MessageGroup $group,
        array $cache,
        MessageGroup $parent = null,
        int $depth = 0
          Severity: Major
          Found in src/Statistics/LanguageStatsSpecialPage.php - About 2 hrs to fix

            File MessageGroupStatsSpecialPage.php has 268 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\Statistics;
            Severity: Minor
            Found in src/Statistics/MessageGroupStatsSpecialPage.php - About 2 hrs to fix

              Function validateUnitNames has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function validateUnitNames(
        TranslatablePage $page,
        array $units,
        bool $includePageDisplayTitle
    ): Status {
              Severity: Minor
              Found in src/PageTranslation/TranslatablePageMarker.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function extractMessages has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function extractMessages( array $documents ): array {
        $messages = $ret = [];

        $language = $this->params['language'];
        foreach ( $documents as $document ) {
              Severity: Minor
              Found in src/TtmServer/CrossLanguageTranslationSearchQuery.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function searchMessages has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function searchMessages( string $query, int $maxResults ): array {
        // Optimized based on requirements:
        // * "Natural" sorting of results
        // * No need to show which message group things belong to
        // * Match at any point in the message
              Severity: Minor
              Found in src/TranslatorInterface/EntitySearch.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function unflatten has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function unflatten( array $flat ): array {
        $unflat = [];

        if ( $this->parseCLDRPlurals ) {
            $unflattenedPlurals = [];
              Severity: Minor
              Found in src/MessageProcessing/ArrayFlattener.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getGroupStructure has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function getGroupStructure(): array {
        $groups = self::getAllGroups();

        // Determine the top level groups of the tree
        $tree = $groups;
              Severity: Minor
              Found in src/MessageGroupProcessing/MessageGroups.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getSubpagesPerType has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getSubpagesPerType( TranslatableBundle $bundle, bool $fetchTalkPages ): array {
        $classifiedSubPages = $this->getEmptyResultSet();

        $classifiedSubPages['translationPages'] = $bundle->getTranslationPages();
        $classifiedSubPages['translationUnitPages'] = $bundle->getTranslationUnitPages();
              Severity: Minor
              Found in src/MessageGroupProcessing/SubpageListBuilder.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function formatMessageBlock has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function formatMessageBlock(
        string $key,
        Message $message,
        array $trans,
        array $pot,
              Severity: Minor
              Found in src/FileFormatSupport/GettextFormat.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method parseGettextSection has 60 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function parseGettextSection( string $section, ?int $pluralCount ): ?array {
        if ( trim( $section ) === '' ) {
            return null;
        }
              Severity: Major
              Found in src/FileFormatSupport/GettextFormat.php - About 2 hrs to fix

                Method getIssues has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getIssues( Message $message, string $targetLanguage ): ValidationIssues {
        $issues = new ValidationIssues();

        $expectedKeywords = UnicodePlural::getPluralKeywords( $targetLanguage );
        // Skip validation for languages for which we do not know the plural rule
                Severity: Major
                Found in src/Validation/Validators/SmartFormatPluralValidator.php - About 2 hrs to fix

                  Function prepareSelectorMenu has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          prepareSelectorMenu: function () {
            this.$menu = $( '<div>' )
                .addClass( 'tux-groupselector' )
                .addClass( 'grid hide' );
                  Severity: Major
                  Found in resources/src/ext.translate.groupselector/index.js - About 2 hrs to fix

                    File MoveTranslatableBundleMaintenanceScript.php has 265 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\PageTranslation;
                    Severity: Minor
                    Found in src/PageTranslation/MoveTranslatableBundleMaintenanceScript.php - About 2 hrs to fix

                      Method handleRenameSubmit has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function handleRenameSubmit(
        MessageGroup $group,
        MessageSourceChange $sourceChanges,
        WebRequest $req,
        string $language,
                      Severity: Major
                      Found in src/Synchronization/ManageGroupsSpecialPage.php - About 2 hrs to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        } else if ( selectedTab === 'unproofread' ) {
                    $emptyListHeader.text( mw.msg( 'tux-empty-nothing-new-to-proofread' ) );
                    $guide.text( mw.msg( 'tux-empty-you-can-help-providing' ) );
                    $actions.append( messageTable.otherActionButton(
                        'tux-empty-you-can-review-already-proofread',
                        Severity: Major
                        Found in resources/js/ext.translate.messagetable.js and 1 other location - About 2 hrs to fix
                        resources/js/ext.translate.messagetable.js on lines 672..700

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 82.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        } else if ( selectedTab === 'translated' ) {
                    $emptyListHeader.text( mw.msg( 'tux-empty-list-translated' ) );
                    $guide.text( mw.msg( 'tux-empty-list-translated-guide' ) );
                    $actions.append( messageTable.otherActionButton(
                        'tux-empty-list-translated-action',
                        Severity: Major
                        Found in resources/js/ext.translate.messagetable.js and 1 other location - About 2 hrs to fix
                        resources/js/ext.translate.messagetable.js on lines 658..667

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 82.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language