Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star

Showing 1,238 of 1,238 total issues

Method formatRename has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function formatRename(
        MessageGroup $group,
        array $addedMsg,
        array $deletedMsg,
        string $language,
Severity: Major
Found in src/Synchronization/ManageGroupsSpecialPage.php - About 2 hrs to fix

    Method messageSelector has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function messageSelector(): string {
        $nonDefaults = $this->opts->getChangedValues();
        $output = Html::openElement( 'div', [ 'class' => 'row tux-messagetable-header' ] );
        $output .= Html::openElement( 'div', [ 'class' => 'twelve columns' ] );
        $output .= Html::openElement( 'ul', [ 'class' => 'row tux-message-selector' ] );
    Severity: Major
    Found in src/TtmServer/SearchTranslationsSpecialPage.php - About 2 hrs to fix

      Function switchMode has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              switchMode: function ( mode ) {
            var messageTable = this,
                filter = this.settings.filter,
                userId = mw.config.get( 'wgUserId' );
      Severity: Major
      Found in resources/js/ext.translate.messagetable.js - About 2 hrs to fix

        Method execute has 55 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function execute() {
        $handle = fopen( $this->getArg( 0 ), 'r' );
        // remove heading
        // @phan-suppress-next-line PhanPluginUseReturnValueInternalKnown
        fgets( $handle );
        Severity: Major
        Found in scripts/translator-stats-process.php - About 2 hrs to fix

          Method renderTagPage has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function renderTagPage( $wikitextParser, &$text, $state ): void {
        if ( $text === null ) {
            // SMW is unhelpfully sending null text if the source contains section tags. Do not explode.
            return;
        }
          Severity: Major
          Found in src/PageTranslation/Hooks.php - About 2 hrs to fix

            Method getData has 55 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getData(): array {
        $db = Utilities::getSafeReadDB();

        $revTagStore = Services::getInstance()->getRevTagStore();
            Severity: Major
            Found in src/TranslatorInterface/Aid/UpdatedDefinitionAid.php - About 2 hrs to fix

              Method makeUserList has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function makeUserList( array $userStats ): void {
        $day = 60 * 60 * 24;

        // Scale of the activity colors, anything
        // longer than this is just inactive
              Severity: Major
              Found in src/Statistics/ActiveLanguagesSpecialPage.php - About 2 hrs to fix

                Method getMetadata has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getMetadata(): MessageBundleMetadata {
        if ( $this->metadata !== null ) {
            return $this->metadata;
        }
                Severity: Major
                Found in src/MessageBundleTranslation/MessageBundleContent.php - About 2 hrs to fix

                  Function createMessageTools has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          createMessageTools: function () {
            var $editItem = this.createMessageToolsItem(
                'message-tools-edit',
                {
                    title: this.message.title,
                  Severity: Major
                  Found in resources/js/ext.translate.editor.js - About 2 hrs to fix

                    Method doFuzzy has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function doFuzzy(
        Title $title,
        string $message,
        string $comment,
        ?User $user
                    Severity: Major
                    Found in src/Synchronization/MessageWebImporter.php - About 2 hrs to fix

                      Method doGettextHeader has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function doGettextHeader( MessageCollection $collection, array $template ): string {
        global $wgSitename;

        $code = $collection->code;
        $name = Utilities::getLanguageName( $code );
                      Severity: Major
                      Found in src/FileFormatSupport/GettextFormat.php - About 2 hrs to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                           var r = Math.round(rgba[0]/255 * 100),
       g = Math.round(rgba[1]/255 * 100),
       b = Math.round(rgba[2]/255 * 100);
                        Severity: Major
                        Found in resources/lib/Chart.js/Chart.js and 1 other location - About 2 hrs to fix
                        resources/lib/Chart.js/Chart.js on lines 1568..1570

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 77.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function createNewLegendAndAttach(chart, legendOpts) {
    var legend = new Legend({
        ctx: chart.ctx,
        options: legendOpts,
        chart: chart
                        Severity: Major
                        Found in resources/lib/Chart.js/Chart.js and 1 other location - About 2 hrs to fix
                        resources/lib/Chart.js/Chart.js on lines 15938..15948

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 77.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function createNewTitleBlockAndAttach(chart, titleOpts) {
    var title = new Title({
        ctx: chart.ctx,
        options: titleOpts,
        chart: chart
                        Severity: Major
                        Found in resources/lib/Chart.js/Chart.js and 1 other location - About 2 hrs to fix
                        resources/lib/Chart.js/Chart.js on lines 15694..15704

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 77.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                           var r = Math.round(rgba[0]/255 * 100),
       g = Math.round(rgba[1]/255 * 100),
       b = Math.round(rgba[2]/255 * 100);
                        Severity: Major
                        Found in resources/lib/Chart.js/Chart.js and 1 other location - About 2 hrs to fix
                        resources/lib/Chart.js/Chart.js on lines 1560..1562

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 77.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            function Proofread( element, options ) {
        this.$message = $( element );
        this.options = options;
        this.message = this.options.message;
        this.init();
                        Severity: Major
                        Found in resources/js/ext.translate.proofread.js and 1 other location - About 2 hrs to fix
                        resources/js/ext.translate.pagemode.js on lines 26..32

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 77.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            function PageMode( element, options ) {
        this.$message = $( element );
        this.options = options;
        this.message = this.options.message;
        this.init();
                        Severity: Major
                        Found in resources/js/ext.translate.pagemode.js and 1 other location - About 2 hrs to fix
                        resources/js/ext.translate.proofread.js on lines 26..32

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 77.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function onSaveComplete has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public static function onSaveComplete(
        WikiPage $wikiPage,
        UserIdentity $userIdentity,
        string $summary,
        int $flags,
                        Severity: Minor
                        Found in src/TranslatorInterface/TranslateEditAddons.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function run has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function run(): bool {
        $this->logJobStart();
        $mwServices = MediaWikiServices::getInstance();
        // We may be doing double wait here if this job was spawned by TranslationUpdateJob
        $lb = $mwServices->getDBLoadBalancerFactory();
                        Severity: Minor
                        Found in src/PageTranslation/RenderTranslationPageJob.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function showRenames has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private function showRenames(
        MessageGroup $group,
        MessageSourceChange $sourceChanges,
        OutputPage $out,
        string $language,
                        Severity: Minor
                        Found in src/Synchronization/ManageGroupsSpecialPage.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language