Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
includes/ApiVisualEditor.php

Summary

Maintainability
F
4 days
Test Coverage

Function execute has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        $user = $this->getUser();
        $params = $this->extractRequestParams();
        $permissionManager = $this->getPermissionManager();
Severity: Minor
Found in includes/ApiVisualEditor.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 275 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        $user = $this->getUser();
        $params = $this->extractRequestParams();
        $permissionManager = $this->getPermissionManager();
Severity: Major
Found in includes/ApiVisualEditor.php - About 1 day to fix

    File ApiVisualEditor.php has 464 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Parsoid/RESTBase+MediaWiki API wrapper.
 *
 * @file
    Severity: Minor
    Found in includes/ApiVisualEditor.php - About 7 hrs to fix

      Method __construct has 14 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ApiMain $main,
        string $name,
        RevisionLookup $revisionLookup,
        TempUserCreator $tempUserCreator,
        UserFactory $userFactory,
      Severity: Major
      Found in includes/ApiVisualEditor.php - About 1 hr to fix

        Method getAllowedParams has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getAllowedParams() {
        return [
            'page' => [
                ParamValidator::PARAM_REQUIRED => true,
            ],
        Severity: Minor
        Found in includes/ApiVisualEditor.php - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status