Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star

Showing 2,096 of 2,096 total issues

Function dispatch has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Store.prototype.dispatch = function dispatch (_type, _payload) {
    var this$1$1 = this;

  // check object-style dispatch
  var ref = unifyObjectStyle(_type, _payload);
Severity: Major
Found in view/lib/wikibase-tainted-ref/dist/tainted-ref.common.js - About 2 hrs to fix

    Method addFilter has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function addFilter( ChangesListSpecialPage $specialPage ): void {
        $filterName = $this->getFilterName();
        $changeTypeGroup = $specialPage->getFilterGroup( 'changeType' );

        $out = $specialPage->getOutput();
    Severity: Major
    Found in client/includes/Hooks/ChangesListSpecialPageHookHandler.php - About 2 hrs to fix

      Method cleanTermInLangIdsInner has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function cleanTermInLangIdsInner( array $termInLangIds ): void {
        $this->logger->debug(
            '{method}: deleting {count} term_in_lang rows',
            [
                'method' => __METHOD__,
      Severity: Major
      Found in lib/includes/Store/Sql/Terms/DatabaseInnerTermStoreCleaner.php - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        <?php

namespace Wikibase\DataModel\Services\Lookup;

use Exception;
        Severity: Major
        Found in lib/packages/wikibase/data-model-services/src/Lookup/MaxReferencedEntityVisitsExhaustedException.php and 1 other location - About 2 hrs to fix
        lib/packages/wikibase/data-model-services/src/Lookup/MaxReferenceDepthExhaustedException.php on lines 1..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        <?php

namespace Wikibase\DataModel\Services\Lookup;

use Exception;
        Severity: Major
        Found in lib/packages/wikibase/data-model-services/src/Lookup/MaxReferenceDepthExhaustedException.php and 1 other location - About 2 hrs to fix
        lib/packages/wikibase/data-model-services/src/Lookup/MaxReferencedEntityVisitsExhaustedException.php on lines 1..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function getTermsOfEntities has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getTermsOfEntities( array $entityIds, array $termTypes, string $languageCode ): array {
        $this->termBuffer->prefetchTerms( $entityIds, $termTypes, [ $languageCode ] );

        $terms = [];
        foreach ( $entityIds as $entityId ) {
        Severity: Minor
        Found in client/includes/Api/PageTerms.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getTermsOfEntities has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getTermsOfEntities( array $entityIds, array $termTypes, string $languageCode ): array {
        $this->termBuffer->prefetchTerms( $entityIds, $termTypes, [ $languageCode ] );

        $terms = [];
        foreach ( $entityIds as $entityId ) {
        Severity: Minor
        Found in repo/includes/Api/EntityTerms.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createOrUpdate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            private function createOrUpdate(
        EntityDocument $entity,
        EditMetadata $editMetadata,
        int $newOrUpdateFlag
    ): EntityRevision {
        Severity: Minor
        Found in repo/rest-api/src/Infrastructure/DataAccess/EntityUpdater.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateQuantityUnit has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            private function updateQuantityUnit( EntityDocument $entity ) {
        $updateCounter = 0;

        if ( !$entity instanceof StatementListProvider ) {
            $this->errorReporter->reportMessage(
        Severity: Minor
        Found in repo/maintenance/EntityQuantityUnitRebuilder.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function saveEntity has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public saveEntity(
        entity: Entity,
        base?: EntityRevision,
        assertUser = true,
    ): Promise<EntityRevisionWithRedirect> {
        Severity: Major
        Found in client/data-bridge/src/data-access/ApiWritingRepository.ts - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( this.state.applicationStatus !== ApplicationStatus.READY ) {
            this.commit( 'addApplicationErrors', [ {
                type: ErrorTypes.APPLICATION_LOGIC_ERROR,
                info: { stack: ( new Error() ).stack },
            } ] );
          Severity: Major
          Found in client/data-bridge/src/store/actions.ts and 1 other location - About 2 hrs to fix
          client/data-bridge/src/store/actions.ts on lines 277..283

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( this.state.applicationStatus !== ApplicationStatus.READY ) {
            this.commit( 'addApplicationErrors', [ {
                type: ErrorTypes.APPLICATION_LOGIC_ERROR,
                info: { stack: ( new Error() ).stack },
            } ] );
          Severity: Major
          Found in client/data-bridge/src/store/actions.ts and 1 other location - About 2 hrs to fix
          client/data-bridge/src/store/actions.ts on lines 263..269

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File SpecialNewProperty.php has 252 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php

namespace Wikibase\Repo\Specials;

use MediaWiki\Output\OutputPage;
          Severity: Minor
          Found in repo/includes/Specials/SpecialNewProperty.php - About 2 hrs to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function runUseCase( string $propertyId, string $statementId ): Response {
        $requestBody = $this->getValidatedBody();
        '@phan-var array $requestBody'; // guaranteed to be an array per getBodyParamSettings()

        try {
            Severity: Major
            Found in repo/rest-api/src/RouteHandlers/PatchPropertyStatementRouteHandler.php and 2 other locations - About 2 hrs to fix
            repo/rest-api/src/RouteHandlers/ReplacePropertyStatementRouteHandler.php on lines 94..115
            repo/rest-api/src/RouteHandlers/SetPropertyDescriptionRouteHandler.php on lines 77..98

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 122.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function runUseCase( string $propertyId, string $languageCode ): Response {
        $jsonBody = $this->getValidatedBody();
        '@phan-var array $jsonBody'; // guaranteed to be an array per getBodyParamSettings()

        try {
            Severity: Major
            Found in repo/rest-api/src/RouteHandlers/SetPropertyDescriptionRouteHandler.php and 2 other locations - About 2 hrs to fix
            repo/rest-api/src/RouteHandlers/PatchPropertyStatementRouteHandler.php on lines 96..117
            repo/rest-api/src/RouteHandlers/ReplacePropertyStatementRouteHandler.php on lines 94..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 122.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function runUseCase( string $propertyId, string $statementId ): Response {
        $requestBody = $this->getValidatedBody();
        '@phan-var array $requestBody'; // guaranteed to be an array per getBodyParamSettings()

        try {
            Severity: Major
            Found in repo/rest-api/src/RouteHandlers/ReplacePropertyStatementRouteHandler.php and 2 other locations - About 2 hrs to fix
            repo/rest-api/src/RouteHandlers/PatchPropertyStatementRouteHandler.php on lines 96..117
            repo/rest-api/src/RouteHandlers/SetPropertyDescriptionRouteHandler.php on lines 77..98

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 122.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function _createListView has 51 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    _createListView: function () {
            var self = this,
                listItemAdapter = this.options.getListItemAdapter(
                    function () {
                        return self._getUnusedAllowedSiteIds().map( function ( siteId ) {
            Severity: Major
            Found in view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js - About 2 hrs to fix

              Method switchForm has 51 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function switchForm( $siteId, $page ) {
        $siteExists = $siteId
            && $this->siteLinkTargetProvider->getSiteList( $this->groups )->hasSite( $siteId );

        $this->logger->debug(
              Severity: Major
              Found in repo/includes/Specials/SpecialItemByTitle.php - About 2 hrs to fix

                Method assertValidSitelinks has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function assertValidSitelinks( string $itemId, array $originalSitelinks, array $serialization ): void {
        $validationError = $this->sitelinksValidator->validate(
            $itemId,
            $serialization,
            $this->getModifiedSitelinksSites( $originalSitelinks, $serialization )
                Severity: Major
                Found in repo/rest-api/src/Application/UseCases/PatchSitelinks/PatchedSitelinksValidator.php - About 2 hrs to fix

                  Method getEntityRevision has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getEntityRevision(
        EntityId $entityId,
        $revisionId = 0,
        $mode = LookupConstants::LATEST_FROM_REPLICA
    ) {
                  Severity: Major
                  Found in lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language