Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star

Showing 2,096 of 2,096 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if ( $formData[self::FIELD_LABEL] != '' ) {
            $validator = $this->termValidatorFactory->getLabelValidator( $this->getEntityType() );
            $result = $validator->validate( $formData[self::FIELD_LABEL] );
            $status->merge( $this->errorLocalizer->getResultStatus( $result ) );
Severity: Major
Found in repo/includes/Specials/SpecialNewItem.php and 1 other location - About 1 hr to fix
repo/includes/Specials/SpecialNewProperty.php on lines 262..270

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if ( $formData[self::FIELD_LABEL] != '' ) {
            $validator = $this->termValidatorFactory->getLabelValidator( $this->getEntityType() );
            $result = $validator->validate( $formData[self::FIELD_LABEL] );
            $status->merge( $this->errorLocalizer->getResultStatus( $result ) );
Severity: Major
Found in repo/includes/Specials/SpecialNewProperty.php and 1 other location - About 1 hr to fix
repo/includes/Specials/SpecialNewItem.php on lines 347..355

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function tipsy has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $.fn.tipsy = function(options) {

        if (options === true) {
            return this.data('tipsy');
        } else if (typeof options == 'string') {
Severity: Minor
Found in view/resources/jquery/wikibase/jquery.tipsy/jquery.tipsy.js - About 1 hr to fix

    Function tipsy has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $.fn.tipsy = function(options) {

        if (options === true) {
            return this.data('tipsy');
        } else if (typeof options == 'string') {
    Severity: Minor
    Found in client/resources/jquery.wikibase/jquery.tipsy/jquery.tipsy.js - About 1 hr to fix

      Method addStatement has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function addStatement( EntityId $entityId, Statement $statement, $isBest ) {
        $statementLName = $this->vocabulary->getStatementLName( $statement );

        $entityRepository = $this->vocabulary->getEntityRepositoryName( $entityId );
      Severity: Minor
      Found in repo/includes/Rdf/FullStatementRdfBuilder.php - About 1 hr to fix

        Method onResourceLoaderRegisterModules has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function onResourceLoaderRegisterModules( ResourceLoader $rl ): void {
        $moduleTemplate = [
            'localBasePath' => __DIR__ . '/..',
            'remoteExtPath' => 'Wikibase/view',
        ];
        Severity: Minor
        Found in view/src/ViewHooks.php - About 1 hr to fix

          Function 9bf2 has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

          /***/ (function(module, exports, __webpack_require__) {

var DESCRIPTORS = __webpack_require__("83ab");
var IE8_DOM_DEFINE = __webpack_require__("0cfb");
var anObject = __webpack_require__("825a");
          Severity: Minor
          Found in view/lib/wikibase-tainted-ref/dist/tainted-ref.common.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function showUndoForm has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              private function showUndoForm(): void {
        $this->getOutput()->enableOOUI();
        $req = $this->getRequest();

        if ( $this->showPermissionError( 'read' ) || $this->showPermissionError( 'edit' ) ) {
          Severity: Minor
          Found in repo/includes/Actions/EditEntityAction.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              public function execute( $subPage ) {
        parent::execute( $subPage );

        // Setup
        $request = $this->getRequest();
          Severity: Minor
          Found in repo/includes/Specials/SpecialItemByTitle.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function cleanTermInLangIds has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              public function cleanTermInLangIds( array $termInLangIds ) {
        $termInLangIdsAsKeys = array_flip( $termInLangIds );
        foreach ( $this->terms as $type => &$termsOfType ) {
            foreach ( $termsOfType as $lang => &$termsOfLang ) {
                foreach ( $termsOfLang as $term => $id ) {
          Severity: Minor
          Found in lib/includes/Store/Sql/Terms/InMemoryTermStore.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              private function mergeSearchResults( array $searchResults, array $newSearchResults, $limit ) {
        $searchResultEntityIdSerializations = array_keys( $searchResults );

        foreach ( $newSearchResults as $searchResultToAdd ) {
            $entityIdString = $searchResultToAdd->getEntityId()->getSerialization();
          Severity: Major
          Found in repo/includes/Api/CombinedEntitySearchHelper.php and 1 other location - About 1 hr to fix
          repo/includes/Api/EntityTermSearchHelper.php on lines 88..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              private function mergeSearchResults( array $searchResults, array $newSearchResults, $limit ) {
        $searchResultEntityIdSerializations = array_keys( $searchResults );

        foreach ( $newSearchResults as $searchResultToAdd ) {
            $entityIdString = $searchResultToAdd->getEntityId()->getSerialization();
          Severity: Major
          Found in repo/includes/Api/EntityTermSearchHelper.php and 1 other location - About 1 hr to fix
          repo/includes/Api/CombinedEntitySearchHelper.php on lines 69..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              private function groupTermsByPageAndType( array $entityToPageMap, array $terms ): array {
        $termsPerPage = [];

        foreach ( $terms as $term ) {
            // Since we construct $terms and $entityToPageMap from the same set of page IDs,
          Severity: Major
          Found in client/includes/Api/PageTerms.php and 1 other location - About 1 hr to fix
          repo/includes/Api/EntityTerms.php on lines 187..208

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              private function groupTermsByPageAndType( array $entityToPageMap, array $terms ): array {
        $termsPerPage = [];

        foreach ( $terms as $term ) {
            // Since we construct $terms and $entityToPageMap from the same set of page IDs,
          Severity: Major
          Found in repo/includes/Api/EntityTerms.php and 1 other location - About 1 hr to fix
          client/includes/Api/PageTerms.php on lines 189..210

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function fetchResults has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function fetchResults( q, batchSize, offset = null ) {
        const api = new mw.Api();
        const data = {
            action: 'wbsearchentities',
            search: q,
          Severity: Minor
          Found in repo/resources/wikibase.vector.searchClient.js - About 1 hr to fix

            Method prepareChangeAttributes has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function prepareChangeAttributes( EntityChange $change ) {
        $rcinfo = $change->getMetadata();

        $fields = $change->getFields();
        $fields['entity_type'] = $change->getEntityId()->getEntityType();
            Severity: Minor
            Found in client/includes/RecentChanges/RecentChangeFactory.php - About 1 hr to fix

              Method getForm has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function getForm( EntityDocument $entity = null ) {
        if ( $this->isEditFormStep( $entity ) ) {

            $languageName = $this->languageNameUtils->getLanguageName(
                $this->languageCode, $this->getLanguage()->getCode()
              Severity: Minor
              Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 1 hr to fix

                Method executeInternal has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function executeInternal(): void {
        $this->getMain()->setCacheMode( 'public' );

        $params = $this->extractRequestParams();
                Severity: Minor
                Found in repo/includes/Api/SearchEntities.php - About 1 hr to fix

                  Method run has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function run( $new, IContextSource $context, string $summary ) {
        $filterStatus = Status::newGood();

        if ( !$this->hookContainer->isRegistered( 'EditFilterMergedContent' ) ) {
            return $filterStatus;
                  Severity: Minor
                  Found in repo/includes/EditEntity/MediaWikiEditFilterHookRunner.php - About 1 hr to fix

                    Function SELF has 15 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                                toolbarFactory,
            entityChangersFactory,
            structureEditorFactory,
            contentLanguages,
            dataTypeStore,
                    Severity: Major
                    Found in view/resources/wikibase/view/ControllerViewFactory.js - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language