wikimedia/mediawiki-extensions-Wikibase

View on GitHub

Showing 2,096 of 2,096 total issues

Method __construct has 15 arguments (exceeds 4 allowed). Consider refactoring.
Open

        EntityTitleStoreLookup $titleLookup,
        EntityRevisionLookup $entityLookup,
        EntityStore $entityStore,
        EntityPermissionChecker $permissionChecker,
        EntityDiffer $entityDiffer,
Severity: Major
Found in repo/includes/EditEntity/MediaWikiEditEntity.php - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private function newSuccessResponse( GetPropertyLabelWithFallbackResponse $useCaseResponse ): Response {
            $httpResponse = $this->getResponseFactory()->create();
            $httpResponse->setHeader( 'Content-Type', 'application/json' );
            $httpResponse->setHeader( 'Last-Modified', wfTimestamp( TS_RFC2822, $useCaseResponse->getLastModified() ) );
            $httpResponse->setHeader( 'ETag', "\"{$useCaseResponse->getRevisionId()}\"" );
    repo/rest-api/src/RouteHandlers/GetPropertyLabelRouteHandler.php on lines 92..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private function newSuccessResponse( GetPropertyLabelResponse $useCaseResponse ): Response {
            $httpResponse = $this->getResponseFactory()->create();
            $httpResponse->setHeader( 'Content-Type', 'application/json' );
            $httpResponse->setHeader( 'Last-Modified', wfTimestamp( TS_RFC2822, $useCaseResponse->getLastModified() ) );
            $httpResponse->setHeader( 'ETag', "\"{$useCaseResponse->getRevisionId()}\"" );
    repo/rest-api/src/RouteHandlers/GetPropertyLabelWithFallbackRouteHandler.php on lines 94..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function __construct(
            SiteLinkLookup $siteLinkLookup,
            EntityIdLookup $entityIdLookup,
            SettingsArray $settings,
            UsageAccumulator $usageAccumulator,
    repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php on lines 135..163

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function __construct(
            EntityExistenceChecker $entityExistenceChecker,
            EntityIdParser $entityIdParser,
            TermLookup $termLookup,
            EntityNamespaceLookup $localEntityNamespaceLookup,
    Severity: Major
    Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php and 1 other location - About 1 hr to fix
    client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php on lines 105..133

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _create: function () {
                var self = this;
    
                PARENT.prototype._create.call( this );
    
    
    Severity: Minor
    Found in client/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js - About 1 hr to fix

      Function _createWidgets has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _createWidgets: function () {
                  var self = this;
      
                  [ 'label', 'description', 'aliases' ].forEach( function ( subjectName ) {
                      var widgetName = subjectName + 'view';

        Function _create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                _create: function () {
                    var self = this;
        
                    $.ui.suggester.prototype._create.apply( this, arguments );
        
        
        Severity: Minor
        Found in view/resources/jquery/wikibase/jquery.wikibase.siteselector.js - About 1 hr to fix

          Function wbTemplate has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              mw.wbTemplate = function ( key, parameter1 /* [, parameter2[, ...]] */ ) {
                  var i,
                      params = [],
                      template,
                      $wrappedTemplate,
          Severity: Minor
          Found in view/resources/wikibase/templates.js - About 1 hr to fix

            Function _create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    _create: function () {
                        var self = this;
            
                        PARENT.prototype._create.call( this );
            
            
            Severity: Minor
            Found in view/resources/jquery/wikibase/jquery.wikibase.wbtooltip.js - About 1 hr to fix

              Function _create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      _create: function () {
                          var self = this;
              
                          $.ui.suggester.prototype._create.apply( this, arguments );
              
              
              Severity: Minor
              Found in client/resources/jquery.wikibase/jquery.wikibase.siteselector.js - About 1 hr to fix

                Method rebuildPropertyInfo has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function rebuildPropertyInfo(): int {
                        $propertyNamespace = $this->entityNamespaceLookup->getEntityNamespace(
                            Property::ENTITY_TYPE
                        );
                        if ( $propertyNamespace === null ) {
                Severity: Minor
                Found in repo/includes/Store/Sql/PropertyInfoTableBuilder.php - About 1 hr to fix

                  Method saveRedirect has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function saveRedirect(
                          EntityRedirect $redirect,
                          FormatableSummary $summary,
                          IContextSource $context,
                          bool $bot,
                  Severity: Minor
                  Found in repo/includes/Interactors/EntityRedirectCreationInteractor.php - About 1 hr to fix

                    Method getChangeOps has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function getChangeOps( Fingerprint $fingerprint ) {
                            $changeOpFactory = $this->changeOpFactory;
                            $changeOps = [];
                    
                            if ( $this->label !== '' ) {
                    Severity: Minor
                    Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 1 hr to fix

                      Function save has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              save: function ( newSiteLinkSet, oldSiteLinkSet ) {
                                  function getRemovedSiteLinkIds() {
                                      var currentSiteIds = newSiteLinkSet.getKeys();
                                      var removedSiteLinkIds = [];
                      
                      
                      Severity: Minor
                      Found in view/resources/wikibase/entityChangers/SiteLinkSetsChanger.js - About 1 hr to fix

                        Method showData has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function showData( WebRequest $request, OutputPage $output, $format, EntityId $id, $revision ) {
                                $flavor = $request->getRawVal( 'flavor' );
                        
                                /** @var EntityRevision $entityRevision */
                                /** @var RedirectRevision $followedRedirectRevision */
                        Severity: Minor
                        Found in repo/includes/LinkedData/EntityDataRequestHandler.php - About 1 hr to fix

                          Method acquireTermInLangIdsInner has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private function acquireTermInLangIdsInner(
                                  array $typeTextInLangIds,
                                  ReplicaPrimaryAwareRecordIdsAcquirer $termInLangIdsAcquirer,
                                  array $idsToRestore = []
                              ) {
                          Severity: Minor
                          Found in lib/includes/Store/Sql/Terms/DatabaseTermInLangIdsAcquirer.php - About 1 hr to fix

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    _getSuggestions: function ( term ) {
                                        var source = typeof this.options.source === 'function'
                                            ? this.options.source()
                                            : this.options.source;
                            
                            
                            view/resources/jquery/wikibase/jquery.wikibase.siteselector.js on lines 200..206

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 71.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Function mergeParams has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                private mergeParams<action1 extends ApiAction, action2 extends ApiAction>(
                                    params1: ApiParams<action1>,
                                    params2: ApiParams<action2>,
                                ): ApiParams<action1&action2>|false {
                                    const paramNames = new Set( [
                            Severity: Minor
                            Found in client/data-bridge/src/data-access/BatchingApi.ts - About 1 hr to fix

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      _getSuggestions: function ( term ) {
                                          var source = typeof this.options.source === 'function'
                                              ? this.options.source()
                                              : this.options.source;
                              
                              
                              client/resources/jquery.wikibase/jquery.wikibase.siteselector.js on lines 203..209

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 71.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language