Showing 2,096 of 2,096 total issues
Method __construct
has 15 arguments (exceeds 4 allowed). Consider refactoring. Open
EntityTitleStoreLookup $titleLookup,
EntityRevisionLookup $entityLookup,
EntityStore $entityStore,
EntityPermissionChecker $permissionChecker,
EntityDiffer $entityDiffer,
Identical blocks of code found in 2 locations. Consider refactoring. Open
private function newSuccessResponse( GetPropertyLabelWithFallbackResponse $useCaseResponse ): Response {
$httpResponse = $this->getResponseFactory()->create();
$httpResponse->setHeader( 'Content-Type', 'application/json' );
$httpResponse->setHeader( 'Last-Modified', wfTimestamp( TS_RFC2822, $useCaseResponse->getLastModified() ) );
$httpResponse->setHeader( 'ETag', "\"{$useCaseResponse->getRevisionId()}\"" );
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 118.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
private function newSuccessResponse( GetPropertyLabelResponse $useCaseResponse ): Response {
$httpResponse = $this->getResponseFactory()->create();
$httpResponse->setHeader( 'Content-Type', 'application/json' );
$httpResponse->setHeader( 'Last-Modified', wfTimestamp( TS_RFC2822, $useCaseResponse->getLastModified() ) );
$httpResponse->setHeader( 'ETag', "\"{$useCaseResponse->getRevisionId()}\"" );
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 118.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function __construct(
SiteLinkLookup $siteLinkLookup,
EntityIdLookup $entityIdLookup,
SettingsArray $settings,
UsageAccumulator $usageAccumulator,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 118.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function __construct(
EntityExistenceChecker $entityExistenceChecker,
EntityIdParser $entityIdParser,
TermLookup $termLookup,
EntityNamespaceLookup $localEntityNamespaceLookup,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 118.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function _create
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
_create: function () {
var self = this;
PARENT.prototype._create.call( this );
Function _createWidgets
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
_createWidgets: function () {
var self = this;
[ 'label', 'description', 'aliases' ].forEach( function ( subjectName ) {
var widgetName = subjectName + 'view';
Function _create
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
_create: function () {
var self = this;
$.ui.suggester.prototype._create.apply( this, arguments );
Function wbTemplate
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
mw.wbTemplate = function ( key, parameter1 /* [, parameter2[, ...]] */ ) {
var i,
params = [],
template,
$wrappedTemplate,
Function _create
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
_create: function () {
var self = this;
PARENT.prototype._create.call( this );
Function _create
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
_create: function () {
var self = this;
$.ui.suggester.prototype._create.apply( this, arguments );
Method rebuildPropertyInfo
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function rebuildPropertyInfo(): int {
$propertyNamespace = $this->entityNamespaceLookup->getEntityNamespace(
Property::ENTITY_TYPE
);
if ( $propertyNamespace === null ) {
Method saveRedirect
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function saveRedirect(
EntityRedirect $redirect,
FormatableSummary $summary,
IContextSource $context,
bool $bot,
Method getChangeOps
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function getChangeOps( Fingerprint $fingerprint ) {
$changeOpFactory = $this->changeOpFactory;
$changeOps = [];
if ( $this->label !== '' ) {
Function save
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
save: function ( newSiteLinkSet, oldSiteLinkSet ) {
function getRemovedSiteLinkIds() {
var currentSiteIds = newSiteLinkSet.getKeys();
var removedSiteLinkIds = [];
Method showData
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function showData( WebRequest $request, OutputPage $output, $format, EntityId $id, $revision ) {
$flavor = $request->getRawVal( 'flavor' );
/** @var EntityRevision $entityRevision */
/** @var RedirectRevision $followedRedirectRevision */
Method acquireTermInLangIdsInner
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function acquireTermInLangIdsInner(
array $typeTextInLangIds,
ReplicaPrimaryAwareRecordIdsAcquirer $termInLangIdsAcquirer,
array $idsToRestore = []
) {
Identical blocks of code found in 2 locations. Consider refactoring. Open
_getSuggestions: function ( term ) {
var source = typeof this.options.source === 'function'
? this.options.source()
: this.options.source;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 71.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function mergeParams
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
private mergeParams<action1 extends ApiAction, action2 extends ApiAction>(
params1: ApiParams<action1>,
params2: ApiParams<action2>,
): ApiParams<action1&action2>|false {
const paramNames = new Set( [
Identical blocks of code found in 2 locations. Consider refactoring. Open
_getSuggestions: function ( term ) {
var source = typeof this.options.source === 'function'
? this.options.source()
: this.options.source;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 71.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76