Showing 2,096 of 2,096 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
this.element
.addClass( this.widgetFullName )
.on( 'mouseover.' + this.widgetName, function ( event ) {
if ( !self.option( 'disabled' ) && self.isInEditMode() ) {
self.element.addClass( 'ui-state-hover' );
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 60.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function _create
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
_create: function () {
var self = this,
$dialogSpinner = $.createSpinner();
this.element
Function attachWatchLinkUpdater
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
function attachWatchLinkUpdater( $entityview, viewName ) {
var update;
if ( mw.loader.getState( 'mediawiki.page.watch.ajax' ) !== 'ready' || !mw.user.options.get( 'watchdefault' ) ) {
return;
Function setSiteLink
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
setSiteLink: function ( siteLink, tempUserWatcher ) {
var self = this,
deferred = $.Deferred();
this._api.setSitelink(
Function focus
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
focus: function () {
// Focus first invalid/incomplete item or - if there is none - the first item.
var listview = this.$listview.data( 'listview' ),
lia = listview.listItemAdapter(),
$items = listview.items();
Method formatResult
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function formatResult(
IResultWrapper $res,
int $limit,
array $prop,
?ApiPageSet $resultPageSet
Method purgeWebCache
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function purgeWebCache(
array $titles,
array $rootJobParams,
$causeAction,
$causeAgent
Method formatEntityUsage
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function formatEntityUsage( array $usages, IContextSource $context ): string {
$usageAspectsByEntity = [];
$entityIds = [];
foreach ( $usages as $entityUsage ) {
Method getOrCreatePingbackId
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function getOrCreatePingbackId() {
if ( !$this->id ) {
$dbr = $this->repoConnections->getReadConnection();
$id = $dbr->newSelectQueryBuilder()
Method generateDumpForEntityId
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function generateDumpForEntityId( EntityId $entityId ): ?string {
try {
$entityRevision = $this->entityRevisionLookup->getEntityRevision( $entityId );
if ( !$entityRevision ) {
Method getRankedSearchResults
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getRankedSearchResults(
$text,
$languageCode,
$entityType,
$limit,
Method getResultHtml
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getResultHtml( TermSearchResult $searchResult ): string {
$idHtml = $this->getIdHtml( $searchResult->getEntityId() );
$displayLabel = $searchResult->getDisplayLabel();
$displayDescription = $searchResult->getDisplayDescription();
Method equals
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function equals( Content $that = null ) {
if ( $that === $this ) {
return true;
}
Method throwUseCaseError
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function throwUseCaseError( ValidationError $validationError ): void {
$context = $validationError->getContext();
switch ( $validationError->getCode() ) {
case LanguageCodeValidator::CODE_INVALID_LANGUAGE_CODE:
throw UseCaseError::newPatchResultInvalidKey( '', $context[LanguageCodeValidator::CONTEXT_LANGUAGE_CODE] );
Method execute
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function execute( PatchItemRequest $request ): PatchItemResponse {
$deserializedRequest = $this->validator->validateAndDeserialize( $request );
$providedMetadata = $deserializedRequest->getEditMetadata();
$itemId = $deserializedRequest->getItemId();
Method validate
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function validate( array $serialization, string $basePath = '' ): ?ValidationError {
$expectedFields = [ 'labels', 'descriptions', 'aliases', 'sitelinks', 'statements' ];
foreach ( $expectedFields as $expectedField ) {
$serialization[$expectedField] ??= [];
if ( !is_array( $serialization[$expectedField] ) ) {
Method getAmountAndPrecisionHtml
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function getAmountAndPrecisionHtml( $precision, $amount = 1 ) {
if ( $amount === 0 ) {
// TODO: Use NumberLocalizer
return '0';
}
Method getHtml
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getHtml( TermFallback $term ) {
$requestedLanguage = $term->getLanguageCode();
$actualLanguage = $term->getActualLanguageCode();
$sourceLanguage = $term->getSourceLanguageCode();
Method computeSiteDetails
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function computeSiteDetails( MediaWikiSite $site, array $specialGroups, MessageLocalizer $localizer ): array {
$languageNameLookup = $this->languageNameLookupFactory->getForAutonyms();
// FIXME: quickfix to allow a custom site-name / handling for the site groups which are
// special according to the specialSiteLinkGroups setting
Method movePropertyGroup
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function movePropertyGroup( PropertyId $propertyId, $toIndex ) {
if ( $this->getPropertyGroupIndex( $propertyId ) === $toIndex ) {
return;
}