wikimedia/mediawiki-extensions-Wikibase

View on GitHub

Showing 2,096 of 2,096 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            this.element
            .addClass( this.widgetFullName )
            .on( 'mouseover.' + this.widgetName, function ( event ) {
                if ( !self.option( 'disabled' ) && self.isInEditMode() ) {
                    self.element.addClass( 'ui-state-hover' );
view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js on lines 109..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _create has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        _create: function () {
            var self = this,
                $dialogSpinner = $.createSpinner();

            this.element
Severity: Minor
Found in client/resources/jquery.wikibase/jquery.wikibase.linkitem.js - About 1 hr to fix

    Function attachWatchLinkUpdater has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function attachWatchLinkUpdater( $entityview, viewName ) {
            var update;
    
            if ( mw.loader.getState( 'mediawiki.page.watch.ajax' ) !== 'ready' || !mw.user.options.get( 'watchdefault' ) ) {
                return;
    Severity: Minor
    Found in repo/resources/wikibase.ui.entityViewInit.js - About 1 hr to fix

      Function setSiteLink has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              setSiteLink: function ( siteLink, tempUserWatcher ) {
                  var self = this,
                      deferred = $.Deferred();
      
                  this._api.setSitelink(
      Severity: Minor
      Found in view/resources/wikibase/entityChangers/SiteLinksChanger.js - About 1 hr to fix

        Function focus has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                focus: function () {
                    // Focus first invalid/incomplete item or - if there is none - the first item.
                    var listview = this.$listview.data( 'listview' ),
                        lia = listview.listItemAdapter(),
                        $items = listview.items();
        Severity: Minor
        Found in view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js - About 1 hr to fix

          Method formatResult has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function formatResult(
                  IResultWrapper $res,
                  int $limit,
                  array $prop,
                  ?ApiPageSet $resultPageSet
          Severity: Minor
          Found in client/includes/Api/ApiListEntityUsage.php - About 1 hr to fix

            Method purgeWebCache has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function purgeWebCache(
                    array $titles,
                    array $rootJobParams,
                    $causeAction,
                    $causeAgent
            Severity: Minor
            Found in client/includes/Changes/WikiPageUpdater.php - About 1 hr to fix

              Method formatEntityUsage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function formatEntityUsage( array $usages, IContextSource $context ): string {
                      $usageAspectsByEntity = [];
                      $entityIds = [];
              
                      foreach ( $usages as $entityUsage ) {
              Severity: Minor
              Found in client/includes/Hooks/EditActionHookHandler.php - About 1 hr to fix

                Method getOrCreatePingbackId has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function getOrCreatePingbackId() {
                        if ( !$this->id ) {
                            $dbr = $this->repoConnections->getReadConnection();
                
                            $id = $dbr->newSelectQueryBuilder()
                Severity: Minor
                Found in repo/includes/WikibasePingback.php - About 1 hr to fix

                  Method generateDumpForEntityId has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function generateDumpForEntityId( EntityId $entityId ): ?string {
                          try {
                              $entityRevision = $this->entityRevisionLookup->getEntityRevision( $entityId );
                  
                              if ( !$entityRevision ) {
                  Severity: Minor
                  Found in repo/includes/Dumpers/RdfDumpGenerator.php - About 1 hr to fix

                    Method getRankedSearchResults has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getRankedSearchResults(
                            $text,
                            $languageCode,
                            $entityType,
                            $limit,
                    Severity: Minor
                    Found in repo/includes/Api/ConceptUriSearchHelper.php - About 1 hr to fix

                      Method getResultHtml has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function getResultHtml( TermSearchResult $searchResult ): string {
                              $idHtml = $this->getIdHtml( $searchResult->getEntityId() );
                      
                              $displayLabel = $searchResult->getDisplayLabel();
                              $displayDescription = $searchResult->getDisplayDescription();
                      Severity: Minor
                      Found in repo/includes/ItemDisambiguation.php - About 1 hr to fix

                        Method equals has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function equals( Content $that = null ) {
                                if ( $that === $this ) {
                                    return true;
                                }
                        
                        
                        Severity: Minor
                        Found in repo/includes/Content/EntityContent.php - About 1 hr to fix

                          Method throwUseCaseError has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private function throwUseCaseError( ValidationError $validationError ): void {
                                  $context = $validationError->getContext();
                                  switch ( $validationError->getCode() ) {
                                      case LanguageCodeValidator::CODE_INVALID_LANGUAGE_CODE:
                                          throw UseCaseError::newPatchResultInvalidKey( '', $context[LanguageCodeValidator::CONTEXT_LANGUAGE_CODE] );

                            Method execute has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function execute( PatchItemRequest $request ): PatchItemResponse {
                                    $deserializedRequest = $this->validator->validateAndDeserialize( $request );
                                    $providedMetadata = $deserializedRequest->getEditMetadata();
                                    $itemId = $deserializedRequest->getItemId();
                            
                            
                            Severity: Minor
                            Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchItem.php - About 1 hr to fix

                              Method validate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function validate( array $serialization, string $basePath = '' ): ?ValidationError {
                                      $expectedFields = [ 'labels', 'descriptions', 'aliases', 'sitelinks', 'statements' ];
                                      foreach ( $expectedFields as $expectedField ) {
                                          $serialization[$expectedField] ??= [];
                                          if ( !is_array( $serialization[$expectedField] ) ) {
                              Severity: Minor
                              Found in repo/rest-api/src/Application/Validation/ItemValidator.php - About 1 hr to fix

                                Method getAmountAndPrecisionHtml has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    private function getAmountAndPrecisionHtml( $precision, $amount = 1 ) {
                                        if ( $amount === 0 ) {
                                            // TODO: Use NumberLocalizer
                                            return '0';
                                        }
                                Severity: Minor
                                Found in lib/includes/Formatters/TimeDetailsFormatter.php - About 1 hr to fix

                                  Method getHtml has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      public function getHtml( TermFallback $term ) {
                                          $requestedLanguage = $term->getLanguageCode();
                                          $actualLanguage = $term->getActualLanguageCode();
                                          $sourceLanguage = $term->getSourceLanguageCode();
                                  
                                  
                                  Severity: Minor
                                  Found in lib/includes/LanguageFallbackIndicator.php - About 1 hr to fix

                                    Method computeSiteDetails has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        public function computeSiteDetails( MediaWikiSite $site, array $specialGroups, MessageLocalizer $localizer ): array {
                                            $languageNameLookup = $this->languageNameLookupFactory->getForAutonyms();
                                    
                                            // FIXME: quickfix to allow a custom site-name / handling for the site groups which are
                                            // special according to the specialSiteLinkGroups setting
                                    Severity: Minor
                                    Found in lib/includes/Modules/SitesModuleBase.php - About 1 hr to fix

                                      Method movePropertyGroup has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                          private function movePropertyGroup( PropertyId $propertyId, $toIndex ) {
                                              if ( $this->getPropertyGroupIndex( $propertyId ) === $toIndex ) {
                                                  return;
                                              }
                                      
                                      
                                      Severity: Minor
                                      Found in lib/packages/wikibase/data-model/src/ByPropertyIdArray.php - About 1 hr to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language