wikimedia/pywikibot

View on GitHub

Showing 708 of 708 total issues

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    def test_log(self):
        pywikibot.log('log')
        self.assertEqual(self.strout.getvalue(), '')
        self.assertEqual(self.strerr.getvalue(), '')
Severity: Major
Found in tests/ui_tests.py and 6 other locations - About 1 hr to fix
tests/ui_tests.py on lines 122..125
tests/ui_tests.py on lines 127..130
tests/ui_tests.py on lines 132..135
tests/ui_tests.py on lines 137..140
tests/ui_tests.py on lines 147..150
tests/ui_tests.py on lines 318..321

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    def test_error(self):
        pywikibot.error('error')
        self.assertEqual(self.strout.getvalue(), '')
        self.assertEqual(self.strerr.getvalue(), 'ERROR: error\n')
Severity: Major
Found in tests/ui_tests.py and 6 other locations - About 1 hr to fix
tests/ui_tests.py on lines 122..125
tests/ui_tests.py on lines 127..130
tests/ui_tests.py on lines 132..135
tests/ui_tests.py on lines 142..145
tests/ui_tests.py on lines 147..150
tests/ui_tests.py on lines 318..321

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    def test_stdout(self):
        pywikibot.stdout('output')
        self.assertEqual(self.strout.getvalue(), 'output\n')
        self.assertEqual(self.strerr.getvalue(), '')
Severity: Major
Found in tests/ui_tests.py and 6 other locations - About 1 hr to fix
tests/ui_tests.py on lines 122..125
tests/ui_tests.py on lines 132..135
tests/ui_tests.py on lines 137..140
tests/ui_tests.py on lines 142..145
tests/ui_tests.py on lines 147..150
tests/ui_tests.py on lines 318..321

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    def test_critical(self):
        pywikibot.critical('critical')
        self.assertEqual(self.strout.getvalue(), '')
        self.assertEqual(self.strerr.getvalue(), 'CRITICAL: critical\n')
Severity: Major
Found in tests/ui_tests.py and 6 other locations - About 1 hr to fix
tests/ui_tests.py on lines 122..125
tests/ui_tests.py on lines 127..130
tests/ui_tests.py on lines 132..135
tests/ui_tests.py on lines 137..140
tests/ui_tests.py on lines 142..145
tests/ui_tests.py on lines 318..321

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    def test_output(self):
        pywikibot.info('output')
        self.assertEqual(self.strout.getvalue(), '')
        self.assertEqual(self.strerr.getvalue(), 'output\n')
Severity: Major
Found in tests/ui_tests.py and 6 other locations - About 1 hr to fix
tests/ui_tests.py on lines 127..130
tests/ui_tests.py on lines 132..135
tests/ui_tests.py on lines 137..140
tests/ui_tests.py on lines 142..145
tests/ui_tests.py on lines 147..150
tests/ui_tests.py on lines 318..321

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    def testOutputUnicodeText(self):
        pywikibot.info('Заглавная_страница')
        self.assertEqual(self.strout.getvalue(), '')
        self.assertEqual(self.strerr.getvalue(), 'Заглавная_страница\n')
Severity: Major
Found in tests/ui_tests.py and 6 other locations - About 1 hr to fix
tests/ui_tests.py on lines 122..125
tests/ui_tests.py on lines 127..130
tests/ui_tests.py on lines 132..135
tests/ui_tests.py on lines 137..140
tests/ui_tests.py on lines 142..145
tests/ui_tests.py on lines 147..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    def test_warning(self):
        pywikibot.warning('warning')
        self.assertEqual(self.strout.getvalue(), '')
        self.assertEqual(self.strerr.getvalue(), 'WARNING: warning\n')
Severity: Major
Found in tests/ui_tests.py and 6 other locations - About 1 hr to fix
tests/ui_tests.py on lines 122..125
tests/ui_tests.py on lines 127..130
tests/ui_tests.py on lines 137..140
tests/ui_tests.py on lines 142..145
tests/ui_tests.py on lines 147..150
tests/ui_tests.py on lines 318..321

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function test_RegexFilterPageGenerator has 32 lines of code (exceeds 30 allowed). Consider refactoring.
Open

    def test_RegexFilterPageGenerator(self):
        """Test RegexFilterPageGenerator."""
        self.assertFunction('RegexFilterPageGenerator')
        gen = pagegenerators.PagesFromTitlesGenerator(self.titles, self.site)
        gen = pagegenerators.RegexFilterPageGenerator(gen, '/doc')
Severity: Minor
Found in tests/pagegenerators_tests.py - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

                    if (removing and not self.conf.autonomous
                        or modifying and self.problemfound
                        or not old
                        or (self.conf.needlimit
                            and len(adding) + len(modifying)
    Severity: Major
    Found in scripts/interwiki.py - About 1 hr to fix

      Function save has 11 arguments (exceeds 7 allowed). Consider refactoring.
      Open

          def save(self,
      Severity: Major
      Found in pywikibot/page/_basepage.py - About 1 hr to fix

        Function put has 11 arguments (exceeds 7 allowed). Consider refactoring.
        Open

            def put(self, newtext: str,
        Severity: Major
        Found in pywikibot/page/_basepage.py - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

                          if replaceit and trailing_chars:
                              newlink = f'[[{new_page_title}{section}]]{trailing_chars}'
                          elif replaceit or (new_page_title == link_text
                                             and not section):
                              newlink = f'[[{new_page_title}]]'
          Severity: Major
          Found in scripts/solve_disambiguation.py - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                        if force_interwiki \
                           or (allow_interwiki
                               and (self.site.family.name != target_family
                                    or self.site.code != target_code)):
                            if self.site.family.name not in (
            Severity: Major
            Found in pywikibot/page/_basepage.py - About 1 hr to fix

              Function editpage has 11 arguments (exceeds 7 allowed). Consider refactoring.
              Open

                  def editpage(
              Severity: Major
              Found in pywikibot/site/_apisite.py - About 1 hr to fix

                Function __init__ has 11 arguments (exceeds 7 allowed). Consider refactoring.
                Open

                    def __init__(self, lat: float, lon: float, alt: float | None = None,
                Severity: Major
                Found in pywikibot/_wbtypes.py - About 1 hr to fix

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  @deprecated_args(text='msg')  # since 7.2
                  def error(msg: Any, *args: Any, **kwargs: Any) -> None:
                      """Output an error message to the user with level :const:`ERROR`.
                  
                      ``msg`` will be sent to stderr via :mod:`pywikibot.userinterfaces`.
                  Severity: Major
                  Found in pywikibot/logging.py and 4 other locations - About 1 hr to fix
                  pywikibot/logging.py on lines 229..242
                  pywikibot/logging.py on lines 263..275
                  pywikibot/logging.py on lines 279..293
                  pywikibot/logging.py on lines 297..309

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      def test_standard_version_sites(self):
                          """Test detection of standard MediaWiki sites."""
                          for url in self.standard_version_sites:
                              with self.subTest(url=urlparse(url).netloc):
                                  self.assertSite(url)
                  Severity: Major
                  Found in tests/site_detect_tests.py and 3 other locations - About 1 hr to fix
                  tests/site_detect_tests.py on lines 124..128
                  tests/site_detect_tests.py on lines 130..134
                  tests/site_detect_tests.py on lines 136..140

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      def _handle_url(self, value: str) -> HANDLER_GEN_TYPE:
                          """Handle `-url` argument."""
                          if not value:
                              value = pywikibot.input('Please enter the URL:')
                          return TextIOPageGenerator(value, site=self.site)
                  Severity: Major
                  Found in pywikibot/pagegenerators/_factory.py and 3 other locations - About 1 hr to fix
                  pywikibot/pagegenerators/_factory.py on lines 628..632
                  pywikibot/pagegenerators/_factory.py on lines 899..903
                  pywikibot/pagegenerators/_factory.py on lines 905..909

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      def test_with_h4_and_h2_sections(self):
                          """Test for text having h4 and h2 sections."""
                          text = ('text\n\n'
                                  '====title====\n'
                                  '==title 2==\n'
                  Severity: Major
                  Found in tests/textlib_tests.py and 3 other locations - About 1 hr to fix
                  tests/textlib_tests.py on lines 1594..1605
                  tests/textlib_tests.py on lines 1621..1636
                  tests/textlib_tests.py on lines 1666..1676

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      def test_non_standard_version_sites(self):
                          """Test detection of non standard MediaWiki sites."""
                          for url in self.non_standard_version_sites:
                              with self.subTest(url=urlparse(url).netloc):
                                  self.assertSite(url)
                  Severity: Major
                  Found in tests/site_detect_tests.py and 3 other locations - About 1 hr to fix
                  tests/site_detect_tests.py on lines 112..116
                  tests/site_detect_tests.py on lines 130..134
                  tests/site_detect_tests.py on lines 136..140

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language