wikimedia/pywikibot

View on GitHub
scripts/add_text.py

Summary

Maintainability
A
1 hr
Test Coverage

Function parse has a Cognitive Complexity of 14 (exceeds 10 allowed). Consider refactoring.
Open

def parse(argv: Sequence[str],
          generator_factory: pagegenerators.GeneratorFactory
          ) -> dict[str, bool | str]:
    """
    Parses our arguments and provide a dictionary with their values.
Severity: Minor
Found in scripts/add_text.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return super().skip_page(page)
Severity: Major
Found in scripts/add_text.py - About 30 mins to fix

    Function skip_page has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        def skip_page(self, page):
            """Skip if -exceptUrl matches or page does not exists."""
            if page.exists():
                if self.opt.createonly:
                    pywikibot.warning(f'Skipping because {page} already exists')
    Severity: Minor
    Found in scripts/add_text.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status