wikimedia/pywikibot

View on GitHub
scripts/blockpageschecker.py

Summary

Maintainability
D
2 days
Test Coverage

Function remove_templates has a Cognitive Complexity of 124 (exceeds 10 allowed). Consider refactoring.
Open

    def remove_templates(self):
        """Understand if the page is blocked has the right template."""

        def understand_block():
            """Understand if the page is blocked has the right template."""
Severity: Minor
Found in scripts/blockpageschecker.py - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if tu:
                            # no changes needed, better to revert the old text.
                            text = oldtext
                    else:
Severity: Major
Found in scripts/blockpageschecker.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if tu:
                                # no changes needed, better to revert the old text.
                                text = oldtext
                        else:
    Severity: Major
    Found in scripts/blockpageschecker.py - About 45 mins to fix

      Function main has a Cognitive Complexity of 13 (exceeds 10 allowed). Consider refactoring.
      Open

      def main(*args: str) -> None:
          """
          Process command line arguments and perform task.
      
          If args is an empty list, sys.argv is used.
      Severity: Minor
      Found in scripts/blockpageschecker.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      FIXME found
      Open

              # FIXME: This check does not work :
      Severity: Minor
      Found in scripts/blockpageschecker.py by fixme

      There are no issues that match your filters.

      Category
      Status