wikimedia/pywikibot

View on GitHub
scripts/fixing_redirects.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function replace_links has a Cognitive Complexity of 33 (exceeds 10 allowed). Consider refactoring.
Open

    def replace_links(self, text, linked_page, target_page):
        """Replace all source links by target."""
        mysite = pywikibot.Site()
        linktrail = mysite.linktrail()

Severity: Minor
Found in scripts/fixing_redirects.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

            if new_page_title == link_text and not section \
               or self.opt.overwrite:
                newlink = f'[[{new_page_title}]]'
            # check if we can create a link with trailing characters instead of
            # a pipelink
Severity: Major
Found in scripts/fixing_redirects.py - About 40 mins to fix

    Function get_target has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        def get_target(self, page):
            """Get the target page for a given page."""
            target = None
            if not page.exists():
                if not self.opt.ignoremoves:
    Severity: Minor
    Found in scripts/fixing_redirects.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status