wikimedia/pywikibot

View on GitHub
tests/textlib_tests.py

Summary

Maintainability
D
2 days
Test Coverage

File textlib_tests.py has 1408 lines of code (exceeds 900 allowed). Consider refactoring.
Open

#!/usr/bin/env python3
"""Test textlib module."""
#
# (C) Pywikibot team, 2011-2024
#
Severity: Major
Found in tests/textlib_tests.py - About 1 day to fix

    TODO found
    Open

        @unittest.expectedFailure  # TODO: T133276
    Severity: Minor
    Found in tests/textlib_tests.py by fixme

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def test_with_comments(self):
            """Test section headers surrounded by comments."""
            text = ('text\n\n'
                    '<!--\n multiline comment\n-->== title ==\n'
                    'content\n\n'
    Severity: Major
    Found in tests/textlib_tests.py and 3 other locations - About 1 hr to fix
    tests/textlib_tests.py on lines 1594..1605
    tests/textlib_tests.py on lines 1608..1618
    tests/textlib_tests.py on lines 1666..1676

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def test_with_h4_and_h2_sections(self):
            """Test for text having h4 and h2 sections."""
            text = ('text\n\n'
                    '====title====\n'
                    '==title 2==\n'
    Severity: Major
    Found in tests/textlib_tests.py and 3 other locations - About 1 hr to fix
    tests/textlib_tests.py on lines 1594..1605
    tests/textlib_tests.py on lines 1621..1636
    tests/textlib_tests.py on lines 1666..1676

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def test_with_h1_and_h2_sections(self):
            """Test for text having h1 and h2 sections."""
            text = ('text\n\n'
                    '=first level=\n'
                    'foo\n'
    Severity: Major
    Found in tests/textlib_tests.py and 3 other locations - About 1 hr to fix
    tests/textlib_tests.py on lines 1608..1618
    tests/textlib_tests.py on lines 1621..1636
    tests/textlib_tests.py on lines 1666..1676

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def test_unbalanced_headers(self):
            """Test unbalanced section headers."""
            text = ('text\n\n'
                    '====title===\n'
                    '==title 2===\n'
    Severity: Major
    Found in tests/textlib_tests.py and 3 other locations - About 1 hr to fix
    tests/textlib_tests.py on lines 1594..1605
    tests/textlib_tests.py on lines 1608..1618
    tests/textlib_tests.py on lines 1621..1636

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status