Sign upLogin

wisedog/ladybug

View on GitHub
Star

Showing 112 of 112 total issues

struct field IdByToolInt should be IDByToolInt
Open

    IdByToolInt    int
Severity: Minor
Found in models/build.go by golint

don't use underscores in Go names; struct field Project_id should be ProjectID
Open

    Project_id  int
Severity: Minor
Found in models/build.go by golint

don't use ALL_CAPS in Go names; use CamelCase
Open

    HISTORY_TYPE_TC = 1 + iota
Severity: Minor
Found in models/history.go by golint

struct field ProjectId should be ProjectID
Open

    ProjectId   int    //Project id which belongs to this issue
Severity: Minor
Found in models/issue.go by golint

exported type JSTreeNode should have comment or be unexported
Open

type JSTreeNode struct {
Severity: Minor
Found in models/wrapper.go by golint

exported method ConnectionTest returns unexported type *buildtools.travisRepo, which can be annoying to use
Open

func (t Travis) ConnectionTest(url string) (*travisRepo, string, error) {
Severity: Minor
Found in controllers/buildtools/travis.go by golint

don't use underscores in Go names; type user_project should be userProject
Open

    type user_project struct {
Severity: Minor
Found in controllers/hello.go by golint

struct field ChangesJson should be ChangesJSON
Open

    ChangesJson string `sql:"size:1000"`
Severity: Minor
Found in models/history.go by golint

exported const ProjectFlashKey should have comment (or a comment on this block) or be unexported
Open

    ProjectFlashKey = "LADYBUG_PROJECT"
Severity: Minor
Found in controllers/projects.go by golint

exported function HandleError should have comment or be unexported
Open

func HandleError(w http.ResponseWriter, r *http.Request, err error) {
Severity: Minor
Found in errors/errorhandler.go by golint

exported const CookieKey should have comment (or a comment on this block) or be unexported
Open

    CookieKey = "ladybug"
Severity: Minor
Found in main.go by golint

exported method BuildItem.Validate should have comment or be unexported
Open

func (builditem *BuildItem) Validate() map[string]string {
Severity: Minor
Found in models/build.go by golint

exported const ReviewStatusReady should have comment (or a comment on this block) or be unexported
Open

    ReviewStatusReady = 1 + iota
Severity: Minor
Found in models/review.go by golint

struct field BuildUrl should be BuildURL
Open

    BuildUrl    string // build url
Severity: Minor
Found in models/build.go by golint

if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
Open

    } else {
Severity: Minor
Found in controllers/sections.go by golint

struct field Id should be ID
Open

    Id       string                  `json:"id"`
Severity: Minor
Found in models/wrapper.go by golint

2: cannot find package "github.com/gorilla/sessions" in any of:
Open

    "github.com/gorilla/sessions"
Severity: Minor
Found in controllers/app.go by govet

error strings should not be capitalized or end with punctuation or a newline
Open

        return errors.New("Wrong database handler!")
Severity: Minor
Found in controllers/buildtools/jenkins.go by golint

if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
Open

        } else {
Severity: Minor
Found in controllers/requirements.go by golint

type HttpError should be HTTPError
Open

type HttpError struct {
Severity: Minor
Found in errors/errorhandler.go by golint
Severity
Category
Status
Source
Language