workcraft/workcraft

View on GitHub
workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java

Summary

Maintainability
C
1 day
Test Coverage

Method testVerificationCommands has 14 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private void testVerificationCommands(String workName, Boolean combined,
            Boolean consistency, Boolean deadlockFreeness,
            Boolean inputProperness, Boolean outputPersistency, Boolean outputDeterminacy,
            Boolean csc, Boolean usc,
            Boolean localSelfTriggering, Boolean diInterface, Boolean normalcy,

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        @Test
        void testBadVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(), "bad.stg.work");
            testVerificationCommands(workName,
                    false, // combined
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 76..94
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 196..216
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 218..236
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 238..256
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 258..276

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        @Test
        void testInoutPulseVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(), "inout_pulse.stg.work");
            testVerificationCommands(workName,
                    false, // combined
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 76..94
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 116..134
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 196..216
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 218..236
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 258..276

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        @Test
        void testDlatchVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(), "dlatch.stg.work");
            testVerificationCommands(workName,
                    false, // combined
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 76..94
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 116..134
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 196..216
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 238..256
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 258..276

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        @Test
        void testToggleSignalVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(),
                    "toggle_signals-no_input_properness-no_output_determinacy.stg.work");
    
    
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 76..94
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 116..134
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 218..236
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 238..256
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 258..276

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        @Test
        void testVmeVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(), "vme.stg.work");
            testVerificationCommands(workName,
                    true,  // combined
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 116..134
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 196..216
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 218..236
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 238..256
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 258..276

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        @Test
        void testPulserSelfTriggerExceptionsVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(), "pulser-self_trigger_exceptions.stg.work");
            testVerificationCommands(workName,
                    true, // combined
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 76..94
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 116..134
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 196..216
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 218..236
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 238..256

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
        void testPhilosophersDeadlockVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(), "philosophers-deadlock.pn.work");
            testVerificationCommands(workName,
                    null,  // combined
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 56..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
        void testCycleMutexVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(), "cycle-mutex.stg.work");
            testVerificationCommands(workName,
                    true, // combined
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 96..114

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
        void testPhilosophersNoDeadlockVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(), "philosophers-no_deadlock.pn.work");
            testVerificationCommands(workName,
                    null,  // combined
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 36..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
        void testArbitrationVerification() throws DeserialisationException {
            String workName = PackageUtils.getPackagePath(getClass(), "arbitration-3.stg.work");
            testVerificationCommands(workName,
                    false,  // combined
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/VerificationCommandTests.java on lines 156..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        @BeforeAll
        static void init() {
            final Framework framework = Framework.getInstance();
            framework.init();
            PcompSettings.setCommand(BackendUtils.getTemplateToolPath("UnfoldingTools", "pcomp"));
    workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/ReachAssertionVerificationCommandTests.java on lines 26..32
    workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/SignalAssertionVerificationCommandTests.java on lines 26..32
    workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/VerificationCommandTests.java on lines 26..32
    workcraft/MpsatTemporalPlugin/test-src/org/workcraft/plugins/mpsat_temporal/SpotAssertionVerificationCommandTests.java on lines 24..30
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/ConformationVerificationCommandTests.java on lines 26..32
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/ConsistencyVerificationCommandTests.java on lines 25..31
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/NwayConformationVerificationCommandTests.java on lines 25..31
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/PlaceRedundancyVerificationCommandTest.java on lines 25..31
    workcraft/MpsatVerificationPlugin/test-src/org/workcraft/plugins/mpsat_verification/RefinementVerificationCommandTests.java on lines 27..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status