wp-bootstrap/wp-bootstrap-navwalker

View on GitHub
class-wp-bootstrap-navwalker.php

Summary

Maintainability
D
2 days
Test Coverage

Function start_el has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

        public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
            if ( isset( $args->item_spacing ) && 'discard' === $args->item_spacing ) {
                $t = '';
                $n = '';
            } else {
Severity: Minor
Found in class-wp-bootstrap-navwalker.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start_el has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
            if ( isset( $args->item_spacing ) && 'discard' === $args->item_spacing ) {
                $t = '';
                $n = '';
            } else {
Severity: Major
Found in class-wp-bootstrap-navwalker.php - About 4 hrs to fix

    The class WP_Bootstrap_Navwalker has an overall complexity of 92 which is very high. The configured complexity threshold is 50.
    Open

        class WP_Bootstrap_Navwalker extends Walker_Nav_Menu {
    
            /**
             * Whether the items_wrap contains schema microdata or not.
             *
    Severity: Minor
    Found in class-wp-bootstrap-navwalker.php by phpmd

    Function update_atts_for_linkmod_type has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

            private function update_atts_for_linkmod_type( $atts = array(), $linkmod_classes = array() ) {
                if ( ! empty( $linkmod_classes ) ) {
                    foreach ( $linkmod_classes as $link_class ) {
                        if ( ! empty( $link_class ) ) {
                            /*
    Severity: Minor
    Found in class-wp-bootstrap-navwalker.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File class-wp-bootstrap-navwalker.php has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * WP Bootstrap Navwalker
     *
     * @package WP-Bootstrap-Navwalker
    Severity: Minor
    Found in class-wp-bootstrap-navwalker.php - About 2 hrs to fix

      Function get_linkmod_type has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

              private function get_linkmod_type( $linkmod_classes = array() ) {
                  $linkmod_type = '';
                  // Loop through array of linkmod classes to handle their $atts.
                  if ( ! empty( $linkmod_classes ) ) {
                      foreach ( $linkmod_classes as $link_class ) {
      Severity: Minor
      Found in class-wp-bootstrap-navwalker.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fallback has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

              public static function fallback( $args ) {
                  if ( ! current_user_can( 'edit_theme_options' ) ) {
                      return;
                  }
      
      
      Severity: Minor
      Found in class-wp-bootstrap-navwalker.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method fallback has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public static function fallback( $args ) {
                  if ( ! current_user_can( 'edit_theme_options' ) ) {
                      return;
                  }
      
      
      Severity: Minor
      Found in class-wp-bootstrap-navwalker.php - About 1 hr to fix

        Function separate_linkmods_and_icons_from_classes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                private function separate_linkmods_and_icons_from_classes( $classes, &$linkmod_classes, &$icon_classes, $depth ) {
                    // Loop through $classes array to find linkmod or icon classes.
                    foreach ( $classes as $key => $class ) {
                        /*
                         * If any special classes are found, store the class in it's
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method start_el has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php - About 35 mins to fix

          Function start_lvl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                  public function start_lvl( &$output, $depth = 0, $args = null ) {
                      if ( isset( $args->item_spacing ) && 'discard' === $args->item_spacing ) {
                          $t = '';
                          $n = '';
                      } else {
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function flatten has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                  public function flatten( $array ) {
                      $result = array();
                      foreach ( $array as $element ) {
                          if ( is_array( $element ) ) {
                              array_push( $result, ...$this->flatten( $element ) );
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method start_el() has an NPath complexity of 212336640. The configured NPath complexity threshold is 200.
          Open

                  public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
                      if ( isset( $args->item_spacing ) && 'discard' === $args->item_spacing ) {
                          $t = '';
                          $n = '';
                      } else {
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method start_el() has 212 lines of code. Current threshold is set to 100. Avoid really long methods.
          Open

                  public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
                      if ( isset( $args->item_spacing ) && 'discard' === $args->item_spacing ) {
                          $t = '';
                          $n = '';
                      } else {
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          The method fallback() has an NPath complexity of 336. The configured NPath complexity threshold is 200.
          Open

                  public static function fallback( $args ) {
                      if ( ! current_user_can( 'edit_theme_options' ) ) {
                          return;
                      }
          
          
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method start_el() has a Cyclomatic Complexity of 34. The configured cyclomatic complexity threshold is 10.
          Open

                  public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
                      if ( isset( $args->item_spacing ) && 'discard' === $args->item_spacing ) {
                          $t = '';
                          $n = '';
                      } else {
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The method fallback() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
          Open

                  public static function fallback( $args ) {
                      if ( ! current_user_can( 'edit_theme_options' ) ) {
                          return;
                      }
          
          
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Avoid unused local variables such as '$n'.
          Open

                          $n = '';
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

                              $id               = $args['container_id'] ? ' id="' . esc_attr( $args['container_id'] ) . '"' : '';
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $n. Configured minimum length is 3.
          Open

                          $n = '';
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $n. Configured minimum length is 3.
          Open

                          $n = '';
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $t. Configured minimum length is 3.
          Open

                          $t = '';
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $t. Configured minimum length is 3.
          Open

                          $t = '';
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

                  public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          The class WP_Bootstrap_Navwalker is not named in CamelCase.
          Open

              class WP_Bootstrap_Navwalker extends Walker_Nav_Menu {
          
                  /**
                   * Whether the items_wrap contains schema microdata or not.
                   *
          Severity: Minor
          Found in class-wp-bootstrap-navwalker.php by phpmd

          CamelCaseClassName

          Since: 0.2

          It is considered best practice to use the CamelCase notation to name classes.

          Example

          class class_name {
          }

          Source

          Equals sign not aligned correctly; expected 1 space but found 9 spaces
          Open

                      $classes         = $this->flatten( array_map( $split_on_spaces, $classes ) );

          Inline comments must end in full-stops, exclamation marks, or question marks
          Open

                          // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped

          All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$fallback_output'.
          Open

                          echo $fallback_output;

          There are no issues that match your filters.

          Category
          Status