wp-graphql/wp-graphql

View on GitHub

Showing 819 of 825 total issues

Method register_type has 570 lines of code (exceeds 40 allowed). Consider refactoring.
Open

    public static function register_type() {
        register_graphql_object_type(
            'RootQuery',
            [
                'description' => __( 'The root entry point into the Graph', 'wp-graphql' ),
Severity: Major
Found in src/Type/ObjectType/RootQuery.php - About 2 days to fix

Function parse_request has a Cognitive Complexity of 118 (exceeds 5 allowed). Consider refactoring.
Open

    public function parse_request( string $uri, $extra_query_vars = '' ) {
        // Attempt to parse the provided URI.
        $parsed_url = wp_parse_url( $uri );

        if ( false === $parsed_url ) {
Severity: Minor
Found in src/Data/NodeResolver.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            $input_fields = [
                'password'    => [
                    'type'        => 'String',
                    'description' => __( 'A string that contains the plain text password for the user.', 'wp-graphql' ),
                ],
Severity: Major
Found in src/Data/UserMutation.php and 1 other location - About 2 days to fix
src/Mutation/UserCreate.php on lines 49..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 425.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        return [
            'password'    => [
                'type'        => 'String',
                'description' => __( 'A string that contains the plain text password for the user.', 'wp-graphql' ),
            ],
Severity: Major
Found in src/Mutation/UserCreate.php and 1 other location - About 2 days to fix
src/Data/UserMutation.php on lines 31..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 425.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File RootQuery.php has 848 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace WPGraphQL\Type\ObjectType;

use GraphQL\Error\UserError;
Severity: Major
Found in src/Type/ObjectType/RootQuery.php - About 2 days to fix

Function AbstractArgView has a Cognitive Complexity of 98 (exceeds 5 allowed). Consider refactoring.
Open

const AbstractArgView = (props) => {
  const [displayArgActions, setDisplayArgActions] = useState(true);
  const { definition } = props;

  const { argValue, arg, styleConfig } = props;
Severity: Minor
Found in packages/graphiql-query-composer/components/AbstractArgView.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function FieldView has 392 lines of code (exceeds 40 allowed). Consider refactoring.
Open

const FieldView = (props) => {
  const [displayFieldActions, setDisplayFieldActions] = useState(false);

  let _previousSelection;

Severity: Major
Found in packages/graphiql-query-composer/components/FieldView.js - About 1 day to fix

File TypeRegistry.php has 791 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace WPGraphQL\Registry;

use GraphQL\Error\Error;
Severity: Major
Found in src/Registry/TypeRegistry.php - About 1 day to fix

Method init has 382 lines of code (exceeds 40 allowed). Consider refactoring.
Open

    protected function init() {
        if ( empty( $this->fields ) ) {
            $this->fields = [
                'ID'                        => function () {
                    return $this->data->ID;
Severity: Major
Found in src/Model/Post.php - About 1 day to fix

Function AbstractArgView has 376 lines of code (exceeds 40 allowed). Consider refactoring.
Open

const AbstractArgView = (props) => {
  const [displayArgActions, setDisplayArgActions] = useState(true);
  const { definition } = props;

  const { argValue, arg, styleConfig } = props;
Severity: Major
Found in packages/graphiql-query-composer/components/AbstractArgView.js - About 1 day to fix

Function set_object_terms has a Cognitive Complexity of 89 (exceeds 5 allowed). Consider refactoring.
Open

    protected static function set_object_terms( int $post_id, array $input, WP_Post_Type $post_type_object, string $mutation_name ) {

        /**
         * Fire an action before setting object terms during a GraphQL Post Object Mutation.
         *
Severity: Minor
Found in src/Data/PostObjectMutation.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has a Cognitive Complexity of 88 (exceeds 5 allowed). Consider refactoring.
Open

    protected function init() {
        if ( empty( $this->fields ) ) {
            $this->fields = [
                'ID'                        => function () {
                    return $this->data->ID;
Severity: Minor
Found in src/Model/Post.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function QueryBuilder has 362 lines of code (exceeds 40 allowed). Consider refactoring.
Open

const QueryBuilder = (props) => {
  const [newOperationType, setNewOperationType] = useState("query");
  const [operation, setOperation] = useState(null);
  const [operationToScrollTo, setOperationToScrollTo] = useState(null);

Severity: Major
Found in packages/graphiql-query-composer/components/QueryBuilder.js - About 1 day to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const getDefaultFieldNames = (type) => {
  const fields = type.getFields();

  // Is there an `id` field?
  if (fields["id"]) {
Severity: Major
Found in packages/graphiql-query-composer/utils/utils.js and 1 other location - About 1 day to fix
packages/graphiql-query-composer/utils/utils.js on lines 58..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 259.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const defaultGetDefaultFieldNames = (type) => {
  const fields = type.getFields();

  // Is there an `id` field?
  if (fields["id"]) {
Severity: Major
Found in packages/graphiql-query-composer/utils/utils.js and 1 other location - About 1 day to fix
packages/graphiql-query-composer/utils/utils.js on lines 246..287

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 259.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File Post.php has 558 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Model - PostObject
 *
 * @package WPGraphQL\Model
Severity: Major
Found in src/Model/Post.php - About 1 day to fix

Method init_type_registry has 248 lines of code (exceeds 40 allowed). Consider refactoring.
Open

    public function init_type_registry( self $type_registry ) {

        /**
         * Fire an action as the type registry is initialized. This executes
         * before the `graphql_register_types` action to allow for earlier hooking
Severity: Major
Found in src/Registry/TypeRegistry.php - About 1 day to fix

AbstractConnectionResolver has 63 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractConnectionResolver {
    /**
     * The source from the field calling the connection.
     *
     * @var \WPGraphQL\Model\Model|mixed[]|mixed
Severity: Major
Found in src/Data/Connection/AbstractConnectionResolver.php - About 1 day to fix

Function RootView has 244 lines of code (exceeds 40 allowed). Consider refactoring.
Open

const RootView = (props) => {
  let _previousOperationDef;

  const { index } = props;

Severity: Major
Found in packages/graphiql-query-composer/components/RootView.js - About 1 day to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  for (const field of fields) {
    if (
      isRequiredInputField(field) ||
      (makeDefaultArg && makeDefaultArg(parentField, field))
    ) {
Severity: Major
Found in packages/graphiql-query-composer/utils/utils.js and 1 other location - About 1 day to fix
packages/graphiql-query-composer/utils/utils.js on lines 415..444

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 212.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language