Sign upLogin

xmidt-org/themis

View on GitHub
Star

Showing 39 of 39 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    case *rsa.PrivateKey:
        verifyPEM, err := MarshalPKIXPublicKeyToPEM(&k.PublicKey)
        if err != nil {
            return nil, err
        }
Severity: Major
Found in key/pair.go and 1 other location - About 1 hr to fix
key/pair.go on lines 91..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    case *ecdsa.PrivateKey:
        verifyPEM, err := MarshalPKIXPublicKeyToPEM(&k.PublicKey)
        if err != nil {
            return nil, err
        }
Severity: Major
Found in key/pair.go and 1 other location - About 1 hr to fix
key/pair.go on lines 69..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function NewTlsConfig has 6 return statements (exceeds 4 allowed).
Open

func NewTlsConfig(t *Tls, extra ...PeerVerifier) (*tls.Config, error) {
    if t == nil {
        return nil, nil
    }
Severity: Major
Found in xhttp/xhttpserver/tls.go - About 40 mins to fix

    Function CheckServerRequirements has 6 return statements (exceeds 4 allowed).
    Open

    func CheckServerRequirements(k KeyRoutesIn, i IssuerRoutesIn, c ClaimsRoutesIn) error {
    if k.Router != nil && i.Router != nil {
        // all good ... no need to check anything else
        return nil
    }
    Severity: Major
    Found in routes.go - About 40 mins to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func ProvideSummaryVec(o prometheus.SummaryOpts, labelNames ...string) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f Factory) (*prometheus.SummaryVec, error) {
            return f.NewSummaryVec(o, labelNames)
      Severity: Major
      Found in xmetrics/provide.go and 3 other locations - About 35 mins to fix
      xmetrics/provide.go on lines 22..29
      xmetrics/provide.go on lines 44..51
      xmetrics/provide.go on lines 66..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func ProvideHistogramVec(o prometheus.HistogramOpts, labelNames ...string) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f Factory) (*prometheus.HistogramVec, error) {
            return f.NewHistogramVec(o, labelNames)
      Severity: Major
      Found in xmetrics/provide.go and 3 other locations - About 35 mins to fix
      xmetrics/provide.go on lines 22..29
      xmetrics/provide.go on lines 44..51
      xmetrics/provide.go on lines 88..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func ProvideCounterVec(o prometheus.CounterOpts, labelNames ...string) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f Factory) (*prometheus.CounterVec, error) {
            return f.NewCounterVec(o, labelNames)
      Severity: Major
      Found in xmetrics/provide.go and 3 other locations - About 35 mins to fix
      xmetrics/provide.go on lines 44..51
      xmetrics/provide.go on lines 66..73
      xmetrics/provide.go on lines 88..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func ProvideGaugeVec(o prometheus.GaugeOpts, labelNames ...string) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f Factory) (*prometheus.GaugeVec, error) {
            return f.NewGaugeVec(o, labelNames)
      Severity: Major
      Found in xmetrics/provide.go and 3 other locations - About 35 mins to fix
      xmetrics/provide.go on lines 22..29
      xmetrics/provide.go on lines 66..73
      xmetrics/provide.go on lines 88..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method Unmarshal.Provide has 5 return statements (exceeds 4 allowed).
      Open

      func (u Unmarshal) Provide(in ServerIn) (*mux.Router, error) {
    if !in.Unmarshaller.IsSet(u.Key) {
        if !u.Optional {
            return nil, ServerNotConfiguredError{Key: u.Key}
        }
      Severity: Major
      Found in xhttp/xhttpserver/unmarshal.go - About 35 mins to fix

        Function NewClaimBuilders has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func NewClaimBuilders(n random.Noncer, client xhttpclient.Interface, o Options) (ClaimBuilders, error) {
    var (
        // at a minimum, the claims from the request will be copied
        builders           = ClaimBuilders{requestClaimBuilder{}}
        staticClaimBuilder = make(staticClaimBuilder)
        Severity: Minor
        Found in token/claimBuilder.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for name, value := range o.Metadata {
            if len(value.Header) != 0 || len(value.Parameter) != 0 || len(value.Variable) != 0 {
                continue
            }
        Severity: Minor
        Found in token/claimBuilder.go and 1 other location - About 35 mins to fix
        token/claimBuilder.go on lines 211..222

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for name, value := range o.Claims {
        if len(value.Header) != 0 || len(value.Parameter) != 0 || len(value.Variable) != 0 {
            // skip any claims derived from HTTP requests
            continue
        }
        Severity: Minor
        Found in token/claimBuilder.go and 1 other location - About 35 mins to fix
        token/claimBuilder.go on lines 191..201

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

        func ProvideGauge(o prometheus.GaugeOpts, labelNames ...string) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f Factory) (metrics.Gauge, error) {
            return f.NewGauge(o, labelNames)
        Severity: Major
        Found in xmetrics/provide.go and 3 other locations - About 35 mins to fix
        xmetrics/provide.go on lines 11..18
        xmetrics/provide.go on lines 55..62
        xmetrics/provide.go on lines 77..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

        func ProvideSummary(o prometheus.SummaryOpts, labelNames ...string) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f Factory) (metrics.Histogram, error) {
            return f.NewSummary(o, labelNames)
        Severity: Major
        Found in xmetrics/provide.go and 3 other locations - About 35 mins to fix
        xmetrics/provide.go on lines 11..18
        xmetrics/provide.go on lines 33..40
        xmetrics/provide.go on lines 55..62

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

        func ProvideHistogram(o prometheus.HistogramOpts, labelNames ...string) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f Factory) (metrics.Histogram, error) {
            return f.NewHistogram(o, labelNames)
        Severity: Major
        Found in xmetrics/provide.go and 3 other locations - About 35 mins to fix
        xmetrics/provide.go on lines 11..18
        xmetrics/provide.go on lines 33..40
        xmetrics/provide.go on lines 77..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

        func ProvideCounter(o prometheus.CounterOpts, labelNames ...string) fx.Annotated {
    return fx.Annotated{
        Name: o.Name,
        Target: func(f Factory) (metrics.Counter, error) {
            return f.NewCounter(o, labelNames)
        Severity: Major
        Found in xmetrics/provide.go and 3 other locations - About 35 mins to fix
        xmetrics/provide.go on lines 33..40
        xmetrics/provide.go on lines 55..62
        xmetrics/provide.go on lines 77..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func NewClientLabellers(labellers ...ClientLabeller) *ClientLabellers {
    cl := &ClientLabellers{
        labelNames: make([]string, len(labellers)), // just an optimization step
        labellers:  append([]ClientLabeller{}, labellers...),
    }
        Severity: Minor
        Found in xmetrics/xmetricshttp/labeller.go and 1 other location - About 35 mins to fix
        xmetrics/xmetricshttp/labeller.go on lines 48..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func NewServerLabellers(labellers ...ServerLabeller) *ServerLabellers {
    sl := &ServerLabellers{
        labelNames: make([]string, len(labellers)), // just an optimization step
        labellers:  append([]ServerLabeller{}, labellers...),
    }
        Severity: Minor
        Found in xmetrics/xmetricshttp/labeller.go and 1 other location - About 35 mins to fix
        xmetrics/xmetricshttp/labeller.go on lines 96..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function NewPair has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func NewPair(kid string, key interface{}) (Pair, error) {
    switch k := key.(type) {
    case *rsa.PrivateKey:
        verifyPEM, err := MarshalPKIXPublicKeyToPEM(&k.PublicKey)
        if err != nil {
        Severity: Minor
        Found in key/pair.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language