Sign upLogin

xoopscube/altsys

View on GitHub
Star

Showing 242 of 242 total issues

Method render has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function render() {
        $ret = '';

        if ( count( $this->_appendix ) > 0 ) {
            $ret  .= '<table class="outer"><tr>';
Severity: Minor
Found in xoops_trust_path/libs/altsys/include/mygrouppermform.php - About 1 hr to fix

    Function issue has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

            public function issue(string $salt = '', int $timeout = 1800, string $area = '' ) {
            global $xoopsModule;

            if ( '' === $salt ) {
                if ( version_compare( PHP_VERSION, '7.0.0' ) >= 0 && function_exists( 'random_bytes' ) ) {
    Severity: Minor
    Found in xoops_trust_path/libs/altsys/include/gtickets.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_view_edit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get_view_edit()
    {
        $id = $this->init_default_values();

        $lines = [];
    Severity: Minor
    Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        while ( list( $tpl_id ) = $db->fetchRow( $drs ) ) {
        $db->queryF( 'UPDATE ' . $db->prefix( 'tplfile' ) . " SET tpl_lastmodified='" . addslashes( $lastmodified ) . "',tpl_lastimported=UNIX_TIMESTAMP() WHERE tpl_id='$tpl_id'" );

        $db->queryF( 'UPDATE ' . $db->prefix( 'tplsource' ) . " SET tpl_source='" . addslashes( $tpl_source ) . "' WHERE tpl_id='$tpl_id'" );
    Severity: Major
    Found in xoops_trust_path/libs/altsys/include/tpls_functions.php and 1 other location - About 1 hr to fix
    xoops_trust_path/libs/altsys/include/tpls_functions.php on lines 217..225

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                while ( list( $tpl_id ) = $db->fetchRow( $drs ) ) {
                // UPDATE mode

                $db->query( 'UPDATE ' . $db->prefix( 'tplfile' ) . " SET tpl_lastmodified='" . addslashes( $lastmodified ) . "' WHERE tpl_id='$tpl_id'" );
    Severity: Major
    Found in xoops_trust_path/libs/altsys/include/tpls_functions.php and 1 other location - About 1 hr to fix
    xoops_trust_path/libs/altsys/include/tpls_functions.php on lines 74..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method _tool_PathInclusion has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public function _tool_PathInclusion($p_dir, $p_path)
  {
      $v_result = 1;

    // ----- Explode dir and path by directory separator
    Severity: Minor
    Found in xoops_trust_path/libs/altsys/include/Archive_Zip.php - About 1 hr to fix

      Method tplsadmin_copy_templates_f2db has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function tplsadmin_copy_templates_f2db( $tplset_to, $whr_append = '1' ) {
    global $db;

    // get tplsource
    //$result = $db->query('SELECT * FROM ' . $db->prefix('tplfile') . "  WHERE tpl_tplset='default' AND ($whr_append)") ;
      Severity: Minor
      Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

        Method tplsadmin_import_data has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function tplsadmin_import_data( $tplset, $tpl_file, $tpl_source, $lastmodified = 0 ) {

    $db =& XoopsDatabaseFactory::getDatabaseConnection();

    // check the file is valid template
        Severity: Minor
        Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (is_array($p_filelist)) {
            $v_result = $this->_create($p_filelist, $p_result_list, $p_params);
        }

        // ----- Look if the $p_filelist is a string
          Severity: Major
          Found in xoops_trust_path/libs/altsys/include/Archive_Zip.php and 1 other location - About 1 hr to fix
          xoops_trust_path/libs/altsys/include/Archive_Zip.php on lines 280..300

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (is_array($p_filelist)) {
            // ----- Call the create fct
            $v_result = $this->_add($p_filelist, $p_result_list, $p_params);
        }
          Severity: Major
          Found in xoops_trust_path/libs/altsys/include/Archive_Zip.php and 1 other location - About 1 hr to fix
          xoops_trust_path/libs/altsys/include/Archive_Zip.php on lines 204..221

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function _merge has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            public function _merge(&$p_archive_to_add)
  {
      $v_result=1;

    // ----- Look if the archive_to_add exists
          Severity: Minor
          Found in xoops_trust_path/libs/altsys/include/Archive_Zip.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function render has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function render() {
        $ret = '';

        if ( count( $this->_appendix ) > 0 ) {
            $ret  .= '<table class="outer"><tr>';
          Severity: Minor
          Found in xoops_trust_path/libs/altsys/include/mygrouppermform.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _tool_CopyBlock has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            public function _tool_CopyBlock($p_src, $p_dest, $p_size, $p_mode=0)
  {
      $v_result = 1;

      if (0 == $p_mode) {
          Severity: Minor
          Found in xoops_trust_path/libs/altsys/include/Archive_Zip.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function render has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function render() {
        global $xoopsGTicket;

        // load all child ids for javascript codes
        foreach ( array_keys( $this->_itemTree ) as $item_id ) {
          Severity: Minor
          Found in xoops_trust_path/libs/altsys/include/mygrouppermform.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _readCentralFileHeader has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            public function _readCentralFileHeader(&$p_header)
  {
      $v_result=1;

    // ----- Read the 4 bytes signature
          Severity: Minor
          Found in xoops_trust_path/libs/altsys/include/Archive_Zip.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function form_edit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function form_edit( $bid, $mode = 'edit' ) {
        $bid = (int) $bid;

        //HACK by domifara
        if ( defined( 'XOOPS_CUBE_LEGACY' ) ) {
          Severity: Minor
          Found in xoops_trust_path/libs/altsys/class/MyBlocksAdmin.class.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getDelegateCallbackClassNames has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function getDelegateCallbackClassNames($name, bool $doRegist = true)
    {
        $names = [];

        if (!class_exists('XCube_Delegate')) {
          Severity: Minor
          Found in xoops_trust_path/libs/altsys/class/altsysUtils.class.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _tool_CopyBlock has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public function _tool_CopyBlock($p_src, $p_dest, $p_size, $p_mode=0)
  {
      $v_result = 1;

      if (0 == $p_mode) {
          Severity: Minor
          Found in xoops_trust_path/libs/altsys/include/Archive_Zip.php - About 1 hr to fix

            Method get_view_edit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function get_view_edit()
    {
        $id = $this->init_default_values();

        $lines = [];
            Severity: Minor
            Found in xoops_trust_path/libs/altsys/class/d3utilities.php - About 1 hr to fix

              Method init has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function init( $xoopsModule ) {
        // altsys "module" MODE

        if ( 'altsys' == $xoopsModule->getVar( 'dirname' ) ) {
            // set target_module if specified by $_GET['dirname']
              Severity: Minor
              Found in xoops_trust_path/libs/altsys/class/MyBlocksAdmin.class.php - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language