Sign upLogin

xoopscube/altsys

View on GitHub
Star
xoops_trust_path/libs/altsys/include/tpls_functions.php

Summary

Maintainability
C
1 day
Test Coverage

Function tplsadmin_get_basefilepath has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function tplsadmin_get_basefilepath( $dirname, $type, $tpl_file ) {
    // module instance

    $path = $basefilepath = XOOPS_ROOT_PATH . '/modules/' . $dirname . '/templates/' . ( 'block' == $type ? 'blocks/' : '' ) . $tpl_file;
Severity: Minor
Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tplsadmin_copy_templates_db2db has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function tplsadmin_copy_templates_db2db( $tplset_from, $tplset_to, $whr_append = '1' ) {
    global $db;

    // get tplfile and tplsource
Severity: Minor
Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

    Method tplsadmin_import_data has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function tplsadmin_import_data( $tplset, $tpl_file, $tpl_source, $lastmodified = 0 ) {

    $db =& XoopsDatabaseFactory::getDatabaseConnection();

    // check the file is valid template
    Severity: Minor
    Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

      Method tplsadmin_copy_templates_f2db has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function tplsadmin_copy_templates_f2db( $tplset_to, $whr_append = '1' ) {
    global $db;

    // get tplsource
    //$result = $db->query('SELECT * FROM ' . $db->prefix('tplfile') . "  WHERE tpl_tplset='default' AND ($whr_append)") ;
      Severity: Minor
      Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

        Function tplsadmin_copy_templates_db2db has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function tplsadmin_copy_templates_db2db( $tplset_from, $tplset_to, $whr_append = '1' ) {
    global $db;

    // get tplfile and tplsource
        Severity: Minor
        Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function tplsadmin_import_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function tplsadmin_import_data( $tplset, $tpl_file, $tpl_source, $lastmodified = 0 ) {

    $db =& XoopsDatabaseFactory::getDatabaseConnection();

    // check the file is valid template
        Severity: Minor
        Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function tplsadmin_copy_templates_f2db has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function tplsadmin_copy_templates_f2db( $tplset_to, $whr_append = '1' ) {
    global $db;

    // get tplsource
    //$result = $db->query('SELECT * FROM ' . $db->prefix('tplfile') . "  WHERE tpl_tplset='default' AND ($whr_append)") ;
        Severity: Minor
        Found in xoops_trust_path/libs/altsys/include/tpls_functions.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    while ( list( $tpl_id ) = $db->fetchRow( $drs ) ) {
                // UPDATE mode

                $db->query( 'UPDATE ' . $db->prefix( 'tplfile' ) . " SET tpl_lastmodified='" . addslashes( $lastmodified ) . "' WHERE tpl_id='$tpl_id'" );
        Severity: Major
        Found in xoops_trust_path/libs/altsys/include/tpls_functions.php and 1 other location - About 1 hr to fix
        xoops_trust_path/libs/altsys/include/tpls_functions.php on lines 74..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            while ( list( $tpl_id ) = $db->fetchRow( $drs ) ) {
        $db->queryF( 'UPDATE ' . $db->prefix( 'tplfile' ) . " SET tpl_lastmodified='" . addslashes( $lastmodified ) . "',tpl_lastimported=UNIX_TIMESTAMP() WHERE tpl_id='$tpl_id'" );

        $db->queryF( 'UPDATE ' . $db->prefix( 'tplsource' ) . " SET tpl_source='" . addslashes( $tpl_source ) . "' WHERE tpl_id='$tpl_id'" );
        Severity: Major
        Found in xoops_trust_path/libs/altsys/include/tpls_functions.php and 1 other location - About 1 hr to fix
        xoops_trust_path/libs/altsys/include/tpls_functions.php on lines 217..225

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status