xoopscube/altsys

View on GitHub
xoops_trust_path/libs/altsys/mypreferences.php

Summary

Maintainability
C
1 day
Test Coverage

Avoid deeply nested control flow statements.
Open

                if (!$theme_updated && $config->getVar('conf_catid') == XOOPS_CONF && $config->getVar('conf_name') == 'theme_set') {
                    $member_handler =& xoops_gethandler('member');
                    $member_handler->updateUsersByField('theme', $_POST[$config->getVar('conf_name')]);
                    $theme_updated = true;
                }
Severity: Major
Found in xoops_trust_path/libs/altsys/mypreferences.php - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                    if (!$tpl_updated && $config->getVar('conf_catid') == XOOPS_CONF && $config->getVar('conf_name') == 'template_set') {
                        // clear cached/compiled files and regenerate them if default theme has been changed
                        if ($xoopsConfig['template_set'] != $_POST[$config->getVar('conf_name')]) {
                            $newtplset = $_POST[$config->getVar('conf_name')];
    
    
    Severity: Major
    Found in xoops_trust_path/libs/altsys/mypreferences.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if (!$lang_updated && $config->getVar('conf_catid') == XOOPS_CONF && $config->getVar('conf_name') == 'language') {
                          // regenerate admin menu file
                          $xoopsConfig['language'] = $_POST[$config->getVar('conf_name')];
                          xoops_module_write_admin_menu(xoops_module_get_admin_menu());
                          $lang_updated = true;
      Severity: Major
      Found in xoops_trust_path/libs/altsys/mypreferences.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        if (!$startmod_updated    && $new_value != '--' && $config->getVar('conf_catid') == XOOPS_CONF && $config->getVar('conf_name') == 'startpage') {
                            $member_handler =& xoops_gethandler('member');
                            $groups =& $member_handler->getGroupList();
                            $moduleperm_handler =& xoops_gethandler('groupperm');
                            $module_handler =& xoops_gethandler('module');
        Severity: Major
        Found in xoops_trust_path/libs/altsys/mypreferences.php - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      for ($j = 0; $j < $opcount; $j++) {
                          $optval = defined($options[$j]->getVar('confop_value')) ? constant($options[$j]->getVar('confop_value')) : $options[$j]->getVar('confop_value');
                          $optkey = defined($options[$j]->getVar('confop_name')) ? constant($options[$j]->getVar('confop_name')) : $options[$j]->getVar('confop_name');
                          
                          $ele->addOption($optval, $optkey.$addBr);
          Severity: Major
          Found in xoops_trust_path/libs/altsys/mypreferences.php and 1 other location - About 3 hrs to fix
          xoops_trust_path/libs/altsys/mypreferences.php on lines 99..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 148.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      for ($j = 0; $j < $opcount; $j++) {
                          $optval = defined($options[$j]->getVar('confop_value')) ? constant($options[$j]->getVar('confop_value')) : $options[$j]->getVar('confop_value');
                          $optkey = defined($options[$j]->getVar('confop_name')) ? constant($options[$j]->getVar('confop_name')) : $options[$j]->getVar('confop_name');
                          $ele->addOption($optval, $optkey.$addBr);
                      }
          Severity: Major
          Found in xoops_trust_path/libs/altsys/mypreferences.php and 1 other location - About 3 hrs to fix
          xoops_trust_path/libs/altsys/mypreferences.php on lines 116..121

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 148.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status