xoopscube/altsys

Avoid deeply nested control flow statements.

Open

                if ( ! $lang_updated && $config->getVar( 'conf_catid' ) == XOOPS_CONF && $config->getVar( 'conf_name' ) == 'language' ) {
                    // regenerate admin menu file
                    $xoopsConfig['language'] = $_POST[ $config->getVar( 'conf_name' ) ];
                    xoops_module_write_admin_menu( xoops_module_get_admin_menu() );
                    $lang_updated = true;

Avoid deeply nested control flow statements.

Open

                if ( ! $theme_updated && $config->getVar( 'conf_catid' ) == XOOPS_CONF && $config->getVar( 'conf_name' ) == 'theme_set' ) {
                    $member_handler =& xoops_gethandler( 'member' );
                    $member_handler->updateUsersByField( 'theme', $_POST[ $config->getVar( 'conf_name' ) ] );
                    $theme_updated = true;
                }

Avoid deeply nested control flow statements.

Open

                if ( ! $startmod_updated && $new_value != '--' && $config->getVar( 'conf_catid' ) == XOOPS_CONF && $config->getVar( 'conf_name' ) == 'startpage' ) {
                    $member_handler     =& xoops_gethandler( 'member' );
                    $groups             =& $member_handler->getGroupList();
                    $moduleperm_handler =& xoops_gethandler( 'groupperm' );
                    $module_handler     =& xoops_gethandler( 'module' );

Avoid deeply nested control flow statements.

Open

                if ( ! $tpl_updated && $config->getVar( 'conf_catid' ) == XOOPS_CONF && $config->getVar( 'conf_name' ) == 'template_set' ) {
                    // clear cached/compiled files and regenerate them if default theme has been changed
                    if ( $xoopsConfig['template_set'] != $_POST[ $config->getVar( 'conf_name' ) ] ) {
                        $newtplset = $_POST[ $config->getVar( 'conf_name' ) ];

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                for ( $j = 0; $j < $opcount; $j ++ ) {
                    $optval = defined( $options[ $j ]->getVar( 'confop_value' ) ) ? constant( $options[ $j ]->getVar( 'confop_value' ) ) : $options[ $j ]->getVar( 'confop_value' );
                    $optkey = defined( $options[ $j ]->getVar( 'confop_name' ) ) ? constant( $options[ $j ]->getVar( 'confop_name' ) ) : $options[ $j ]->getVar( 'confop_name' );

                    $ele->addOption( $optval, $optkey . $addBr );

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                for ( $j = 0; $j < $opcount; $j ++ ) {
                    $optval = defined( $options[ $j ]->getVar( 'confop_value' ) ) ? constant( $options[ $j ]->getVar( 'confop_value' ) ) : $options[ $j ]->getVar( 'confop_value' );
                    $optkey = defined( $options[ $j ]->getVar( 'confop_name' ) ) ? constant( $options[ $j ]->getVar( 'confop_name' ) ) : $options[ $j ]->getVar( 'confop_name' );
                    $ele->addOption( $optval, $optkey . $addBr );
                }

• Read up
  Read up