xylabs/sdk-react

View on GitHub

Showing 148 of 148 total issues

SnapchatStandardEvents has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

export class SnapchatStandardEvents<T extends SnapchatStandardProperties> {
  achievementUnlocked() {
    return new SnapchatStandardEvent<T>('ACHIEVEMENT_UNLOCKED')
  }

Severity: Minor
Found in packages/pixel/src/lib/Tracking/Snapchat/StandardEvents.ts - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export class TiktokBaseEvent<T> {
      name: string
      ttq: Ttq
      constructor(name: string) {
        this.name = name
    Severity: Major
    Found in packages/pixel/src/lib/Tracking/Tiktok/BaseEvent.ts and 1 other location - About 3 hrs to fix
    packages/pixel/src/lib/Tracking/Reddit/BaseEvent.ts on lines 6..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class RedditBaseEvent<T> {
      name: string
      rdt: Rdt
      constructor(name: string) {
        this.name = name
    Severity: Major
    Found in packages/pixel/src/lib/Tracking/Reddit/BaseEvent.ts and 1 other location - About 3 hrs to fix
    packages/pixel/src/lib/Tracking/Tiktok/BaseEvent.ts on lines 6..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function mergeBoxlikeStyles has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const mergeBoxlikeStyles = <T extends BoxlikeComponentProps>(theme: Theme, props: BoxlikeComponentProps, defaultProps?: BoxlikeComponentProps): T => {
      const {
        alignContent,
        alignItems,
        alignSelf,
    Severity: Major
    Found in packages/shared/src/mergeBoxlikeStyles.ts - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const setLocalStorageObject = <T>(key: string, value: T, log?: Log) => {
        try {
          localStorage.setItem(key, JSON.stringify(value))
        } catch (e) {
          log?.error('setLocalStorageObject', e)
      Severity: Major
      Found in packages/shared/src/lib/safeLocalStorage.ts and 1 other location - About 2 hrs to fix
      packages/shared/src/lib/safeSessionStorage.ts on lines 13..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const setSessionStorageObject = <T>(key: string, value: T, log?: Log) => {
        try {
          sessionStorage.setItem(key, JSON.stringify(value))
        } catch (e) {
          log?.error('setSessionStorageObject', e)
      Severity: Major
      Found in packages/shared/src/lib/safeSessionStorage.ts and 1 other location - About 2 hrs to fix
      packages/shared/src/lib/safeLocalStorage.ts on lines 13..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        subscribeToAccountsChanges(listener: () => void) {
          this.accountChangeNotifiers = [listener, ...this.accountChangeNotifiers]
          return () => {
            this.accountChangeNotifiers = this.accountChangeNotifiers.filter((l) => l !== listener)
          }
      packages/crypto/src/wallets/third-party/classes/EthWalletConnectorBase.ts on lines 127..132

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        subscribeToChainChanges(listener: () => void) {
          this.chainChangedNotifiers = [listener, ...this.chainChangedNotifiers]
          return () => {
            this.chainChangedNotifiers = this.chainChangedNotifiers.filter((l) => l !== listener)
          }
      packages/crypto/src/wallets/third-party/classes/EthWalletConnectorBase.ts on lines 113..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function Template has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const Template: StoryFn<WalletDiscoveryPaperProps> = (args) => {
        const [selectedWallet, setSelectedWallet] = useState<EIP6963Connector | undefined>()
        const [errorArray, setErrorArray] = useState<[string, Error][]>([])
      
        useEffect(() => {
      Severity: Major
      Found in packages/crypto/src/wallets/components/Discovery/Paper.stories.tsx - About 2 hrs to fix

        Function EthAccountBox has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

        export const EthAccountBox: React.FC<EthAccountProps & FlexBoxProps> = ({
          address,
          icon = false,
          iconSize = 16,
          iconOnly = false,
        Severity: Minor
        Found in packages/crypto/src/components/EthAccount/EthAccountBox.tsx - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateCanvas has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

        const updateCanvas = (canvas: React.RefObject<HTMLCanvasElement>, props: IdenticonProps) => {
          const { value = '', size = 400, bg = 'transparent', count = 5, palette, iconPadding = 0 } = props
          let { fg } = props
          const hash = md5(value)
          const block = Math.floor(size / count)
        Severity: Minor
        Found in packages/identicon/src/components/Identicon.tsx - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            mutex
              ?.acquire()
              .then(() => {
                promiseMemo
                  ?.then((payload) => {
        Severity: Major
        Found in packages/promise/src/usePromise.ts and 1 other location - About 2 hrs to fix
        packages/promise/src/usePromise.ts on lines 49..64

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 80.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                promiseMemo
                  ?.then((payload) => {
                    if (debug) console.log(`usePromise [${debug}] then`)
                    setResult(payload)
                    setError(undefined)
        Severity: Major
        Found in packages/promise/src/usePromise.ts and 1 other location - About 2 hrs to fix
        packages/promise/src/usePromise.ts on lines 46..73

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 80.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function usePromise has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const usePromise = <TResult>(
          promise: () => Promise<TResult | undefined>,
          dependencies: DependencyList,
          debug: string | undefined = undefined,
        ): [TResult | undefined, Error | undefined, State | undefined] => {
        Severity: Major
        Found in packages/promise/src/usePromise.ts - About 2 hrs to fix

          Function OperaEthersLoader has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export const OperaEthersLoader: React.FC<PropsWithChildren<Props>> = (props) => {
            const { children } = props
            // eslint-disable-next-line @typescript-eslint/no-explicit-any
            const global = window as any
            const ethereum = global.ethereum
          Severity: Major
          Found in packages/crypto/src/contexts/Ethers/Opera.tsx - About 2 hrs to fix

            Function DarkModeIconButton has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

            export const DarkModeIconButton: React.FC<DarkModeIconButtonProps> = ({
              darkMode,
              defaultDarkModeColor,
              defaultLightModeColor,
              toggleMode,
            Severity: Minor
            Found in packages/invertible-theme/src/Buttons/DarkModeIconButton.tsx - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function useBusyTiming has 51 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export const useBusyTiming = (busy?: boolean, busyMinimum = 0) => {
              const [internalBusy, setInternalBusy] = useState(false)
              const [busyStart, setBusyStart] = useState(0)
            
              const timer = useMemo(
            Severity: Major
            Found in packages/flexbox/src/hooks/useBusyTiming.tsx - About 2 hrs to fix

              Function PixelDebugger has 49 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export const PixelDebugger: React.FC = () => {
                const { isDebugging } = useContext(DebugUserEventsContext)
                //TODO - when adding in the location hook to detect location change, was dropping the setEvents in usePixelAltSendHand
                const theme = useTheme()
                const [displayEvents, setDisplayEvents] = useState(false)
              Severity: Minor
              Found in packages/pixel-debugger/src/components/PixelDebugger.tsx - About 1 hr to fix

                Function ExperimentsDebugger has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                const ExperimentsDebugger: React.FC = ({ ...props }) => {
                  const [experiments] = useLocalStorage<ExperimentsData>(ExperimentsLocalStorageKey, {})
                  const [outcomes, setOutcomes] = useLocalStorage<OutcomesData>(OutcomesLocalStorageKey, {})
                
                  const sumUpVariants = (items: VariantData[]) => items.reduce((acc, curr) => acc + curr.weight, 0)
                Severity: Minor
                Found in packages/experiments/src/components/ExperimentsDebugger.tsx - About 1 hr to fix

                  Function TrustEthersLoader has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export const TrustEthersLoader: React.FC<PropsWithChildren<Props>> = (props) => {
                    const { children } = props
                    const [error, setError] = useState<Error>()
                    const [signer, setSigner] = useState<JsonRpcSigner>()
                    const [localAddress, setLocalAddress] = useState<EthAddress>()
                  Severity: Minor
                  Found in packages/crypto/src/contexts/Ethers/Trust.tsx - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language