Sign upLogin

yannickcr/eslint-plugin-react

View on GitHub
Star

Showing 710 of 710 total issues

Function MemberExpression has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    MemberExpression(node) {
      const isDefaultProp = propsUtil.isDefaultPropsDeclaration(node);

      if (!isDefaultProp) {
        return;
Severity: Minor
Found in lib/util/defaultProps.js - About 1 hr to fix

    Function refersToReactFragment has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function refersToReactFragment(node, name) {
      const variableInit = variableUtil.findVariableByName(context, node, name);
      if (!variableInit) {
        return false;
      }
    Severity: Minor
    Found in lib/rules/jsx-fragments.js - About 1 hr to fix

      Function getPropertyName has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getPropertyName(context, node, utils, checkAsyncSafeLifeCycles) {
  const property = node.property;
  if (property) {
    switch (property.type) {
      case 'Identifier':
      Severity: Minor
      Found in lib/util/usedPropTypes.js - About 1 hr to fix

        Function handleOpeningElement has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function handleOpeningElement(node) {
      const sourceCode = getSourceCode(context);
      let prevToken = sourceCode.getTokenBefore(node);
      if (!prevToken) {
        return;
        Severity: Minor
        Found in lib/rules/jsx-indent.js - About 1 hr to fix

          Function CallExpression has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                CallExpression(node) {
        const callee = node.callee;
        const parent = node.parent;
        if (callee.type !== 'MemberExpression') {
          return;
          Severity: Minor
          Found in lib/rules/no-render-return-value.js - About 1 hr to fix

            Function reportErrorIfLifecycleMethodCasingTypo has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function reportErrorIfLifecycleMethodCasingTypo(node) {
      const key = node.key;
      let nodeKeyName = key.name;
      if (key.type === 'Literal') {
        nodeKeyName = key.value;
            Severity: Minor
            Found in lib/rules/no-typos.js - About 1 hr to fix

              Function create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                create(context) {
    const configuration = context.options[0] || {};
    const ignoreCase = configuration.ignoreCase || false;

    return {
              Severity: Minor
              Found in lib/rules/jsx-no-duplicate-props.js - About 1 hr to fix

                Function Program:exit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      'Program:exit'() {
        const list = components.list();

        values(list).filter((component) => {
          if (functions === 'ignore' && astUtil.isFunctionLike(component.node)) {
                Severity: Minor
                Found in lib/rules/require-default-props.js - About 1 hr to fix

                  Function ImportDeclaration has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        ImportDeclaration(node) {
        if (node.source && node.source.value === 'prop-types') { // import PropType from "prop-types"
          if (node.specifiers.length > 0) {
            propTypesPackageName = node.specifiers[0].local.name;
          } else {
                  Severity: Minor
                  Found in lib/rules/no-typos.js - About 1 hr to fix

                    Function findAllTypeAnnotations has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        function findAllTypeAnnotations(identifier, node) {
      if (node.type === 'TSTypeLiteral' || node.type === 'ObjectTypeAnnotation' || node.type === 'TSInterfaceBody') {
        const currentNode = [].concat(
          objectTypeAnnotations.get(identifier.name) || [],
          node
                    Severity: Minor
                    Found in lib/rules/boolean-prop-naming.js - About 1 hr to fix

                      Consider simplifying this complex logical expression.
                      Open

                                  if (
              (ancestor.type !== 'Property' && ancestor.type !== 'MethodDefinition' && ancestor.type !== 'ClassProperty' && ancestor.type !== 'PropertyDefinition')
              || !nameMatches(ancestor.key.name)
              || (mode !== 'disallow-in-func' && depth > 1)
            ) {
                      Severity: Major
                      Found in lib/util/makeNoMethodSetStateRule.js - About 1 hr to fix

                        Consider simplifying this complex logical expression.
                        Open

                              if (
        astUtil.isCallExpression(node)
        && node.callee
        && node.callee.type === 'Identifier'
        && node.callee.name === 'String'
                        Severity: Major
                        Found in lib/rules/no-array-index-key.js - About 1 hr to fix

                          Consider simplifying this complex logical expression.
                          Open

                                  if (
          relatedComponent
            && (componentUtil.isES6Component(relatedComponent.node, context) || (
              relatedComponent.node.type !== 'ClassDeclaration' && utils.isReturningJSX(relatedComponent.node)))
            && (node.parent && node.parent.type === 'AssignmentExpression' && node.parent.right)
                          Severity: Major
                          Found in lib/rules/no-typos.js - About 1 hr to fix

                            Consider simplifying this complex logical expression.
                            Open

                                  if (
        parent.type && parent.type === 'JSXAttribute'
        && (node.expression && node.expression.type
          && node.expression.type !== 'Literal'
          && node.expression.type !== 'StringLiteral'
                            Severity: Major
                            Found in lib/rules/jsx-curly-brace-presence.js - About 1 hr to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      values(components.list()).forEach((component) => {
          const properties = astUtil.getComponentProperties(component.node);
          checkPropsOrder(properties);
        });
                              Severity: Minor
                              Found in lib/rules/sort-comp.js and 1 other location - About 55 mins to fix
                              lib/rules/no-arrow-function-lifecycle.js on lines 142..145

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 54.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    fix(fixer) {
        const previousToken = sourceCode.getTokenBefore(closingSlash);
        return fixer.removeRange([previousToken.range[1], closingSlash.range[0]]);
      },
                              Severity: Minor
                              Found in lib/rules/jsx-tag-spacing.js and 1 other location - About 55 mins to fix
                              lib/rules/jsx-space-before-closing.js on lines 78..81

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 54.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          fix(fixer) {
              const previousToken = sourceCode.getTokenBefore(closingSlash);
              return fixer.removeRange([previousToken.range[1], closingSlash.range[0]]);
            },
                              Severity: Minor
                              Found in lib/rules/jsx-space-before-closing.js and 1 other location - About 55 mins to fix
                              lib/rules/jsx-tag-spacing.js on lines 139..142

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 54.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      values(components.list()).forEach((component) => {
          const properties = astUtil.getComponentProperties(component.node);
          reportNoArrowFunctionLifecycle(properties);
        });
                              Severity: Minor
                              Found in lib/rules/no-arrow-function-lifecycle.js and 1 other location - About 55 mins to fix
                              lib/rules/sort-comp.js on lines 438..441

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 54.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Function isNodeALifeCycleMethod has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function isNodeALifeCycleMethod(node, checkAsyncSafeLifeCycles) {
  if (node.key) {
    if (node.kind === 'constructor') {
      return true;
    }
                              Severity: Minor
                              Found in lib/util/usedPropTypes.js - About 55 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function getReactVersionFromContext has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function getReactVersionFromContext(context) {
  readDefaultReactVersionFromContext(context);
  let confVer = defaultVersion;
  // .eslintrc shared settings (https://eslint.org/docs/user-guide/configuring#adding-shared-settings)
  if (context.settings && context.settings.react && context.settings.react.version) {
                              Severity: Minor
                              Found in lib/util/version.js - About 55 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language