Sign upLogin

yasshi2525/RushHour

View on GitHub
Star
client/src/reducers/index.ts

Summary

Maintainability
C
1 day
Test Coverage

Avoid too many return statements within this function.
Open

      return Object.assign({}, state, inOperation);
Severity: Major
Found in client/src/reducers/index.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return Object.assign({}, state, { inOperation });
    Severity: Major
    Found in client/src/reducers/index.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return Object.assign({}, state, { inPurge });
      Severity: Major
      Found in client/src/reducers/index.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return Object.assign({}, state, { players });
        Severity: Major
        Found in client/src/reducers/index.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return Object.assign({}, state, { inOperation });
          Severity: Major
          Found in client/src/reducers/index.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return Object.assign({}, state, { inPurge });
            Severity: Major
            Found in client/src/reducers/index.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return Object.assign({}, state, { players });
              Severity: Major
              Found in client/src/reducers/index.ts - About 30 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    case Actions.purgeUserData.request.toString():
      var inPurge: AsyncStatus = Object.assign({}, state.inPurge, {
        waiting: true
      });
      return Object.assign({}, state, { inPurge });
                Severity: Major
                Found in client/src/reducers/index.ts and 2 other locations - About 1 hr to fix
                client/src/reducers/index.ts on lines 65..69
                client/src/reducers/index.ts on lines 82..86

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 73.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    case Actions.inOperation.failure.toString():
      var inOperation: AsyncStatus = Object.assign({}, state.inOperation, {
        waiting: false
      });
      return Object.assign({}, state, { inOperation });
                Severity: Major
                Found in client/src/reducers/index.ts and 2 other locations - About 1 hr to fix
                client/src/reducers/index.ts on lines 70..74
                client/src/reducers/index.ts on lines 82..86

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 73.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    case Actions.playersPlain.request.toString():
      var players: AsyncStatus = Object.assign({}, state.players, {
        waiting: true
      });
      return Object.assign({}, state, { players });
                Severity: Major
                Found in client/src/reducers/index.ts and 2 other locations - About 1 hr to fix
                client/src/reducers/index.ts on lines 65..69
                client/src/reducers/index.ts on lines 70..74

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 73.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status