Sign upLogin

yasshi2525/RushHour

View on GitHub
Star
services/rail.go

Summary

Maintainability
B
5 hrs
Test Coverage
F
0%

Function ConnectRailNode has 6 return statements (exceeds 4 allowed).
Open

func ConnectRailNode(o *entities.Player, from *entities.RailNode, to *entities.RailNode, scale int) (*entities.DelegateRailEdge, error) {
    if err := CheckAuth(o, from); err != nil {
        return nil, err
    }
    if err := CheckAuth(o, to); err != nil {
Severity: Major
Found in services/rail.go - About 40 mins to fix

    Function ExtendRailNode has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func ExtendRailNode(o *entities.Player, from *entities.RailNode,
    x float64, y float64, scale int) (*entities.DelegateRailNode, *entities.DelegateRailEdge, error) {
    Severity: Minor
    Found in services/rail.go - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func RemoveRailEdge(o *entities.Player, id uint) error {
    if re, err := Model.DeleteIf(o, entities.RAILEDGE, id); err != nil {
        return err
    } else {
        re := re.(*entities.RailEdge)
      Severity: Major
      Found in services/rail.go and 2 other locations - About 2 hrs to fix
      services/rail.go on lines 23..40
      services/station.go on lines 30..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 196.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func RemoveRailNode(o *entities.Player, id uint) error {
    if rn, err := Model.DeleteIf(o, entities.RAILNODE, id); err != nil {
        return err
    } else {
        rn := rn.(*entities.RailNode)
      Severity: Major
      Found in services/rail.go and 2 other locations - About 2 hrs to fix
      services/rail.go on lines 96..113
      services/station.go on lines 30..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 196.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status