Sign upLogin

yfix/yf

View on GitHub
Star
plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php

Summary

Maintainability
C
1 day
Test Coverage

Method clear_patterns has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function clear_patterns()
    {
        $html = table('SELECT * FROM ' . db('shop_patterns'), [
            'table_attr' => 'id="patterns_list"',
            'filter' => $_SESSION[$_GET['object'] . '__patterns'],
Severity: Major
Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php - About 2 hrs to fix

    Method clear_pattern_child_process has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function clear_pattern_child_process()
    {
        if ( ! isset($_GET['id']) && (int) ($_GET['id'])) {
            return t('Empty clear pattern ID');
        }
    Severity: Minor
    Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php - About 1 hr to fix

      Method clear_pattern_list has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function clear_pattern_list()
    {
        if ( ! isset($_GET['id']) && (int) ($_GET['id'])) {
            return t('Empty clear pattern ID');
        }
      Severity: Minor
      Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php - About 1 hr to fix

        Function clear_pattern_child_process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function clear_pattern_child_process()
    {
        if ( ! isset($_GET['id']) && (int) ($_GET['id'])) {
            return t('Empty clear pattern ID');
        }
        Severity: Minor
        Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return '<button class="btn btn-mini btn-xs btn-danger rollback_item" data-id="' . $row_info['id'] . '"><i class="icon-undo fa fa-undo"></i> <span>' . t('Rollback') . '</span></button>';
        Severity: Major
        Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return '<button class="btn btn-mini btn-xs btn-warning rollback_item" data-id="' . $row_info['id'] . '"><i class="icon-refresh fa fa-refresh icon-spin fa-spin"></i> <span>' . t('Process') . '...</span></button>';
          Severity: Major
          Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $html;
            Severity: Major
            Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      $html = table('SELECT * FROM ' . db('shop_patterns'), [
            'table_attr' => 'id="patterns_list"',
            'filter' => $_SESSION[$_GET['object'] . '__patterns'],
            'filter_params' => [
                'search' => 'like',
              Severity: Minor
              Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php and 1 other location - About 45 mins to fix
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 20..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 96.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          if ( ! empty($row_info['cat_id'])) {
                $cat_ids = _class('cats')->_get_recursive_cat_ids($row_info['cat_id']);
                $where = ' AND (cat_id IN (' . implode(',', $cat_ids) . ') OR id IN (SELECT product_id FROM ' . db('shop_product_to_category') . ' WHERE category_id IN (' . implode(',', $cat_ids) . ')))';
            }
              Severity: Major
              Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php and 3 other locations - About 45 mins to fix
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 88..91
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 246..249
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 282..285

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 95.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          if ( ! empty($item['cat_id'])) {
                $cat_ids = _class('cats')->_get_recursive_cat_ids($row_info['cat_id']);
                $where = ' AND (cat_id IN (' . implode(',', $cat_ids) . ') OR id IN (SELECT product_id FROM ' . db('shop_product_to_category') . ' WHERE category_id IN (' . implode(',', $cat_ids) . ')))';
            }
              Severity: Major
              Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php and 3 other locations - About 45 mins to fix
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 39..42
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 88..91
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 282..285

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 95.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      if ( ! empty($pattern_info['cat_id'])) {
            $cat_ids = _class('cats')->_get_recursive_cat_ids($row_info['cat_id']);
            $where = ' AND (cat_id IN (' . implode(',', $cat_ids) . ') OR id IN (SELECT product_id FROM ' . db('shop_product_to_category') . ' WHERE category_id IN (' . implode(',', $cat_ids) . ')))';
        }
              Severity: Major
              Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php and 3 other locations - About 45 mins to fix
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 39..42
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 88..91
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 246..249

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 95.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      if ( ! empty($pattern_info['cat_id'])) {
            $cat_ids = _class('cats')->_get_recursive_cat_ids($row_info['cat_id']);
            $where = ' AND (cat_id IN (' . implode(',', $cat_ids) . ') OR id IN (SELECT product_id FROM ' . db('shop_product_to_category') . ' WHERE category_id IN (' . implode(',', $cat_ids) . ')))';
        }
              Severity: Major
              Found in plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php and 3 other locations - About 45 mins to fix
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 39..42
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 246..249
              plugins/shop/admin_modules/manage_shop/yf_manage_shop_clear_products.class.php on lines 282..285

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 95.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status