Sign upLogin

yfix/yf

View on GitHub
Star
plugins/sys/admin_modules/yf_blocks.class.php

Summary

Maintainability
D
2 days
Test Coverage

File yf_blocks.class.php has 412 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Blocks editor.
 *
Severity: Minor
Found in plugins/sys/admin_modules/yf_blocks.class.php - About 5 hrs to fix

    yf_blocks has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class yf_blocks
{
    /***/
    private $_preload_complete = false;
    Severity: Minor
    Found in plugins/sys/admin_modules/yf_blocks.class.php - About 2 hrs to fix

      Method edit_rule has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function edit_rule()
    {
        $rule_info = db()->get('SELECT * FROM ' . db('block_rules') . ' WHERE id=' . (int) ($_GET['id']));
        if (empty($rule_info['id'])) {
            return _e('No such rule!');
      Severity: Minor
      Found in plugins/sys/admin_modules/yf_blocks.class.php - About 1 hr to fix

        Method add_rule has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function add_rule()
    {
        $block_info = db()->query_fetch('SELECT * FROM ' . db('blocks') . ' WHERE id=' . (int) ($_GET['id']));
        if (empty($block_info['id'])) {
            return _e('No such block!');
        Severity: Minor
        Found in plugins/sys/admin_modules/yf_blocks.class.php - About 1 hr to fix

          Method show has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function show()
    {
        $func = function ($row) {
            return ! ($row['name'] == 'center_area' && $row['type'] == 'admin');
        };
          Severity: Minor
          Found in plugins/sys/admin_modules/yf_blocks.class.php - About 1 hr to fix

            Function edit_rule has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function edit_rule()
    {
        $rule_info = db()->get('SELECT * FROM ' . db('block_rules') . ' WHERE id=' . (int) ($_GET['id']));
        if (empty($rule_info['id'])) {
            return _e('No such rule!');
            Severity: Minor
            Found in plugins/sys/admin_modules/yf_blocks.class.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public function _multi_db_to_html($input = '')
    {
        if ( ! is_array($input)) {
            $input = explode(',', str_replace([' ', "\t", "\r", "\n", ',,'], '', $input));
        }
            Severity: Major
            Found in plugins/sys/admin_modules/yf_blocks.class.php and 1 other location - About 1 hr to fix
            plugins/sys/admin_modules/yf_menus_editor.class.php on lines 820..832

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ( ! empty($block_info['id'])) {
            db()->UPDATE('block_rules', ['active' => (int) ! $rule_info['active']], 'id=' . (int) ($_GET['id']));
            common()->admin_wall_add(['block rule for ' . $block_info['name'] . ' ' . ($rule_info['active'] ? 'inactivated' : 'activated'), $_GET['id']]);
            module('blocks')->_cache_purge();
        }
            Severity: Major
            Found in plugins/sys/admin_modules/yf_blocks.class.php and 1 other location - About 1 hr to fix
            plugins/sys/admin_modules/yf_menus_editor.class.php on lines 209..213

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status