yoctore/yocto-express

View on GitHub

Showing 56 of 56 total issues

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  if (!this.isReady()) {
    // Error message
    this.logger.error([ '[ Express.processJsonCallack ] -',
      'Cannot process config. App is not ready.' ].join(' '));

Severity: Major
Found in src/index.js and 15 other locations - About 1 hr to fix
src/index.js on lines 217..224
src/index.js on lines 247..254
src/index.js on lines 277..284
src/index.js on lines 310..317
src/index.js on lines 339..346
src/index.js on lines 386..393
src/index.js on lines 474..481
src/index.js on lines 507..514
src/index.js on lines 545..552
src/index.js on lines 574..581
src/index.js on lines 697..704
src/index.js on lines 730..737
src/index.js on lines 780..787
src/index.js on lines 992..999
src/index.js on lines 1044..1051

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  if (!this.isReady()) {
    // Error message
    this.logger.error([ '[ Express.processSession ] -',
      'Cannot process config. App is not ready.' ].join(' '));

Severity: Major
Found in src/index.js and 15 other locations - About 1 hr to fix
src/index.js on lines 217..224
src/index.js on lines 247..254
src/index.js on lines 277..284
src/index.js on lines 310..317
src/index.js on lines 339..346
src/index.js on lines 386..393
src/index.js on lines 443..450
src/index.js on lines 474..481
src/index.js on lines 507..514
src/index.js on lines 545..552
src/index.js on lines 697..704
src/index.js on lines 730..737
src/index.js on lines 780..787
src/index.js on lines 992..999
src/index.js on lines 1044..1051

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  if (!this.isReady()) {
    // Error message
    this.logger.error([ '[ Express.processStackError ] -',
      'Cannot process config. App is not ready.' ].join(' '));

Severity: Major
Found in src/index.js and 15 other locations - About 1 hr to fix
src/index.js on lines 247..254
src/index.js on lines 277..284
src/index.js on lines 310..317
src/index.js on lines 339..346
src/index.js on lines 386..393
src/index.js on lines 443..450
src/index.js on lines 474..481
src/index.js on lines 507..514
src/index.js on lines 545..552
src/index.js on lines 574..581
src/index.js on lines 697..704
src/index.js on lines 730..737
src/index.js on lines 780..787
src/index.js on lines 992..999
src/index.js on lines 1044..1051

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  if (!this.isReady()) {
    // Error message
    this.logger.error([ '[ Express.processPrettyHTML ] -',
      'Cannot process config. App is not ready.' ].join(' '));

Severity: Major
Found in src/index.js and 15 other locations - About 1 hr to fix
src/index.js on lines 217..224
src/index.js on lines 277..284
src/index.js on lines 310..317
src/index.js on lines 339..346
src/index.js on lines 386..393
src/index.js on lines 443..450
src/index.js on lines 474..481
src/index.js on lines 507..514
src/index.js on lines 545..552
src/index.js on lines 574..581
src/index.js on lines 697..704
src/index.js on lines 730..737
src/index.js on lines 780..787
src/index.js on lines 992..999
src/index.js on lines 1044..1051

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  if (!this.isReady()) {
    // Error message
    this.logger.error([ '[ Express.processMultipart ] -',
      'Cannot process config. App is not ready.' ].join(' '));

Severity: Major
Found in src/index.js and 15 other locations - About 1 hr to fix
src/index.js on lines 217..224
src/index.js on lines 247..254
src/index.js on lines 277..284
src/index.js on lines 310..317
src/index.js on lines 339..346
src/index.js on lines 386..393
src/index.js on lines 443..450
src/index.js on lines 474..481
src/index.js on lines 507..514
src/index.js on lines 545..552
src/index.js on lines 574..581
src/index.js on lines 730..737
src/index.js on lines 780..787
src/index.js on lines 992..999
src/index.js on lines 1044..1051

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  if (!this.isReady()) {
    // Error message
    this.logger.error([ '[ Express.processBodyParser ] -',
      'Cannot process config. App is not ready.' ].join(' '));

Severity: Major
Found in src/index.js and 15 other locations - About 1 hr to fix
src/index.js on lines 217..224
src/index.js on lines 247..254
src/index.js on lines 277..284
src/index.js on lines 310..317
src/index.js on lines 339..346
src/index.js on lines 386..393
src/index.js on lines 443..450
src/index.js on lines 474..481
src/index.js on lines 545..552
src/index.js on lines 574..581
src/index.js on lines 697..704
src/index.js on lines 730..737
src/index.js on lines 780..787
src/index.js on lines 992..999
src/index.js on lines 1044..1051

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

  if (!this.isReady()) {
    // Error message
    this.logger.error([ '[ Express.processPrerender ] -',
      'Cannot process config. App is not ready.' ].join(' '));

Severity: Major
Found in src/index.js and 15 other locations - About 1 hr to fix
src/index.js on lines 217..224
src/index.js on lines 247..254
src/index.js on lines 277..284
src/index.js on lines 310..317
src/index.js on lines 339..346
src/index.js on lines 386..393
src/index.js on lines 443..450
src/index.js on lines 474..481
src/index.js on lines 507..514
src/index.js on lines 545..552
src/index.js on lines 574..581
src/index.js on lines 697..704
src/index.js on lines 730..737
src/index.js on lines 992..999
src/index.js on lines 1044..1051

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function processCompression has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

Express.prototype.processCompression = function () {
  // Config is ready ?
  if (!this.isReady()) {
    // Error message
    this.logger.error([ '[ Express.processCompression ] -',
Severity: Minor
Found in src/index.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

            if (validate.value.queryString && !_.isNull(qse.query)) {
              // Destination url as sub routes ?
              var qsee = url.parse(endUrl);

              // Path is already defined and href url not ending by a slash ?
Severity: Major
Found in src/index.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                if (_.startsWith(validate.value.toUrl, 'http') ||
                  _.startsWith(validate.value.toUrl, 'https')) {
                  // Change endUrl to use full defined url
                  endUrl = validate.value.toUrl;
                }
    Severity: Major
    Found in src/index.js - About 45 mins to fix

      Consider simplifying this complex logical expression.
      Open

        if (_.has(this.config.get('config'), 'app') &&
            _.has(this.config.get('config'), 'env') &&
            _.has(this.config.get('config'), 'host') &&
            _.has(this.config.get('config'), 'protocol')) {
          // Set the default name
      Severity: Major
      Found in src/index.js - About 40 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              certPath = !path.isAbsolute(certPath) ? path.normalize([ process.cwd(), certPath ].join('/')) :
                certPath;
        Severity: Minor
        Found in src/index.js and 1 other location - About 40 mins to fix
        src/index.js on lines 176..177

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              keyPath = !path.isAbsolute(keyPath) ? path.normalize([ process.cwd(), keyPath ].join('/')) :
                keyPath;
        Severity: Minor
        Found in src/index.js and 1 other location - About 40 mins to fix
        src/index.js on lines 178..179

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function processCors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        Express.prototype.processCors = function () {
          // Config is ready ?
          if (!this.isReady()) {
            // Error message
            this.logger.error([ '[ Express.processCors ] -',
        Severity: Minor
        Found in src/index.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function processRedirect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        Express.prototype.processRedirect = function () {
          // Config is ready ?
          if (!this.isReady()) {
            // Error message
            this.logger.error([ '[ Express.processRedirect ] -',
        Severity: Minor
        Found in src/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Move the invocation into the parens that contain the function.
        Open

        (function() {
        Severity: Minor
        Found in docs/scripts/linenumber.js by eslint

        Require IIFEs to be Wrapped (wrap-iife)

        You can immediately invoke function expressions, but not function declarations. A common technique to create an immediately-invoked function expression (IIFE) is to wrap a function declaration in parentheses. The opening parentheses causes the contained function to be parsed as an expression, rather than a declaration.

        // function expression could be unwrapped
        var x = function () { return { y: 1 };}();
        
        // function declaration must be wrapped
        function () { /* side effects */ }(); // SyntaxError

        Rule Details

        This rule requires all immediately-invoked function expressions to be wrapped in parentheses.

        Options

        This rule has two options, a string option and an object option.

        String option:

        • "outside" enforces always wrapping the call expression. The default is "outside".
        • "inside" enforces always wrapping the function expression.
        • "any" enforces always wrapping, but allows either style.

        Object option:

        • "functionPrototypeMethods": true additionally enforces wrapping function expressions invoked using .call and .apply. The default is false.

        outside

        Examples of incorrect code for the default "outside" option:

        /*eslint wrap-iife: ["error", "outside"]*/
        
        var x = function () { return { y: 1 };}(); // unwrapped
        var x = (function () { return { y: 1 };})(); // wrapped function expression

        Examples of correct code for the default "outside" option:

        /*eslint wrap-iife: ["error", "outside"]*/
        
        var x = (function () { return { y: 1 };}()); // wrapped call expression

        inside

        Examples of incorrect code for the "inside" option:

        /*eslint wrap-iife: ["error", "inside"]*/
        
        var x = function () { return { y: 1 };}(); // unwrapped
        var x = (function () { return { y: 1 };}()); // wrapped call expression

        Examples of correct code for the "inside" option:

        /*eslint wrap-iife: ["error", "inside"]*/
        
        var x = (function () { return { y: 1 };})(); // wrapped function expression

        any

        Examples of incorrect code for the "any" option:

        /*eslint wrap-iife: ["error", "any"]*/
        
        var x = function () { return { y: 1 };}(); // unwrapped

        Examples of correct code for the "any" option:

        /*eslint wrap-iife: ["error", "any"]*/
        
        var x = (function () { return { y: 1 };}()); // wrapped call expression
        var x = (function () { return { y: 1 };})(); // wrapped function expression

        functionPrototypeMethods

        Examples of incorrect code for this rule with the "inside", { "functionPrototypeMethods": true } options:

        /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
        
        var x = function(){ foo(); }()
        var x = (function(){ foo(); }())
        var x = function(){ foo(); }.call(bar)
        var x = (function(){ foo(); }.call(bar))

        Examples of correct code for this rule with the "inside", { "functionPrototypeMethods": true } options:

        /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
        
        var x = (function(){ foo(); })()
        var x = (function(){ foo(); }).call(bar)

        Source: http://eslint.org/docs/rules/

        Severity
        Category
        Status
        Source
        Language