yoctore/yocto-mongoose

View on GitHub

Showing 82 of 82 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if (!(value instanceof Schema)) {
      // invalid instance
      this.logger.warning([ ' [ YMongoose.createValidator ] - Cannot process.',
                            ' given schema is not an instanceof Schema' ].join(' '));
      // invalid statement
Severity: Major
Found in src/index.js and 2 other locations - About 45 mins to fix
src/index.js on lines 725..731
src/index.js on lines 777..783

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if (!(value instanceof Schema)) {
      // invalid instance
      this.logger.warning([ ' [ YMongoose.createMethod ] - Cannot process.',
                            ' given schema is not an instanceof Schema' ].join(' '));
      // invalid statement
Severity: Major
Found in src/index.js and 2 other locations - About 45 mins to fix
src/index.js on lines 725..731
src/index.js on lines 751..757

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

              if (err) {
                // reject with error message
                deferred.reject([ '[ Crud.create ] - Indexes creation failed :', err ].join(' '));
              } else {
                // resolve default statement
Severity: Major
Found in src/modules/crud/index.js - About 45 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        if (!(value instanceof Schema)) {
          // invalid instance
          this.logger.warning([ ' [ YMongoose.createCrud ] - Cannot process.',
                                ' given schema is not an instanceof Schema' ].join(' '));
          // invalid statement
    Severity: Major
    Found in src/index.js and 2 other locations - About 45 mins to fix
    src/index.js on lines 751..757
    src/index.js on lines 777..783

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid deeply nested control flow statements.
    Open

                  if ((item.type === 'post' || item.type === 'pre') &&
                    _.isString(item.event) && !_.isEmpty(item.event)) {
                    // debug message
                    this.logger.debug([ '[ Method.add ] - Adding [', item.type,
                      ' ] hook on current schema for event [', item.event, ']' ].join(' '));
    Severity: Major
    Found in src/modules/method/index.js - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          var files = glob.sync([ '**/', modelName, '.js'].join(''), {
            cwd       : path,
            realpath  : true,
            nocase    : true
          });
      Severity: Minor
      Found in src/modules/validator/index.js and 1 other location - About 40 mins to fix
      src/modules/method/index.js on lines 46..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          var files = glob.sync([ '**/', modelName, '.js'].join(''), {
            cwd       : path,
            realpath  : true,
            nocase    : true
          });
      Severity: Minor
      Found in src/modules/method/index.js and 1 other location - About 40 mins to fix
      src/modules/validator/index.js on lines 43..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      Method.prototype.add = function (schema, path, items, modelName, redis) {
      Severity: Minor
      Found in src/modules/method/index.js - About 35 mins to fix

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

            this.findByIdAndRemove(id, function (error, data) {
              // has error ?
              if (error) {
                // reject
                deferred.reject(error);
        Severity: Major
        Found in src/modules/crud/index.js and 3 other locations - About 35 mins to fix
        src/modules/crud/index.js on lines 233..242
        src/modules/crud/index.js on lines 245..254
        src/modules/crud/index.js on lines 349..358

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

            this.search(query || {}, options || {}, function (error, data) {
              // has error ?
              if (error) {
                // reject
                deferred.reject(error);
        Severity: Major
        Found in src/modules/crud/index.js and 3 other locations - About 35 mins to fix
        src/modules/crud/index.js on lines 195..204
        src/modules/crud/index.js on lines 233..242
        src/modules/crud/index.js on lines 245..254

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

            this.where().setOptions({ multi : true }).update(conditions, update, function (error, data) {
              // has error ?
              if (error) {
                // reject
                deferred.reject(error);
        Severity: Major
        Found in src/modules/crud/index.js and 3 other locations - About 35 mins to fix
        src/modules/crud/index.js on lines 195..204
        src/modules/crud/index.js on lines 245..254
        src/modules/crud/index.js on lines 349..358

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Open

            this[method](conditions, update, { new : true }, function (error, data) {
              // has error ?
              if (error) {
                // reject
                deferred.reject(error);
        Severity: Major
        Found in src/modules/crud/index.js and 3 other locations - About 35 mins to fix
        src/modules/crud/index.js on lines 195..204
        src/modules/crud/index.js on lines 233..242
        src/modules/crud/index.js on lines 349..358

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function get has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        Enums.prototype.get = function (name) {
          // is a valid string ?
          if (_.isString(name) && !_.isEmpty(name)) {
            // data is ok so try to get enums from given name
            if (_.isArray(this.enums) && !_.isEmpty(this.enums)) {
        Severity: Minor
        Found in src/modules/enum/index.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        Crud.prototype.add = function (schema, exclude, redisIncludes, redis) {
          // valid data ?
          if ((!_.isObject(schema) && !(schema instanceof Schema)) || !_.isArray(exclude)) {
            this.logger.warning('[ Crud.add ] - Schema or exclude item given is invalid');
            // invalid statement
        Severity: Minor
        Found in src/modules/crud/index.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        YMongoose.prototype.load = function () {
          // Create our deferred object, which we will use in our promise chain
          var deferred = Q.defer();
        
          var errors  = [];   // list of errors
        Severity: Minor
        Found in src/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addDefaultIndexes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        ElasticUtils.prototype.addDefaultIndexes = function (obj) {
          // first test
          if (!obj || !_.isObject(obj)) {
            // default statement
            return obj;
        Severity: Minor
        Found in src/modules/utils/elastic.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Unexpected trailing comma.
        Open

                cert    : joi.string().optional().empty(),
        Severity: Minor
        Found in src/modules/utils/redis.js by eslint

        require or disallow trailing commas (comma-dangle)

        Trailing commas in object literals are valid according to the ECMAScript 5 (and ECMAScript 3!) spec. However, IE8 (when not in IE8 document mode) and below will throw an error when it encounters trailing commas in JavaScript.

        var foo = {
            bar: "baz",
            qux: "quux",
        };

        Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:

        Less clear:

        var foo = {
        -    bar: "baz",
        -    qux: "quux"
        +    bar: "baz"
         };

        More clear:

        var foo = {
             bar: "baz",
        -    qux: "quux",
         };

        Rule Details

        This rule enforces consistent use of trailing commas in object and array literals.

        Options

        This rule has a string option or an object option:

        {
            "comma-dangle": ["error", "never"],
            // or
            "comma-dangle": ["error", {
                "arrays": "never",
                "objects": "never",
                "imports": "never",
                "exports": "never",
                "functions": "ignore",
            }]
        }
        • "never" (default) disallows trailing commas
        • "always" requires trailing commas
        • "always-multiline" requires trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }
        • "only-multiline" allows (but does not require) trailing commas when the last element or property is in a different line than the closing ] or } and disallows trailing commas when the last element or property is on the same line as the closing ] or }

        Trailing commas in function declarations and function calls are valid syntax since ECMAScript 2017; however, the string option does not check these situations for backwards compatibility.

        You can also use an object option to configure this rule for each type of syntax. Each of the following options can be set to "never", "always", "always-multiline", "only-multiline", or "ignore". The default for each option is "never" unless otherwise specified.

        • arrays is for array literals and array patterns of destructuring. (e.g. let [a,] = [1,];)
        • objects is for object literals and object patterns of destructuring. (e.g. let {a,} = {a: 1};)
        • imports is for import declarations of ES Modules. (e.g. import {a,} from "foo";)
        • exports is for export declarations of ES Modules. (e.g. export {a,};)
        • functions is for function declarations and function calls. (e.g. (function(a,){ })(b,);)
          functions is set to "ignore" by default for consistency with the string option.

        never

        Examples of incorrect code for this rule with the default "never" option:

        /*eslint comma-dangle: ["error", "never"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var arr = [1,2,];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        Examples of correct code for this rule with the default "never" option:

        /*eslint comma-dangle: ["error", "never"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var arr = [1,2];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        always

        Examples of incorrect code for this rule with the "always" option:

        /*eslint comma-dangle: ["error", "always"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var arr = [1,2];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        Examples of correct code for this rule with the "always" option:

        /*eslint comma-dangle: ["error", "always"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var arr = [1,2,];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        always-multiline

        Examples of incorrect code for this rule with the "always-multiline" option:

        /*eslint comma-dangle: ["error", "always-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var foo = { bar: "baz", qux: "quux", };
        
        var arr = [1,2,];
        
        var arr = [1,
            2,];
        
        var arr = [
            1,
            2
        ];
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        Examples of correct code for this rule with the "always-multiline" option:

        /*eslint comma-dangle: ["error", "always-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var foo = {bar: "baz", qux: "quux"};
        var arr = [1,2];
        
        var arr = [1,
            2];
        
        var arr = [
            1,
            2,
        ];
        
        foo({
          bar: "baz",
          qux: "quux",
        });

        only-multiline

        Examples of incorrect code for this rule with the "only-multiline" option:

        /*eslint comma-dangle: ["error", "only-multiline"]*/
        
        var foo = { bar: "baz", qux: "quux", };
        
        var arr = [1,2,];
        
        var arr = [1,
            2,];

        Examples of correct code for this rule with the "only-multiline" option:

        /*eslint comma-dangle: ["error", "only-multiline"]*/
        
        var foo = {
            bar: "baz",
            qux: "quux",
        };
        
        var foo = {
            bar: "baz",
            qux: "quux"
        };
        
        var foo = {bar: "baz", qux: "quux"};
        var arr = [1,2];
        
        var arr = [1,
            2];
        
        var arr = [
            1,
            2,
        ];
        
        var arr = [
            1,
            2
        ];
        
        foo({
          bar: "baz",
          qux: "quux",
        });
        
        foo({
          bar: "baz",
          qux: "quux"
        });

        functions

        Examples of incorrect code for this rule with the {"functions": "never"} option:

        /*eslint comma-dangle: ["error", {"functions": "never"}]*/
        
        function foo(a, b,) {
        }
        
        foo(a, b,);
        new foo(a, b,);

        Examples of correct code for this rule with the {"functions": "never"} option:

        /*eslint comma-dangle: ["error", {"functions": "never"}]*/
        
        function foo(a, b) {
        }
        
        foo(a, b);
        new foo(a, b);

        Examples of incorrect code for this rule with the {"functions": "always"} option:

        /*eslint comma-dangle: ["error", {"functions": "always"}]*/
        
        function foo(a, b) {
        }
        
        foo(a, b);
        new foo(a, b);

        Examples of correct code for this rule with the {"functions": "always"} option:

        /*eslint comma-dangle: ["error", {"functions": "always"}]*/
        
        function foo(a, b,) {
        }
        
        foo(a, b,);
        new foo(a, b,);

        When Not To Use It

        You can turn this rule off if you are not concerned with dangling commas. Source: http://eslint.org/docs/rules/

        Move the invocation into the parens that contain the function.
        Open

        (function() {
        Severity: Minor
        Found in docs/scripts/linenumber.js by eslint

        Require IIFEs to be Wrapped (wrap-iife)

        You can immediately invoke function expressions, but not function declarations. A common technique to create an immediately-invoked function expression (IIFE) is to wrap a function declaration in parentheses. The opening parentheses causes the contained function to be parsed as an expression, rather than a declaration.

        // function expression could be unwrapped
        var x = function () { return { y: 1 };}();
        
        // function declaration must be wrapped
        function () { /* side effects */ }(); // SyntaxError

        Rule Details

        This rule requires all immediately-invoked function expressions to be wrapped in parentheses.

        Options

        This rule has two options, a string option and an object option.

        String option:

        • "outside" enforces always wrapping the call expression. The default is "outside".
        • "inside" enforces always wrapping the function expression.
        • "any" enforces always wrapping, but allows either style.

        Object option:

        • "functionPrototypeMethods": true additionally enforces wrapping function expressions invoked using .call and .apply. The default is false.

        outside

        Examples of incorrect code for the default "outside" option:

        /*eslint wrap-iife: ["error", "outside"]*/
        
        var x = function () { return { y: 1 };}(); // unwrapped
        var x = (function () { return { y: 1 };})(); // wrapped function expression

        Examples of correct code for the default "outside" option:

        /*eslint wrap-iife: ["error", "outside"]*/
        
        var x = (function () { return { y: 1 };}()); // wrapped call expression

        inside

        Examples of incorrect code for the "inside" option:

        /*eslint wrap-iife: ["error", "inside"]*/
        
        var x = function () { return { y: 1 };}(); // unwrapped
        var x = (function () { return { y: 1 };}()); // wrapped call expression

        Examples of correct code for the "inside" option:

        /*eslint wrap-iife: ["error", "inside"]*/
        
        var x = (function () { return { y: 1 };})(); // wrapped function expression

        any

        Examples of incorrect code for the "any" option:

        /*eslint wrap-iife: ["error", "any"]*/
        
        var x = function () { return { y: 1 };}(); // unwrapped

        Examples of correct code for the "any" option:

        /*eslint wrap-iife: ["error", "any"]*/
        
        var x = (function () { return { y: 1 };}()); // wrapped call expression
        var x = (function () { return { y: 1 };})(); // wrapped function expression

        functionPrototypeMethods

        Examples of incorrect code for this rule with the "inside", { "functionPrototypeMethods": true } options:

        /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
        
        var x = function(){ foo(); }()
        var x = (function(){ foo(); }())
        var x = function(){ foo(); }.call(bar)
        var x = (function(){ foo(); }.call(bar))

        Examples of correct code for this rule with the "inside", { "functionPrototypeMethods": true } options:

        /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
        
        var x = (function(){ foo(); })()
        var x = (function(){ foo(); }).call(bar)

        Source: http://eslint.org/docs/rules/

        unnecessary '.call()'.
        Open

              this.remove.call(this, keys);
        Severity: Minor
        Found in src/modules/utils/redis.js by eslint

        Disallow unnecessary .call() and .apply(). (no-useless-call)

        The function invocation can be written by Function.prototype.call() and Function.prototype.apply(). But Function.prototype.call() and Function.prototype.apply() are slower than the normal function invocation.

        Rule Details

        This rule is aimed to flag usage of Function.prototype.call() and Function.prototype.apply() that can be replaced with the normal function invocation.

        Examples of incorrect code for this rule:

        /*eslint no-useless-call: "error"*/
        
        // These are same as `foo(1, 2, 3);`
        foo.call(undefined, 1, 2, 3);
        foo.apply(undefined, [1, 2, 3]);
        foo.call(null, 1, 2, 3);
        foo.apply(null, [1, 2, 3]);
        
        // These are same as `obj.foo(1, 2, 3);`
        obj.foo.call(obj, 1, 2, 3);
        obj.foo.apply(obj, [1, 2, 3]);

        Examples of correct code for this rule:

        /*eslint no-useless-call: "error"*/
        
        // The `this` binding is different.
        foo.call(obj, 1, 2, 3);
        foo.apply(obj, [1, 2, 3]);
        obj.foo.call(null, 1, 2, 3);
        obj.foo.apply(null, [1, 2, 3]);
        obj.foo.call(otherObj, 1, 2, 3);
        obj.foo.apply(otherObj, [1, 2, 3]);
        
        // The argument list is variadic.
        foo.apply(undefined, args);
        foo.apply(null, args);
        obj.foo.apply(obj, args);

        Known Limitations

        This rule compares code statically to check whether or not thisArg is changed. So if the code about thisArg is a dynamic expression, this rule cannot judge correctly.

        Examples of incorrect code for this rule:

        /*eslint no-useless-call: "error"*/
        
        a[i++].foo.call(a[i++], 1, 2, 3);

        Examples of correct code for this rule:

        /*eslint no-useless-call: "error"*/
        
        a[++i].foo.call(a[i], 1, 2, 3);

        When Not To Use It

        If you don't want to be notified about unnecessary .call() and .apply(), you can safely disable this rule. Source: http://eslint.org/docs/rules/

        Unexpected require().
        Open

                var fo = require(f);
        Severity: Minor
        Found in src/modules/validator/index.js by eslint

        Enforce require() on the top-level module scope (global-require)

        In Node.js, module dependencies are included using the require() function, such as:

        var fs = require("fs");

        While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

        function foo() {
        
            if (condition) {
                var fs = require("fs");
            }
        }

        Since require() does a synchronous load, it can cause performance problems when used in other locations.

        Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

        Rule Details

        This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

        Examples of incorrect code for this rule:

        /*eslint global-require: "error"*/
        /*eslint-env es6*/
        
        // calling require() inside of a function is not allowed
        function readFile(filename, callback) {
            var fs = require('fs');
            fs.readFile(filename, callback)
        }
        
        // conditional requires like this are also not allowed
        if (DEBUG) { require('debug'); }
        
        // a require() in a switch statement is also flagged
        switch(x) { case '1': require('1'); break; }
        
        // you may not require() inside an arrow function body
        var getModule = (name) => require(name);
        
        // you may not require() inside of a function body as well
        function getModule(name) { return require(name); }
        
        // you may not require() inside of a try/catch block
        try {
            require(unsafeModule);
        } catch(e) {
            console.log(e);
        }

        Examples of correct code for this rule:

        /*eslint global-require: "error"*/
        
        // all these variations of require() are ok
        require('x');
        var y = require('y');
        var z;
        z = require('z').initialize();
        
        // requiring a module and using it in a function is ok
        var fs = require('fs');
        function readFile(filename, callback) {
            fs.readFile(filename, callback)
        }
        
        // you can use a ternary to determine which module to require
        var logger = DEBUG ? require('dev-logger') : require('logger');
        
        // if you want you can require() at the end of your module
        function doSomethingA() {}
        function doSomethingB() {}
        var x = require("x"),
            z = require("z");

        When Not To Use It

        If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

        Severity
        Category
        Status
        Source
        Language