yoichiro/chrome_mysql_admin

View on GitHub

Showing 375 of 375 total issues

Function ISO2022KRDecoder has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function ISO2022KRDecoder(options) {
    var fatal = options.fatal;
    /** @enum */
    var state = {
      ASCII: 0,
Severity: Major
Found in app/scripts/lib/encoding.js - About 4 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            showFullColumns: function(table) {
                var deferred = $q.defer();
                mySQLClientService.query("SHOW FULL COLUMNS FROM `" + table + "`").then(function(result) {
                    if (result.hasResultsetRows) {
                        deferred.resolve(result);
    Severity: Major
    Found in app/scripts/window/services/mysql_query_service.js and 3 other locations - About 4 hrs to fix
    app/scripts/window/services/mysql_query_service.js on lines 126..138
    app/scripts/window/services/mysql_query_service.js on lines 139..151
    app/scripts/window/services/mysql_query_service.js on lines 152..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            showIndex: function(table) {
                var deferred = $q.defer();
                mySQLClientService.query("SHOW INDEX FROM `" + table + "`").then(function(result) {
                    if (result.hasResultsetRows) {
                        deferred.resolve(result);
    Severity: Major
    Found in app/scripts/window/services/mysql_query_service.js and 3 other locations - About 4 hrs to fix
    app/scripts/window/services/mysql_query_service.js on lines 113..125
    app/scripts/window/services/mysql_query_service.js on lines 139..151
    app/scripts/window/services/mysql_query_service.js on lines 152..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            showFunctionStatus: function(database) {
                var deferred = $q.defer();
                mySQLClientService.query("SHOW FUNCTION STATUS WHERE db = '" + database + "'").then(function(result) {
                    if (result.hasResultsetRows) {
                        deferred.resolve(result);
    Severity: Major
    Found in app/scripts/window/services/mysql_query_service.js and 3 other locations - About 4 hrs to fix
    app/scripts/window/services/mysql_query_service.js on lines 113..125
    app/scripts/window/services/mysql_query_service.js on lines 126..138
    app/scripts/window/services/mysql_query_service.js on lines 139..151

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            showProcedureStatus: function(database) {
                var deferred = $q.defer();
                mySQLClientService.query("SHOW PROCEDURE STATUS WHERE db = '" + database + "'").then(function(result) {
                    if (result.hasResultsetRows) {
                        deferred.resolve(result);
    Severity: Major
    Found in app/scripts/window/services/mysql_query_service.js and 3 other locations - About 4 hrs to fix
    app/scripts/window/services/mysql_query_service.js on lines 113..125
    app/scripts/window/services/mysql_query_service.js on lines 126..138
    app/scripts/window/services/mysql_query_service.js on lines 152..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        var updateQueryResult = function(columnDefinitions, resultsetRows) {
            var rows = [];
            angular.forEach(resultsetRows, function(resultsetRow) {
                var values = resultsetRow.values;
                var row = {};
    Severity: Major
    Found in app/scripts/window/controllers/query_panel_controller.js and 1 other location - About 4 hrs to fix
    app/scripts/window/controllers/rows_panel_controller.js on lines 121..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        var updateRows = function(columnDefinitions, resultsetRows) {
            var rows = [];
            angular.forEach(resultsetRows, function(resultsetRow) {
                var values = resultsetRow.values;
                var row = {};
    Severity: Major
    Found in app/scripts/window/controllers/rows_panel_controller.js and 1 other location - About 4 hrs to fix
    app/scripts/window/controllers/query_panel_controller.js on lines 230..241

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File structure_panel_controller.js has 334 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    chromeMyAdmin.controller("StructurePanelController", function(
        $scope,
        mySQLClientService,
        modeService,
        targetObjectService,
    Severity: Minor
    Found in app/scripts/window/controllers/structure_panel_controller.js - About 4 hrs to fix

      Function decode has 100 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          this.decode = function(byte_pointer) {
            var bite = byte_pointer.get();
            if (bite !== EOF_byte) {
              byte_pointer.offset(1);
            }
      Severity: Major
      Found in app/scripts/lib/encoding.js - About 4 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $scope.addKey = function() {
                $scope.selectedKeys.push($scope.key);
                $scope.keys = $scope.keys.filter(function(e) {
                    return $scope.key !== e;
                });
        app/scripts/window/controllers/add_index_dialog_controller.js on lines 63..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $scope.addColumn = function() {
                $scope.selectedColumns.push($scope.column);
                $scope.columns = $scope.columns.filter(function(e) {
                    return $scope.column !== e;
                });
        app/scripts/window/controllers/find_same_rows_dialog_controller.js on lines 118..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                showGlobalStatus: function() {
                    var deferred = $q.defer();
                    mySQLClientService.queryWithoutProgressBar("SHOW GLOBAL STATUS").then(function(result) {
                        if (result.hasResultsetRows) {
                            deferred.resolve(result);
        Severity: Major
        Found in app/scripts/window/services/mysql_query_service.js and 2 other locations - About 3 hrs to fix
        app/scripts/window/services/mysql_query_service.js on lines 56..69
        app/scripts/window/services/mysql_query_service.js on lines 191..203

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                showTables: function() {
                    var deferred = $q.defer();
                    mySQLClientService.query("SHOW /*!50002 FULL*/ TABLES").then(function(result) {
                        if (result.hasResultsetRows) {
                            deferred.resolve(result);
        Severity: Major
        Found in app/scripts/window/services/mysql_query_service.js and 2 other locations - About 3 hrs to fix
        app/scripts/window/services/mysql_query_service.js on lines 178..190
        app/scripts/window/services/mysql_query_service.js on lines 191..203

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                getConnectionId: function() {
                    var deferred = $q.defer();
                    mySQLClientService.queryWithoutProgressBar("SELECT CONNECTION_ID()").then(function(result) {
                        if (result.hasResultsetRows) {
                            deferred.resolve(result);
        Severity: Major
        Found in app/scripts/window/services/mysql_query_service.js and 2 other locations - About 3 hrs to fix
        app/scripts/window/services/mysql_query_service.js on lines 56..69
        app/scripts/window/services/mysql_query_service.js on lines 178..190

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        writableEntry.createWriter(function(writer) {
                            writer.onerror = function(e) {
                                $scope.fatalErrorOccurred(e);
                            };
                            writer.onwriteend = function() {
        app/scripts/window/controllers/query_panel_controller.js on lines 259..269

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 109.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        writableEntry.createWriter(function(writer) {
                            writer.onerror = function(e) {
                                $scope.fatalErrorOccurred(e);
                            };
                            writer.onwriteend = function() {
        Severity: Major
        Found in app/scripts/window/controllers/query_panel_controller.js and 1 other location - About 3 hrs to fix
        app/scripts/window/controllers/er_diagram_panel_controller.js on lines 157..167

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 109.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File procedures_functions_panel_controller.js has 315 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        chromeMyAdmin.controller("ProceduresFunctionsPanelController", function(
            $scope,
            mySQLClientService,
            modeService,
            targetObjectService,

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              $scope.deleteSelectedColumn = function(selectedColumn) {
                  $scope.columns.push(selectedColumn);
                  $scope.selectedColumns = $scope.selectedColumns.filter(function(e) {
                      return selectedColumn !== e;
                  });
          app/scripts/window/controllers/find_same_rows_dialog_controller.js on lines 128..136

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              $scope.deleteSelectedKey = function(selectedKey) {
                  $scope.keys.push(selectedKey);
                  $scope.selectedKeys = $scope.selectedKeys.filter(function(e) {
                      return selectedKey !== e;
                  });
          app/scripts/window/controllers/add_index_dialog_controller.js on lines 73..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ($scope.defaultValue) {
                      if (typeService.isNumeric($scope.type)
                          || $scope.type == 'TIMESTAMP' && $scope.defaultValue == "CURRENT_TIMESTAMP"
                      ) {
                          sql += "DEFAULT " + $scope.defaultValue + " ";
          app/scripts/window/controllers/add_column_dialog_controller.js on lines 113..121

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language