zalando/connexion

View on GitHub
connexion/security/security_handler_factory.py

Summary

Maintainability
C
1 day
Test Coverage

File security_handler_factory.py has 296 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import abc
import base64
import functools
import logging
import os
Severity: Minor
Found in connexion/security/security_handler_factory.py - About 3 hrs to fix

    AbstractSecurityHandlerFactory has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class AbstractSecurityHandlerFactory(abc.ABC):
        """
        get_*_func -> _get_function -> get_function_from_name (name=security function defined in spec)
            (if url defined instead of a function -> get_token_info_remote)
    
    
    Severity: Minor
    Found in connexion/security/security_handler_factory.py - About 2 hrs to fix

      Function verify_api_key has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def verify_api_key(self, api_key_info_func, loc, name):
              check_api_key_func = self.check_api_key(api_key_info_func)
      
              def wrapper(request, required_scopes):
      
      
      Severity: Minor
      Found in connexion/security/security_handler_factory.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _generic_check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def _generic_check(self, func, exception_msg):
              need_to_add_context, need_to_add_required_scopes = self._need_to_add_context_or_scopes(func)
      
              def wrapper(request, *args, required_scopes=None):
                  kwargs = {}
      Severity: Minor
      Found in connexion/security/security_handler_factory.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function verify_security has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def verify_security(cls, auth_funcs, required_scopes, function):
              @functools.wraps(function)
              def wrapper(request):
                  token_info = None
                  for func in auth_funcs:
      Severity: Minor
      Found in connexion/security/security_handler_factory.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status