Sign upLogin

zhmcclient/python-zhmcclient

View on GitHub
Star
zhmcclient/_storage_group.py

Summary

Maintainability
C
1 day
Test Coverage

File _storage_group.py has 619 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2018,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in zhmcclient/_storage_group.py - About 1 day to fix

    Function delete has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def delete(self, email_to_addresses=None, email_cc_addresses=None,
               email_insert=None):
        """
        Delete this storage group and its storage volume resources on the HMC,
        and optionally send emails to storage administrators requesting
    Severity: Minor
    Found in zhmcclient/_storage_group.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function list_candidate_adapter_ports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def list_candidate_adapter_ports(self, full_properties=False):
        """
        Return the current candidate storage adapter port list of this FCP
        storage group.
    Severity: Minor
    Found in zhmcclient/_storage_group.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status