Sign upLogin

zhmcclient/python-zhmcclient

View on GitHub
Star

Showing 336 of 336 total issues

File _urihandler.py has 4434 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in zhmcclient_mock/_urihandler.py - About 1 wk to fix

    File _hmc.py has 3077 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
    Severity: Major
    Found in zhmcclient_mock/_hmc.py - About 1 wk to fix

      File _cpc.py has 2279 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
      Severity: Major
      Found in zhmcclient/_cpc.py - About 6 days to fix

        File _lpar.py has 1703 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
        Severity: Major
        Found in zhmcclient/_lpar.py - About 4 days to fix

          File _session.py has 1688 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
          Severity: Major
          Found in zhmcclient/_session.py - About 4 days to fix

            File _exceptions.py has 1152 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
            Severity: Major
            Found in zhmcclient/_exceptions.py - About 2 days to fix

              File _partition.py has 1109 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
              Severity: Major
              Found in zhmcclient/_partition.py - About 2 days to fix

                File _manager.py has 1108 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                Severity: Major
                Found in zhmcclient/_manager.py - About 2 days to fix

                  File _session.py has 1033 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                  Severity: Major
                  Found in zhmcclient_mock/_session.py - About 2 days to fix

                    File _console.py has 956 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # Copyright 2017,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                    Severity: Major
                    Found in zhmcclient/_console.py - About 2 days to fix

                      File _metrics.py has 776 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      # Copyright 2017,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                      Severity: Major
                      Found in zhmcclient/_metrics.py - About 1 day to fix

                        Function on_message has a Cognitive Complexity of 78 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def on_message(self, headers, message):
        """
        Event method that gets called when this listener has received a JMS
        message (representing an HMC notification).
                        Severity: Minor
                        Found in zhmcclient/_auto_updater.py - About 1 day to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        File _storage_group.py has 619 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        # Copyright 2018,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                        Severity: Major
                        Found in zhmcclient/_storage_group.py - About 1 day to fix

                          File _resource.py has 568 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                          Severity: Major
                          Found in zhmcclient/_resource.py - About 1 day to fix

                            File _adapter.py has 539 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                            Severity: Major
                            Found in zhmcclient/_adapter.py - About 1 day to fix

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if hmc_version >= (2, 14, 1):
            wwpn = body.get('world-wide-port-name')
            lun = body.get('logical-unit-number')
            disk_partition_id = body.get('disk-partition-id', 0)
            os_load_parameters = body.get(
                              Severity: Major
                              Found in zhmcclient_mock/_urihandler.py and 1 other location - About 1 day to fix
                              zhmcclient_mock/_urihandler.py on lines 4830..4843

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 137.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if hmc_version >= (2, 14, 1):
            wwpn = body.get('world-wide-port-name')
            lun = body.get('logical-unit-number')
            disk_partition_id = body.get('disk-partition-id', 0)
            os_load_parameters = body.get(
                              Severity: Major
                              Found in zhmcclient_mock/_urihandler.py and 1 other location - About 1 day to fix
                              zhmcclient_mock/_urihandler.py on lines 4736..4749

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 137.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              File _utils.py has 472 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              # Copyright 2016,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                              Severity: Minor
                              Found in zhmcclient/_utils.py - About 7 hrs to fix

                                File _storage_volume.py has 467 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                # Copyright 2018,2021 IBM Corp. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
                                Severity: Minor
                                Found in zhmcclient/_storage_volume.py - About 7 hrs to fix

                                  Cpc has 44 functions (exceeds 20 allowed). Consider refactoring.
                                  Open

                                  class Cpc(BaseResource):
    """
    Representation of a managed :term:`CPC`.

    Derived from :class:`~zhmcclient.BaseResource`; see there for common
                                  Severity: Minor
                                  Found in zhmcclient/_cpc.py - About 6 hrs to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language