Sign upLogin

zhmcclient/zhmccli

View on GitHub
Star

Showing 191 of 191 total issues

Function cmd_adapter_show_crypto has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def cmd_adapter_show_crypto(cmd_ctx, cpc_name, adapter_name):
    # pylint: disable=missing-function-docstring

    client = zhmcclient.Client(cmd_ctx.session)
    cpc = find_cpc(cmd_ctx, client, cpc_name)
Severity: Minor
Found in zhmccli/_cmd_adapter.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function cmd_hba_list has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def cmd_hba_list(cmd_ctx, cpc_name, partition_name, options):
    # pylint: disable=missing-function-docstring

    client = zhmcclient.Client(cmd_ctx.session)
    partition = find_partition(cmd_ctx, client, cpc_name, partition_name)
Severity: Minor
Found in zhmccli/_cmd_hba.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _add_special_name_option has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def _add_special_name_option(
Severity: Minor
Found in zhmccli/_cmd_user_pattern.py - About 45 mins to fix

    Function cmd_ldapdef_update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def cmd_ldapdef_update(cmd_ctx, ldapdef_name, options):
    # pylint: disable=missing-function-docstring

    client = zhmcclient.Client(cmd_ctx.session)
    console = client.consoles.console
    Severity: Minor
    Found in zhmccli/_cmd_ldap_server_definition.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function cmd_vswitch_list has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def cmd_vswitch_list(cmd_ctx, cpc_name, options):
    # pylint: disable=missing-function-docstring

    client = zhmcclient.Client(cmd_ctx.session)
    cpc = find_cpc(cmd_ctx, client, cpc_name)
    Severity: Minor
    Found in zhmccli/_cmd_vswitch.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function cmd_console_upgrade has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def cmd_console_upgrade(cmd_ctx, options):
    # pylint: disable=missing-function-docstring

    client = zhmcclient.Client(cmd_ctx.session)
    console = client.consoles.console
    Severity: Minor
    Found in zhmccli/_cmd_console.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if not filter_adapter:
                        included = True
                    elif ov.resource_uri == filter_adapter.uri:
                        included = True
            elif resource_class == 'nic':
    Severity: Major
    Found in zhmccli/_cmd_metrics.py - About 45 mins to fix

      Function cmd_session_create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def cmd_session_create(cmd_ctx):
    """Create an HMC session."""
    session = cmd_ctx.session
    try:
        # We need to first log off, to make the logon really create a new
      Severity: Minor
      Found in zhmccli/_cmd_session.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function print_object_values_as_table has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def print_object_values_as_table(
      Severity: Minor
      Found in zhmccli/_cmd_metrics.py - About 45 mins to fix

        Consider simplifying this complex logical expression.
        Open

                    if r_class == 'cpc' and r_name:
                filter_cpc = client.cpcs.find(name=r_name)
            elif r_class == 'partition' and r_name:
                assert filter_cpc
                filter_partition = filter_cpc.partitions.find(name=r_name)
        Severity: Major
        Found in zhmccli/_cmd_metrics.py - About 40 mins to fix

          Function print_dicts_as_json has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def print_dicts_as_json(
          Severity: Minor
          Found in zhmccli/_helper.py - About 35 mins to fix

            Function console_log has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def console_log(logger, prefix, message, *args, **kwargs):
            Severity: Minor
            Found in zhmccli/_helper.py - About 35 mins to fix

              Function get_mcl_str has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def get_mcl_str(bundle_level, ec_levels, all_, concurrent, install_disruptive):
              Severity: Minor
              Found in zhmccli/_helper.py - About 35 mins to fix

                Function find_port has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def find_port(cmd_ctx, client, cpc_name, adapter_name, port_name):
                Severity: Minor
                Found in zhmccli/_cmd_port.py - About 35 mins to fix

                  Function cmd_hba_update has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def cmd_hba_update(cmd_ctx, cpc_name, partition_name, hba_name, options):
                  Severity: Minor
                  Found in zhmccli/_cmd_hba.py - About 35 mins to fix

                    Function lpar_load has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def lpar_load(cmd_ctx, cpc, lpar, load_address, **options):
                    Severity: Minor
                    Found in zhmccli/_cmd_lpar.py - About 35 mins to fix

                      Function cmd_port_update has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      def cmd_port_update(cmd_ctx, cpc_name, adapter_name, port_name, options):
                      Severity: Minor
                      Found in zhmccli/_cmd_port.py - About 35 mins to fix

                        Function port_update has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        def port_update(cmd_ctx, cpc, adapter, port, **options):
                        Severity: Minor
                        Found in zhmccli/_cmd_port.py - About 35 mins to fix

                          Function find_nic has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          def find_nic(cmd_ctx, client, cpc_name, partition_name, nic_name):
                          Severity: Minor
                          Found in zhmccli/_cmd_nic.py - About 35 mins to fix

                            Function cmd_metrics_nic has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            def cmd_metrics_nic(cmd_ctx, cpc_name, partition_name, nic_name, options):
                            Severity: Minor
                            Found in zhmccli/_cmd_metrics.py - About 35 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language