zhuhaow/NEKit

View on GitHub
src/IPStack/DNS/DNSMessage.swift

Summary

Maintainability
D
1 day
Test Coverage

File DNSMessage.swift has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Foundation
import CocoaLumberjackSwift

open class DNSMessage {
    //    var sourceAddress: IPv4Address?
Severity: Minor
Found in src/IPStack/DNS/DNSMessage.swift - About 3 hrs to fix

    Function getNamefromData has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        static func getNamefromData(_ data: Data, offset: Int, base: Int = 0) -> (String, Int) {
            let scanner = BinaryDataScanner(data: data, littleEndian: false)
            scanner.skip(to: offset)
    
            var len: UInt8 = 0
    Severity: Minor
    Found in src/IPStack/DNS/DNSMessage.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getNamefromData has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static func getNamefromData(_ data: Data, offset: Int, base: Int = 0) -> (String, Int) {
            let scanner = BinaryDataScanner(data: data, littleEndian: false)
            scanner.skip(to: offset)
    
            var len: UInt8 = 0
    Severity: Minor
    Found in src/IPStack/DNS/DNSMessage.swift - About 1 hr to fix

      Function buildMessage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          func buildMessage() -> Bool {
              payload = Data(count: bytesLength)
              if transactionID == 0 {
                  transactionID = UInt16(arc4random_uniform(UInt32(UInt16.max)))
              }
      Severity: Minor
      Found in src/IPStack/DNS/DNSMessage.swift - About 1 hr to fix

        Function writeAllRecordAt has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            fileprivate func writeAllRecordAt(_ at: Int) -> Bool {
                var position = at
                for query in queries {
                    guard writeDNSQuery(query, at: position) else {
                        return false
        Severity: Minor
        Found in src/IPStack/DNS/DNSMessage.swift - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            func setPayloadWithUInt32(_ value: UInt32, at: Int, swap: Bool = false) {
                var v: UInt32
                if swap {
                    v = NSSwapHostIntToBig(value)
                } else {
        Severity: Major
        Found in src/IPStack/DNS/DNSMessage.swift and 3 other locations - About 1 hr to fix
        src/IPStack/DNS/DNSMessage.swift on lines 151..161
        src/IPStack/Packet/IPPacket.swift on lines 295..305
        src/IPStack/Packet/IPPacket.swift on lines 307..317

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            func setPayloadWithUInt16(_ value: UInt16, at: Int, swap: Bool = false) {
                var v: UInt16
                if swap {
                    v = NSSwapHostShortToBig(value)
                } else {
        Severity: Major
        Found in src/IPStack/DNS/DNSMessage.swift and 3 other locations - About 1 hr to fix
        src/IPStack/DNS/DNSMessage.swift on lines 163..173
        src/IPStack/Packet/IPPacket.swift on lines 295..305
        src/IPStack/Packet/IPPacket.swift on lines 307..317

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            func setPayloadWithUInt8(_ value: UInt8, at: Int) {
                var v = value
                withUnsafeBytes(of: &v) {
                    payload.replaceSubrange(at..<at+1, with: $0)
                }
        Severity: Minor
        Found in src/IPStack/DNS/DNSMessage.swift and 1 other location - About 50 mins to fix
        src/IPStack/Packet/IPPacket.swift on lines 288..293

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                for _ in 0..<nameserverCount {
                    nameservers.append(DNSResource(payload: payload, offset: scanner.position, base: 0)!)
                    scanner.advance(by: nameservers.last!.bytesLength)
                }
        Severity: Major
        Found in src/IPStack/DNS/DNSMessage.swift and 3 other locations - About 40 mins to fix
        src/IPStack/DNS/DNSMessage.swift on lines 87..90
        src/IPStack/DNS/DNSMessage.swift on lines 92..95
        src/IPStack/DNS/DNSMessage.swift on lines 102..105

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                for _ in 0..<queryCount {
                    queries.append(DNSQuery(payload: payload, offset: scanner.position, base: 0)!)
                    scanner.advance(by: queries.last!.bytesLength)
                }
        Severity: Major
        Found in src/IPStack/DNS/DNSMessage.swift and 3 other locations - About 40 mins to fix
        src/IPStack/DNS/DNSMessage.swift on lines 92..95
        src/IPStack/DNS/DNSMessage.swift on lines 97..100
        src/IPStack/DNS/DNSMessage.swift on lines 102..105

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                for _ in 0..<answerCount {
                    answers.append(DNSResource(payload: payload, offset: scanner.position, base: 0)!)
                    scanner.advance(by: answers.last!.bytesLength)
                }
        Severity: Major
        Found in src/IPStack/DNS/DNSMessage.swift and 3 other locations - About 40 mins to fix
        src/IPStack/DNS/DNSMessage.swift on lines 87..90
        src/IPStack/DNS/DNSMessage.swift on lines 97..100
        src/IPStack/DNS/DNSMessage.swift on lines 102..105

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                for _ in 0..<addtionalCount {
                    addtionals.append(DNSResource(payload: payload, offset: scanner.position, base: 0)!)
                    scanner.advance(by: addtionals.last!.bytesLength)
                }
        Severity: Major
        Found in src/IPStack/DNS/DNSMessage.swift and 3 other locations - About 40 mins to fix
        src/IPStack/DNS/DNSMessage.swift on lines 87..90
        src/IPStack/DNS/DNSMessage.swift on lines 92..95
        src/IPStack/DNS/DNSMessage.swift on lines 97..100

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            func resetPayloadAt(_ at: Int, length: Int) {
                payload.resetBytes(in: at..<at+length)
            }
        Severity: Minor
        Found in src/IPStack/DNS/DNSMessage.swift and 1 other location - About 30 mins to fix
        src/IPStack/Packet/IPPacket.swift on lines 327..329

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 42.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function should have at least one blank line after it
        Open

            }
        Severity: Minor
        Found in src/IPStack/DNS/DNSMessage.swift by tailor

        function-whitespace

        Every function and method declaration should have one blank line before and after itself. An exception to this rule are functions that are declared at the start of a file (only need one blank line after their declaration) or at the end of a file (only need one blank line before their declaration). Comments immediately before a function declaration (no blank lines between them and the function) are considered to be part of the declaration.

        Preferred

        func function1() {
          var text = 1
          var text = 2
        }
        
        function1()
        
        // a comment
        func function2() {
          // something goes here
        }
        
        struct SomeStruct {
        
          func function3() {
            // something goes here
          }
        
          func function4() {
            // something else goes here
          };
        
        }
        
        func function5() {
          // something goes here
        }

        Not Preferred

        func function1() {
          var text = 1
          var text = 2
        }
        function1()
        // a comment
        func function2() {
          // something goes here
        }
        
        struct SomeStruct {
          func function3() {
            // something goes here
          }
        
          func function4() {
            // something else goes here
          };
        }
        func function5() {
          // something goes here
        }

        Function should have at least one blank line after it
        Open

            }
        Severity: Minor
        Found in src/IPStack/DNS/DNSMessage.swift by tailor

        function-whitespace

        Every function and method declaration should have one blank line before and after itself. An exception to this rule are functions that are declared at the start of a file (only need one blank line after their declaration) or at the end of a file (only need one blank line before their declaration). Comments immediately before a function declaration (no blank lines between them and the function) are considered to be part of the declaration.

        Preferred

        func function1() {
          var text = 1
          var text = 2
        }
        
        function1()
        
        // a comment
        func function2() {
          // something goes here
        }
        
        struct SomeStruct {
        
          func function3() {
            // something goes here
          }
        
          func function4() {
            // something else goes here
          };
        
        }
        
        func function5() {
          // something goes here
        }

        Not Preferred

        func function1() {
          var text = 1
          var text = 2
        }
        function1()
        // a comment
        func function2() {
          // something goes here
        }
        
        struct SomeStruct {
          func function3() {
            // something goes here
          }
        
          func function4() {
            // something else goes here
          };
        }
        func function5() {
          // something goes here
        }

        Function should have at least one blank line before it
        Open

            static func setName(_ name: String, toData data: inout Data, at: Int) -> Bool {
        Severity: Minor
        Found in src/IPStack/DNS/DNSMessage.swift by tailor

        function-whitespace

        Every function and method declaration should have one blank line before and after itself. An exception to this rule are functions that are declared at the start of a file (only need one blank line after their declaration) or at the end of a file (only need one blank line before their declaration). Comments immediately before a function declaration (no blank lines between them and the function) are considered to be part of the declaration.

        Preferred

        func function1() {
          var text = 1
          var text = 2
        }
        
        function1()
        
        // a comment
        func function2() {
          // something goes here
        }
        
        struct SomeStruct {
        
          func function3() {
            // something goes here
          }
        
          func function4() {
            // something else goes here
          };
        
        }
        
        func function5() {
          // something goes here
        }

        Not Preferred

        func function1() {
          var text = 1
          var text = 2
        }
        function1()
        // a comment
        func function2() {
          // something goes here
        }
        
        struct SomeStruct {
          func function3() {
            // something goes here
          }
        
          func function4() {
            // something else goes here
          };
        }
        func function5() {
          // something goes here
        }

        There are no issues that match your filters.

        Category
        Status