Sign upLogin

zigomir/rubber_ring

View on GitHub
Star
app/helpers/rubber_ring/cms_helper.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method editable_image has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def editable_image(options = {}, page)
      key = options[:key]
      image_source = nil
      image_source = page.content[key] unless page.content.nil?
Severity: Minor
Found in app/helpers/rubber_ring/cms_helper.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compose_link has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def compose_link(block, options, page)
      key = options[:key]
      content_value = nil
      content_value = page.content[key] unless page.content.nil?
      href_attribute = nil
Severity: Minor
Found in app/helpers/rubber_ring/cms_helper.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_templates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def build_templates(page_templates, page, key)
        templates_concatenated = ''

        page_templates.each_with_index do |t, index|
          t.id = t.id.nil? ? index : t.id
Severity: Minor
Found in app/helpers/rubber_ring/cms_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status