Sign upLogin

zkoss/zk

View on GitHub
Star
eslint-plugin-zk/src/rules/noLocationHrefAssign.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function create has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    create(context) {
        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
        // @ts-ignore
        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
        const escapeFunc: string = context.options[0] && context.options[0]['escapeFunc'] || 'escape';
Severity: Minor
Found in eslint-plugin-zk/src/rules/noLocationHrefAssign.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    create(context) {
        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
        // @ts-ignore
        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
        const escapeFunc: string = context.options[0] && context.options[0]['escapeFunc'] || 'escape';
Severity: Minor
Found in eslint-plugin-zk/src/rules/noLocationHrefAssign.ts - About 1 hr to fix

    Function AssignmentExpression has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                AssignmentExpression: function (node) {
                const left = node.left as TSESTree.Expression & {property?: {name: string}, object: {name: string, property?: TSESTree.Identifier}};
                // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
                const isHref: boolean = left.property?.name === 'href';
                if (!isHref) {
    Severity: Minor
    Found in eslint-plugin-zk/src/rules/noLocationHrefAssign.ts - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                          return;
      Severity: Major
      Found in eslint-plugin-zk/src/rules/noLocationHrefAssign.ts - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status