Sign upLogin

zkoss/zk

View on GitHub
Star
eslint-plugin-zk/src/rules/noNull.ts

Summary

Maintainability
C
1 day
Test Coverage

Function create has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    create(context) {
        function checkTypeSyntax(node: TSESTree.TSTypeAnnotation | TSESTree.TSTypeAssertion | TSESTree.TSAsExpression) {
            if (node.typeAnnotation.type === AST_NODE_TYPES.TSNullKeyword) {
                context.report({
                    node: node,
Severity: Minor
Found in eslint-plugin-zk/src/rules/noNull.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    create(context) {
        function checkTypeSyntax(node: TSESTree.TSTypeAnnotation | TSESTree.TSTypeAssertion | TSESTree.TSAsExpression) {
            if (node.typeAnnotation.type === AST_NODE_TYPES.TSNullKeyword) {
                context.report({
                    node: node,
Severity: Major
Found in eslint-plugin-zk/src/rules/noNull.ts - About 2 hrs to fix

    Function Literal has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                Literal(node) {
                if (node.raw === 'null') {
                    let parent = node.parent;
                    while (parent) {
                        if (visitedNode[parent.range.toString()]) {
    Severity: Minor
    Found in eslint-plugin-zk/src/rules/noNull.ts - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                                      if (callee.property.name === 'attr') {
                                    visitedNode[parent.range.toString()] = true;
                                    // ignore for .attr(key, null);
                                    return;
                                }
      Severity: Major
      Found in eslint-plugin-zk/src/rules/noNull.ts - About 45 mins to fix

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            meta: {
        type: 'problem',
        docs: {
            description: 'Use undefined instead of null.',
            recommended: 'error',
        Severity: Major
        Found in eslint-plugin-zk/src/rules/noNull.ts and 5 other locations - About 40 mins to fix
        eslint-plugin-zk/src/rules/noAccessModifier.ts on lines 17..28
        eslint-plugin-zk/src/rules/noTopLevelScopingIIFE.ts on lines 6..17
        eslint-plugin-zk/src/rules/preferNativeClass.ts on lines 8..19
        eslint-plugin-zk/src/rules/preferNativeInstanceof.ts on lines 6..17
        eslint-plugin-zk/src/rules/preferStrictBooleanType.ts on lines 17..28

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (node.typeAnnotation.type === AST_NODE_TYPES.TSNullKeyword) {
                context.report({
                    node: node,
                    messageId: 'useUndefined',
                    fix(fixer) {
        Severity: Minor
        Found in eslint-plugin-zk/src/rules/noNull.ts and 1 other location - About 35 mins to fix
        eslint-plugin-zk/src/rules/noNull.ts on lines 43..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (t.type === AST_NODE_TYPES.TSNullKeyword) {
                        context.report({
                            node: t,
                            messageId: 'useUndefined',
                            fix(fixer) {
        Severity: Minor
        Found in eslint-plugin-zk/src/rules/noNull.ts and 1 other location - About 35 mins to fix
        eslint-plugin-zk/src/rules/noNull.ts on lines 33..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status