Sign upLogin

zkoss/zk

View on GitHub
Star

Showing 2,934 of 7,758 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        _heads = new AbstractCollection<Component>() {
            public int size() {
                int sz = getChildren().size();
                if (_rows != null)
                    --sz;
Severity: Major
Found in zul/src/main/java/org/zkoss/zul/Grid.java and 1 other location - About 1 hr to fix
zul/src/main/java/org/zkoss/zul/Tree.java on lines 262..279

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        _heads = new AbstractCollection<Component>() {
            public int size() {
                int sz = getChildren().size();
                if (_treechildren != null)
                    --sz;
Severity: Major
Found in zul/src/main/java/org/zkoss/zul/Tree.java and 1 other location - About 1 hr to fix
zul/src/main/java/org/zkoss/zul/Grid.java on lines 281..298

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if (method != null) {

                BindingExecutionInfoCollector collector = getBindingExecutionInfoCollector();
                if (collector != null) {
                    collector.addInfo(new CommandInfo(CommandInfo.EXECUTE, comp, null, null, command, commandArgs,
Severity: Major
Found in zkbind/src/main/java/org/zkoss/bind/impl/BinderImpl.java and 1 other location - About 1 hr to fix
zkbind/src/main/java/org/zkoss/bind/impl/BinderImpl.java on lines 1898..1911

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/AstDeferredExpression.java and 1 other location - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/AstDynamicExpression.java on lines 1..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (cmp > 0) {
                if ((_flags & NO_FUTURE) != 0)
                    throw wrongValue(comp, getMessageForDateDenied());
            } else if (cmp == 0) {
                if ((_flags & NO_TODAY) != 0)
Severity: Major
Found in zul/src/main/java/org/zkoss/zul/SimpleConstraint.java and 1 other location - About 1 hr to fix
zul/src/main/java/org/zkoss/zul/SimpleConstraint.java on lines 372..381

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (cmp > 0) {
                if ((_flags & NO_POSITIVE) != 0)
                    throw wrongValue(comp, getMessageForNumberDenied());
            } else if (cmp == 0) {
                if ((_flags & NO_ZERO) != 0)
Severity: Major
Found in zul/src/main/java/org/zkoss/zul/SimpleConstraint.java and 1 other location - About 1 hr to fix
zul/src/main/java/org/zkoss/zul/SimpleConstraint.java on lines 403..412

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/AstDynamicExpression.java and 1 other location - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/AstDeferredExpression.java on lines 1..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                for (const key in data) {
                    if (Object.prototype.hasOwnProperty.call(data, key)) {
                        newData[key] = _deconstructPacket(data[key] as never, buffers);
                    }
                }
Severity: Major
Found in zk/src/main/resources/web/js/zk/au.ts and 1 other location - About 1 hr to fix
zk/src/main/resources/web/js/zk/au.ts on lines 1366..1370

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                for (const key in data) {
                    if (Object.prototype.hasOwnProperty.call(data, key)) {
                        data[key] = _constructPacket(data[key] as never, files);
                    }
                }
Severity: Major
Found in zk/src/main/resources/web/js/zk/au.ts and 1 other location - About 1 hr to fix
zk/src/main/resources/web/js/zk/au.ts on lines 1397..1401

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

private int jjMoveStringLiteralDfa8_2(long old0, long active0)
{
   if (((active0 &= old0)) == 0L)
      return jjStartNfa_2(6, old0);
   try { curChar = input_stream.readChar(); }
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java and 7 other locations - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 598..615
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 616..633
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 634..651
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1391..1408
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1409..1426
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1427..1444
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1445..1462

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

private int jjMoveStringLiteralDfa6_2(long old0, long active0)
{
   if (((active0 &= old0)) == 0L)
      return jjStartNfa_2(4, old0);
   try { curChar = input_stream.readChar(); }
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java and 7 other locations - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 598..615
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 634..651
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 652..669
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1391..1408
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1409..1426
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1427..1444
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1445..1462

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

private int jjMoveStringLiteralDfa7_2(long old0, long active0)
{
   if (((active0 &= old0)) == 0L)
      return jjStartNfa_2(5, old0);
   try { curChar = input_stream.readChar(); }
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java and 7 other locations - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 598..615
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 616..633
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 652..669
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1391..1408
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1409..1426
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1427..1444
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1445..1462

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

private int jjMoveStringLiteralDfa7_1(long old0, long active0)
{
   if (((active0 &= old0)) == 0L)
      return jjStartNfa_1(5, old0);
   try { curChar = input_stream.readChar(); }
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java and 7 other locations - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 598..615
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 616..633
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 634..651
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 652..669
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1391..1408
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1409..1426
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1445..1462

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

private int jjMoveStringLiteralDfa5_2(long old0, long active0)
{
   if (((active0 &= old0)) == 0L)
      return jjStartNfa_2(3, old0);
   try { curChar = input_stream.readChar(); }
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java and 7 other locations - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 616..633
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 634..651
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 652..669
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1391..1408
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1409..1426
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1427..1444
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1445..1462

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

private int jjMoveStringLiteralDfa5_1(long old0, long active0)
{
   if (((active0 &= old0)) == 0L)
      return jjStartNfa_1(3, old0);
   try { curChar = input_stream.readChar(); }
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java and 7 other locations - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 598..615
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 616..633
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 634..651
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 652..669
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1409..1426
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1427..1444
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1445..1462

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

private int jjMoveStringLiteralDfa6_1(long old0, long active0)
{
   if (((active0 &= old0)) == 0L)
      return jjStartNfa_1(4, old0);
   try { curChar = input_stream.readChar(); }
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java and 7 other locations - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 598..615
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 616..633
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 634..651
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 652..669
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1391..1408
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1427..1444
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1445..1462

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

private int jjMoveStringLiteralDfa8_1(long old0, long active0)
{
   if (((active0 &= old0)) == 0L)
      return jjStartNfa_1(6, old0);
   try { curChar = input_stream.readChar(); }
Severity: Major
Found in zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java and 7 other locations - About 1 hr to fix
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 598..615
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 616..633
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 634..651
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 652..669
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1391..1408
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1409..1426
zel/src/main/java/org/zkoss/zel/impl/parser/ELParserTokenManager.java on lines 1427..1444

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    static public class Item {
        String name;
        
        List<String> options = new ArrayList<String>();
Severity: Major
Found in zktest/src/main/java/org/zkoss/zktest/bind/issue/F00743_2.java and 1 other location - About 1 hr to fix
zktest/src/main/java/org/zkoss/zktest/bind/issue/F00743_1.java on lines 89..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public PrintWriter getWriter() throws IOException {
        if (_sos != null)
            throw new IllegalStateException("getOutputStream was called");

        if (_pwt == null) {
Severity: Major
Found in zweb/src/main/java/org/zkoss/web/servlet/BufferedResponse.java and 1 other location - About 1 hr to fix
zweb/src/main/java/org/zkoss/web/servlet/http/HttpBufferedResponse.java on lines 93..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    static public class Item {
        String name;
        
        List<String> options = new ArrayList<String>();
Severity: Major
Found in zktest/src/main/java/org/zkoss/zktest/bind/issue/F00743_1.java and 1 other location - About 1 hr to fix
zktest/src/main/java/org/zkoss/zktest/bind/issue/F00743_2.java on lines 53..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language