Sign upLogin

zkoss/zk

View on GitHub
Star

Showing 7,775 of 7,775 total issues

Method getAttributes has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Map<String, Object> getAttributes(int scope) {
        switch (scope) {
        case SPACE_SCOPE:
            if (this instanceof IdSpace)
                return getAttributes();
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/AbstractComponent.java - About 1 hr to fix

    Method enableServerPush has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private boolean enableServerPush(ServerPush serverPush, boolean enable, Serializable enabler) {
        synchronized (enablers) {
            boolean enablersEmptyBefore = enablers.isEmpty();
            if (enable) {
                //handle dummy target
    Severity: Minor
    Found in zk/src/main/java/org/zkoss/zk/ui/impl/DesktopImpl.java - About 1 hr to fix

      Method checkPageRemoved has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void checkPageRemoved(Set<Component> removed) {
        //1. scan once
        final Desktop desktop = _exec.getDesktop();
        Set<Page> pages = null;
        for (Page page : desktop.getPages()) {
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/impl/UiVisualizer.java - About 1 hr to fix

        Method mergeResponses has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private List<AuResponse> mergeResponses(List<AuResponse> responses) {
        if (responses.size() >= 2) { // worth merging
            List<AuSetAttribute> bulk = new LinkedList<>();
            ListIterator<AuResponse> iterator = responses.listIterator();
            Object previousDepends = null, currentDepends = null;
        Severity: Minor
        Found in zk/src/main/java/org/zkoss/zk/ui/impl/UiEngineImpl.java - About 1 hr to fix

          Method getFromNamespace has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected Object getFromNamespace(String name) {
        final Scope scope = getCurrent();
        if (scope != null) { //null means no scope allowed!
            final Execution exec = Executions.getCurrent();
            if (exec != null && exec != scope) {
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/scripting/util/GenericInterpreter.java - About 1 hr to fix

            Method coerceToUi has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @SuppressWarnings("unchecked")
    public Object coerceToUi(Object val, Component comp, BindContext ctx) {
        Tree tree = (Tree) comp;
        final TreeModel<Object> model = tree.getModel();
        if (model != null && !(model instanceof TreeSelectableModel)) {
            Severity: Minor
            Found in zkbind/src/main/java/org/zkoss/bind/converter/sys/TreeSelectedItemsConverter.java - About 1 hr to fix

              Method processPropertyLoadBindings has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private void processPropertyLoadBindings(Component comp, String propName, Annotation ann,
            ExpressionAnnoInfo converterInfo) {
        String loadExpr = null;
        final List<String> beforeCmds = new ArrayList<String>();
        final List<String> afterCmds = new ArrayList<String>();
              Severity: Minor
              Found in zkbind/src/main/java/org/zkoss/bind/impl/AnnotateBinderHelper.java - About 1 hr to fix

                Method processChildrenLoadBindings has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private void processChildrenLoadBindings(Component comp, Annotation ann, ExpressionAnnoInfo converterInfo) {
        String loadExpr = null;
        final List<String> beforeCmds = new ArrayList<String>();
        final List<String> afterCmds = new ArrayList<String>();
                Severity: Minor
                Found in zkbind/src/main/java/org/zkoss/bind/impl/AnnotateBinderHelper.java - About 1 hr to fix

                  Method processFormSaveBindings has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private void processFormSaveBindings(Component comp, String formId, Annotation ann,
            ExpressionAnnoInfo validatorInfo) {
        String saveExpr = null;
        final List<String> beforeCmds = new ArrayList<String>();
        final List<String> afterCmds = new ArrayList<String>();
                  Severity: Minor
                  Found in zkbind/src/main/java/org/zkoss/bind/impl/AnnotateBinderHelper.java - About 1 hr to fix

                    Method doSort has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        /*package*/ boolean doSort(boolean ascending) {
        final Comparator<?> cmpr = ascending ? _sortAsc : _sortDsc;
        if (cmpr == null)
            return false;
                    Severity: Minor
                    Found in zul/src/main/java/org/zkoss/zul/Column.java - About 1 hr to fix

                      Method setMold has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public void setMold(String mold) {
        final String old = getMold();
        if (!Objects.equals(old, mold)) {
            super.setMold(mold);
            //we have to change model before detaching paging,
                      Severity: Minor
                      Found in zul/src/main/java/org/zkoss/zul/Tree.java - About 1 hr to fix

                        Method getVisibleIndexOfItem0 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private int getVisibleIndexOfItem0(Treeitem item, boolean inclusive) {
        // ZK-2539: use vector instead of recursive calls to avoid stack overflow
        // when number of tree items is huge.
        Vector<Treeitem> items = new Vector<Treeitem>();
        int count = 0;
                        Severity: Minor
                        Found in zul/src/main/java/org/zkoss/zul/Tree.java - About 1 hr to fix

                          Method include has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private void include(Writer out) throws IOException {
        final Desktop desktop = getDesktop();
        final Execution exec = getExecution();
        final String src = exec.toAbsoluteURI(_src, false);
        final Map<String, Object> old = setupDynams(exec);
                          Severity: Minor
                          Found in zul/src/main/java/org/zkoss/zul/Include.java - About 1 hr to fix

                            Method compare has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                @SuppressWarnings("unchecked")
    public int compare(Object o1, Object o2) {
        final int index = _index < 0 && _treecol != null ? _treecol.getColumnIndex() : _index;

        Object v1, v2;
                            Severity: Minor
                            Found in zul/src/main/java/org/zkoss/zul/TreeitemComparator.java - About 1 hr to fix

                              Method compare has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public int compare(Object o1, Object o2) {
        final int index = _index < 0 && _header != null ? _header.getColumnIndex() : _index;

        Object v1, v2;
        if (o1 instanceof Listitem) { //not live data
                              Severity: Minor
                              Found in zul/src/main/java/org/zkoss/zul/ListitemComparator.java - About 1 hr to fix

                                Method renderDesktop has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    protected void renderDesktop(Execution exec, Page page, Writer out) throws IOException {
        HtmlPageRenders.setContentType(exec, page);

        final PageCtrl pageCtrl = (PageCtrl) page;
        write(out, HtmlPageRenders.outFirstLine(exec, page)); //might null
                                Severity: Minor
                                Found in zul/src/main/java/org/zkoss/zul/impl/PageRenderer.java - About 1 hr to fix

                                  Method beforeChildAdded has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      public void beforeChildAdded(Component newChild, Component refChild) {
        if (newChild instanceof Listitem) {
            if (newChild instanceof Listgroupfoot) {
                if (!hasGroup())
                    throw new UiException("Listgroupfoot cannot exist alone, you have to add a Listgroup first");
                                  Severity: Minor
                                  Found in zul/src/main/java/org/zkoss/zul/Listbox.java - About 1 hr to fix

                                    Method setup has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        public static final Object setup(HttpSession sess, ServletRequest request, ServletResponse response,
            String charset) {
        if (hasSetup(request)) //processed before?
            return Objects.UNKNOWN;
                                    Severity: Minor
                                    Found in zweb/src/main/java/org/zkoss/web/servlet/Charsets.java - About 1 hr to fix

                                      Function position has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                        function position(row, u, rect, flush) {
    var i = -1,
        n = row.length,
        x = rect.x,
        y = rect.y,
                                      Severity: Minor
                                      Found in zktest/src/main/webapp/js/d3.layout.js - About 1 hr to fix

                                        Function attr has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                        d3_selectionPrototype.attr = function(name, value) {
  name = d3.ns.qualify(name);

  // If no value is specified, return the first value.
  if (arguments.length < 2) {
                                        Severity: Minor
                                        Found in zktest/src/main/webapp/js/d3.js - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language