Showing 7,775 of 7,775 total issues
Method addChildrenLoadBindings0
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
private void addChildrenLoadBindings0(Component comp, String loadExpr, String[] beforeCmds, String[] afterCmds,
Map<String, Object> bindingArgs, String converterExpr, Map<String, Object> converterArgs) {
Method newLoadChildrenBinding
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
protected LoadChildrenBinding newLoadChildrenBinding(Component comp, String loadExpr, ConditionType conditionType,
String command, Map<String, Object> bindingArgs, String converterExpr, Map<String, Object> converterArgs) {
Method addChildrenLoadBindings
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public void addChildrenLoadBindings(Component comp, String loadExpr, String[] beforeCmds, String[] afterCmds,
Map<String, Object> bindingArgs, String converterExpr, Map<String, Object> converterArgs) {
Method get
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public static Media[] get(Map<String, Object> params, String message, String title, int max, int maxsize,
boolean alwaysNative, EventListener<UploadEvent> listener) {
Method show
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public static Button show(String message, String title, Button[] buttons, String[] btnLabels, String icon,
Button focus, EventListener<ClickEvent> listener) {
Method show
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public static int show(int messageCode, Object arg, int titleCode, int buttons, String icon, int focus,
EventListener<Event> listener) {
Method show
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public static int show(int messageCode, Object[] args, int titleCode, int buttons, String icon, int focus,
EventListener<Event> listener) {
Method addValue
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public void addValue(Date date, Number open, Number high, Number low, Number close, Number volumn, int index);
Method setValue
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public void setValue(Date date, Number open, Number high, Number low, Number close, Number volumn, int index);
Method setValue
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public void setValue(Date date, Number open, Number high, Number low, Number close, Number volume, int index) {
Method addValue
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public void addValue(Date date, Number open, Number high, Number low, Number close, Number volume, int index) {
Method render
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public static final void render(ServletContext ctx, HttpServletRequest request, HttpServletResponse response,
Richlet richlet, String path, boolean pageDOM, Writer out) throws ServletException, IOException {
Method addValue0
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
private int addValue0(Date date, Number open, Number high, Number low, Number close, Number volume, int index) {
Method interpret
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public final void interpret(ServletContext ctx, HttpServletRequest request, HttpServletResponse response,
Writer out, String content, String ctype, Locator locator) throws DspException, IOException, XelException {
Function e
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
e = function(a, b, e, k, l, m, n) {
Function access
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
var access = function( elems, fn, key, value, chainable, emptyGet, raw ) {
Function createDate
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
function createDate(y, m, d, h, M, s, ms) {
Function zkpb
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
export function zkpb(pguid: string, dtid: string, contextURI: string, updateURI: string, resourceURI: string, reqURI: string, props: Record<string, string>): void {
Function parseDate
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
txt: string,
fmt: string,
nonLenient?: boolean,
refval?: DateImpl,
localizedSymbols?: zk.LocalizedSymbols,
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (params != null && !params.isEmpty()) {
_params = new LinkedHashMap<String, ExValue>();
for (Map.Entry<String, String> me : params.entrySet())
_params.put(me.getKey(), new ExValue(me.getValue(), Object.class));
} else
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 62.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76