Showing 7,765 of 7,765 total issues

Method setId has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void setId(String id) {
        if (!((ExecutionCtrl) _exec).isRecovering())
            throw new IllegalStateException("Callable only in recovering");
        if (id == null || id.length() <= 1)
            throw new IllegalArgumentException(
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/impl/DesktopImpl.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void process() throws Exception {
        final ExecutionMonitor execmon = _desktop.getWebApp().getConfiguration().getExecutionMonitor();
        //Bug 1506712: event listeners might be zscript, so we have to
        //keep built-in variables as long as possible
        final Scope scope = Scopes.beforeInterpret(_comp);
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/impl/EventProcessor.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method outDeviceCSSContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public static String outDeviceCSSContent(ServletContext ctx, HttpServletRequest request,
            HttpServletResponse response, String deviceType) {
        final StringWriter sw = new StringWriter();
        for (Iterator it = LanguageDefinition.getByDeviceType(deviceType).iterator(); it.hasNext();) {
            final LanguageDefinition langdef = (LanguageDefinition) it.next();
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/fn/JspFns.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method isIgnorable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        public boolean isIgnorable(Object request, WebApp wapp) {
            final HttpServletRequest hreq = (HttpServletRequest) request;
            for (int j = 0;; ++j) {
                if (hreq.getParameter("cmd_" + j) == null)
                    break;
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/au/http/DHtmlUpdateServlet.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method convertToItems has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    public static <T extends Component> Set<T> convertToItems(Desktop desktop, List<String> uuids) {
        final Set<T> items = new LinkedHashSet<T>();
        if (uuids != null)
            for (String uuid : uuids) {
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/au/AuRequests.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method spaceOwner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private static IdSpace spaceOwner(Component p, boolean ignoreVirtualIS) {
        Component top;
        do {
            if (p instanceof IdSpace)
                return (IdSpace) p;
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/AbstractComponent.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method invokeExecutionInits has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void invokeExecutionInits(Execution exec, Execution parent) throws UiException {
        if (_execInits != null) {
            for (Iterator<ExecutionInit> it = new LinkedList<ExecutionInit>(_execInits).iterator(); it.hasNext();) {
                try {
                    it.next().init(exec, parent);
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/impl/DesktopImpl.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hasVariableResolver has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean hasVariableResolver(Class<? extends VariableResolver> cls) {
        if (_resolvers != null)
            for (final VariableResolver resolver : _resolvers)
                if (cls.isInstance(resolver))
                    return true;
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/impl/AbstractExecution.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getDevice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public static final Device getDevice(String deviceType) throws DeviceNotFoundException {
        final Object o; //null, Device or DeviceInfo
        synchronized (_devmap) {
            o = _devmap.get(deviceType);
        }
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/device/Devices.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method onBeforeDeactivate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    public void onBeforeDeactivate() {
        if (_desktop != null) {
            List<Callback> callbacks = (List<Callback>) _desktop.getAttribute(Add_ON_DEACTIVATE);
            if (callbacks != null) {
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/impl/AbstractExecution.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method onActivate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    public void onActivate() {
        if (_desktop != null) {
            List<Callback> callbacks = (List<Callback>) _desktop.getAttribute(Add_ON_ACTIVATE);
            if (callbacks != null) {
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/impl/AbstractExecution.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method newDevice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        private Device newDevice(String deviceType) {
            if (_dvcls == null) //possible
                throw new DeviceNotFoundException(deviceType, MZk.NOT_FOUND, deviceType);

            try {
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/device/Devices.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method prepareProperty has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public static Property prepareProperty(Object base, String prop, Object value, BindContext ctx) {
        if (ctx != null && prop.indexOf('[') >= 0) { //handle properties that containing [] indirect reference
            final Binder binder = ctx.getBinder();
            final Component comp = ctx.getComponent();
            Object old = null;
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getInterpreter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    /*package*/ static BSHInterpreter getInterpreter(Scope scope) {
        Page owner = getPage(scope);
        if (owner != null) {
            for (Iterator it = owner.getLoadedInterpreters().iterator(); it.hasNext();) {
                final Object ip = it.next();
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/scripting/bsh/BSHInterpreter.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void setValue(ELContext ctx, Object base, Object property, Object value)
            throws PropertyNotFoundException, PropertyNotWritableException, ELException {

        if (base == null) {
            //ZK-1085 PropertyNotWritableException when using reference binding
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELResolver.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doBeforeComposeChildren has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void doBeforeComposeChildren(final Component comp) throws Exception {
        //ZK-3831
        if (comp.getPage() == null) {
            final Map<?, ?> currentArg = Executions.getCurrent().getArg();
            ((ComponentCtrl) comp).addCallback(ComponentCtrl.AFTER_PAGE_ATTACHED, new Callback() {
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/BindComposer.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean parse(Attribute attr, ComponentInfo compInfo, PageDefinition pgdef) throws Exception {
        if (!(compInfo instanceof NativeInfo) && "".equals(attr.getNamespaceURI()))
            return false; // not what we care.

        final String name = attr.getLocalName();
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/impl/ClientBinderCommandParser.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolveTemplate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected Template resolveTemplate(Component templateComp, Component comp, Object data, int index, int size,
            String defaultName, String subType) {
        //a detached component(ex,grid.onInitRender) will still call the render, see test case collection-template-grid.zul
        //TODO need to check is this a zk bug and report it
        if (comp.getPage() == null)
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/impl/AbstractRenderer.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getCurrent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected Scope getCurrent() {
        if (!_scopes.isEmpty()) {
            Object o = _scopes.get(0);
            if (o == Objects.UNKNOWN)
                return null; //no scope allowed
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/scripting/util/GenericInterpreter.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    public Object getValue(ELContext context, Object base, Object property)
            throws NullPointerException, PropertyNotFoundException, ELException {
        if (context == null) {
            throw new NullPointerException();

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language