Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/fsm/StateMachine.java

Summary

Maintainability
B
6 hrs
Test Coverage

StateMachine has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

public abstract class StateMachine<E, C, IN> {
    
    protected final Map<E, StateCtx<E, C, IN>> _states = 
        new HashMap<E, StateCtx<E, C, IN>>();
    protected E _current;
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/fsm/StateMachine.java - About 3 hrs to fix

    Method run has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public final void run(IN input) {
        
        C inputClass = getClass(input);
        
        doDebug("");
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/fsm/StateMachine.java - About 1 hr to fix

      Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public final void run(IN input) {
        
        C inputClass = getClass(input);
        
        doDebug("");
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/fsm/StateMachine.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status