Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/html/HTMLs.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method getTextRelevantStyle has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public static final String getTextRelevantStyle(final String style) {
        if (style == null) return null;
        if (style.length() == 0) return "";

        final StringBuffer sb = new StringBuffer(64);
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/html/HTMLs.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getSubstyleIndex has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public static final int getSubstyleIndex(String style, String substyle) {
        if (style == null || substyle == null)
            throw new IllegalArgumentException("null");
        if (substyle.length() == 0)
            throw new IllegalArgumentException("empty substyle");
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/html/HTMLs.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

            if (c >= 0x30 && c <= 0x39 || c >= 0x41 && c <= 0x5A || c >= 0x61
                    && c <= 0x7A) {
                hex[c] = null;
            } else {
                hex[c] = toHex(c).intern();
Severity: Major
Found in zcommon/src/main/java/org/zkoss/html/HTMLs.java - About 40 mins to fix

    Method getSubstyleValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static final String getSubstyleValue(final String style, int j) {
        final int len = style.length();
        int k = -1, l = j;
        for (; l < len; ++l) {
            final char cc = style.charAt(l);
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/html/HTMLs.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            for (; l < len; ++l) {
            final char cc = style.charAt(l);
            if (k < 0  && cc == ':') k = l; //colon found
            else if (cc == ';') break; //done
        }
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/html/HTMLs.java and 2 other locations - About 50 mins to fix
    zcommon/src/main/java/org/zkoss/html/HTMLs.java on lines 115..119
    zcommon/src/main/java/org/zkoss/html/HTMLs.java on lines 162..166

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                for (; l < len; ++l) {
                final char cc = style.charAt(l);
                if (k < 0  && cc == ':') k = l; //colon found
                else if (cc == ';') break; //done
            }
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/html/HTMLs.java and 2 other locations - About 50 mins to fix
    zcommon/src/main/java/org/zkoss/html/HTMLs.java on lines 115..119
    zcommon/src/main/java/org/zkoss/html/HTMLs.java on lines 138..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                for (; l < len; ++l) {
                final char cc = style.charAt(l);
                if (k < 0  && cc == ':') k = l; //colon found
                else if (cc == ';') break; //done
            }
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/html/HTMLs.java and 2 other locations - About 50 mins to fix
    zcommon/src/main/java/org/zkoss/html/HTMLs.java on lines 138..142
    zcommon/src/main/java/org/zkoss/html/HTMLs.java on lines 162..166

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            final String[] orphans = {
            "area", "base", "basefont", "bgsound", "br",
            "col", "embed", "hr", "img", "input",
            "isindex", "keygen", "link", "meta", "plaintext",
            "spacer", "wbr"
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/html/HTMLs.java and 1 other location - About 30 mins to fix
    zk/src/main/java/org/zkoss/zk/ui/Components.java on lines 433..436

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status