Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/idom/Document.java

Summary

Maintainability
C
1 day
Test Coverage

Document has 39 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Document extends AbstractGroup implements org.w3c.dom.Document {
    /** The document type. */
    private DocType _docType;
    /** The root element. */
    private Element _root;
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/idom/Document.java - About 5 hrs to fix

    Method checkAdd has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            private void checkAdd(Item newItem, Item other, boolean replace) {
            //allowed type?
            if (!(newItem instanceof Element) && !(newItem instanceof DocType)
            && !(newItem instanceof Comment)
            && !(newItem instanceof ProcessingInstruction)
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/Document.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setRootElement has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public final void setRootElement(Element root) {
        if (root == null) {
            if (_root != null)
                _children.remove(_root);
        } else {
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/Document.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setDocType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public final void setDocType(DocType docType) {
        if (docType == null) {
            if (_docType != null)
                _children.remove(_docType);
        } else {
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/Document.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public final void setDocType(DocType docType) {
        if (docType == null) {
            if (_docType != null)
                _children.remove(_docType);
        } else {
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/Document.java and 1 other location - About 50 mins to fix
    zcommon/src/main/java/org/zkoss/idom/Document.java on lines 73..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public final void setRootElement(Element root) {
        if (root == null) {
            if (_root != null)
                _children.remove(_root);
        } else {
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/Document.java and 1 other location - About 50 mins to fix
    zcommon/src/main/java/org/zkoss/idom/Document.java on lines 93..103

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (Document.this._root != null && (newItem instanceof Element) 
            && (!replace || !(other instanceof Element)))
                throw new DOMException(DOMException.HIERARCHY_REQUEST_ERR,
                    "Only one root element is allowed, when adding "+newItem, getLocator());
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/Document.java and 1 other location - About 45 mins to fix
    zcommon/src/main/java/org/zkoss/idom/Document.java on lines 278..281

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (Document.this._docType != null && (newItem instanceof DocType)
            && (!replace || !(other instanceof DocType)))
                throw new DOMException(DOMException.HIERARCHY_REQUEST_ERR,
                    "Only one document type is allowed, when adding "+newItem, getLocator());
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/Document.java and 1 other location - About 45 mins to fix
    zcommon/src/main/java/org/zkoss/idom/Document.java on lines 274..277

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if (!(newItem instanceof Element) && !(newItem instanceof DocType)
            && !(newItem instanceof Comment)
            && !(newItem instanceof ProcessingInstruction)
            && !(newItem instanceof EntityReference))
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/Document.java and 1 other location - About 40 mins to fix
    zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java on lines 464..466

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status